From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ronald Rojas Subject: [PATCH RFC] xl_cmdimpl.c: Fix printf usage Date: Wed, 12 Oct 2016 14:52:56 -0400 Message-ID: <1476298376-14901-1-git-send-email-ronladred@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, wei.liu2@citrix.com, george.dunlap@citrix.com Cc: Ronald Rojas List-Id: xen-devel@lists.xenproject.org Q2hhbmdlIGluc3RhbmNlcyBvZiBwcmludGYsIGZwcmludGYsIGFuZCBMT0cgd2hlcmUgdGhlIHNw ZWNpZmllcgp1c2VkIGlzICclZCcgdG8gYmUgJyV1JyBmb3IgZG9taWQuCgpTaWduZWQtb2ZmLWJ5 OiBSb25hbGQgUm9qYXMgPHJvbmxhZHJlZEBnbWFpbC5jb20+Ci0tLQogdG9vbHMvbGlieGwveGxf Y21kaW1wbC5jIHwgMjYgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9s aWJ4bC94bF9jbWRpbXBsLmMgYi90b29scy9saWJ4bC94bF9jbWRpbXBsLmMKaW5kZXggY2I0M2Mw MC4uYjE1NGUzNiAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCisrKyBiL3Rv b2xzL2xpYnhsL3hsX2NtZGltcGwuYwpAQCAtMjY3NCw3ICsyNjc0LDcgQEAgc3RhdGljIGludCBw cmVzZXJ2ZV9kb21haW4odWludDMyX3QgKnJfZG9taWQsIGxpYnhsX2V2ZW50ICpldmVudCwKIAog ICAgIGxpYnhsX3V1aWRfZ2VuZXJhdGUoJm5ld191dWlkKTsKIAotICAgIExPRygiUHJlc2Vydmlu ZyBkb21haW4gJWQgJXMgd2l0aCBzdWZmaXglcyIsCisgICAgTE9HKCJQcmVzZXJ2aW5nIGRvbWFp biAldSAlcyB3aXRoIHN1ZmZpeCVzIiwKICAgICAgICAgKnJfZG9taWQsIGRfY29uZmlnLT5jX2lu Zm8ubmFtZSwgc3RydGltZSk7CiAgICAgcmMgPSBsaWJ4bF9kb21haW5fcHJlc2VydmUoY3R4LCAq cl9kb21pZCwgJmRfY29uZmlnLT5jX2luZm8sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc3RydGltZSwgbmV3X3V1aWQpOwpAQCAtMjc1OCw3ICsyNzU4LDcgQEAgc3RhdGljIGludCBk b21haW5fd2FpdF9ldmVudCh1aW50MzJfdCBkb21pZCwgbGlieGxfZXZlbnQgKipldmVudF9yKQog ICAgIGZvciAoOzspIHsKICAgICAgICAgcmV0ID0gbGlieGxfZXZlbnRfd2FpdChjdHgsIGV2ZW50 X3IsIExJQlhMX0VWRU5UTUFTS19BTEwsIDAsMCk7CiAgICAgICAgIGlmIChyZXQpIHsKLSAgICAg ICAgICAgIExPRygiRG9tYWluICVkLCBmYWlsZWQgdG8gZ2V0IGV2ZW50LCBxdWl0dGluZyAocmM9 JWQpIiwgZG9taWQsIHJldCk7CisgICAgICAgICAgICBMT0coIkRvbWFpbiAldSwgZmFpbGVkIHRv IGdldCBldmVudCwgcXVpdHRpbmcgKHJjPSVkKSIsIGRvbWlkLCByZXQpOwogICAgICAgICAgICAg cmV0dXJuIHJldDsKICAgICAgICAgfQogICAgICAgICBpZiAoKCpldmVudF9yKS0+ZG9taWQgIT0g ZG9taWQpIHsKQEAgLTMxMDgsNyArMzEwOCw3IEBAIHN0YXJ0OgogICAgICAgICB9CiAgICAgICAg IG5lZWRfZGFlbW9uID0gMDsKICAgICB9Ci0gICAgTE9HKCJXYWl0aW5nIGZvciBkb21haW4gJXMg KGRvbWlkICVkKSB0byBkaWUgW3BpZCAlbGRdIiwKKyAgICBMT0coIldhaXRpbmcgZm9yIGRvbWFp biAlcyAoZG9taWQgJXUpIHRvIGRpZSBbcGlkICVsZF0iLAogICAgICAgICBkX2NvbmZpZy5jX2lu Zm8ubmFtZSwgZG9taWQsIChsb25nKWdldHBpZCgpKTsKIAogICAgIHJldCA9IGxpYnhsX2V2ZW5h YmxlX2RvbWFpbl9kZWF0aChjdHgsIGRvbWlkLCAwLCAmZGVhdGh3KTsKQEAgLTMxMzQsNyArMzEz NCw3IEBAIHN0YXJ0OgogICAgICAgICBzd2l0Y2ggKGV2ZW50LT50eXBlKSB7CiAKICAgICAgICAg Y2FzZSBMSUJYTF9FVkVOVF9UWVBFX0RPTUFJTl9TSFVURE9XTjoKLSAgICAgICAgICAgIExPRygi RG9tYWluICVkIGhhcyBzaHV0IGRvd24sIHJlYXNvbiBjb2RlICVkIDB4JXgiLCBkb21pZCwKKyAg ICAgICAgICAgIExPRygiRG9tYWluICV1IGhhcyBzaHV0IGRvd24sIHJlYXNvbiBjb2RlICVkIDB4 JXgiLCBkb21pZCwKICAgICAgICAgICAgICAgICBldmVudC0+dS5kb21haW5fc2h1dGRvd24uc2h1 dGRvd25fcmVhc29uLAogICAgICAgICAgICAgICAgIGV2ZW50LT51LmRvbWFpbl9zaHV0ZG93bi5z aHV0ZG93bl9yZWFzb24pOwogICAgICAgICAgICAgc3dpdGNoIChoYW5kbGVfZG9tYWluX2RlYXRo KCZkb21pZCwgZXZlbnQsICZkX2NvbmZpZykpIHsKQEAgLTMxOTgsNyArMzE5OCw3IEBAIHN0YXJ0 OgogICAgICAgICAgICAgfQogCiAgICAgICAgIGNhc2UgTElCWExfRVZFTlRfVFlQRV9ET01BSU5f REVBVEg6Ci0gICAgICAgICAgICBMT0coIkRvbWFpbiAlZCBoYXMgYmVlbiBkZXN0cm95ZWQuIiwg ZG9taWQpOworICAgICAgICAgICAgTE9HKCJEb21haW4gJXUgaGFzIGJlZW4gZGVzdHJveWVkLiIs IGRvbWlkKTsKICAgICAgICAgICAgIGxpYnhsX2V2ZW50X2ZyZWUoY3R4LCBldmVudCk7CiAgICAg ICAgICAgICByZXQgPSAwOwogICAgICAgICAgICAgZ290byBvdXQ7CkBAIC0zNDQyLDcgKzM0NDIs NyBAQCBzdGF0aWMgaW50IHNldF9tZW1vcnlfbWF4KHVpbnQzMl90IGRvbWlkLCBjb25zdCBjaGFy ICptZW0pCiAgICAgfQogCiAgICAgaWYgKGxpYnhsX2RvbWFpbl9zZXRtYXhtZW0oY3R4LCBkb21p ZCwgbWVtb3J5a2IpKSB7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAiY2Fubm90IHNldCBkb21p ZCAlZCBzdGF0aWMgbWF4IG1lbW9yeSB0byA6ICVzXG4iLCBkb21pZCwgbWVtKTsKKyAgICAgICAg ZnByaW50ZihzdGRlcnIsICJjYW5ub3Qgc2V0IGRvbWlkICV1IHN0YXRpYyBtYXggbWVtb3J5IHRv IDogJXNcbiIsIGRvbWlkLCBtZW0pOwogICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwogICAg IH0KIApAQCAtMzQ3Niw3ICszNDc2LDcgQEAgc3RhdGljIGludCBzZXRfbWVtb3J5X3RhcmdldCh1 aW50MzJfdCBkb21pZCwgY29uc3QgY2hhciAqbWVtKQogICAgIH0KIAogICAgIGlmIChsaWJ4bF9z ZXRfbWVtb3J5X3RhcmdldChjdHgsIGRvbWlkLCBtZW1vcnlrYiwgMCwgLyogZW5mb3JjZSAqLyAx KSkgewotICAgICAgICBmcHJpbnRmKHN0ZGVyciwgImNhbm5vdCBzZXQgZG9taWQgJWQgZHluYW1p YyBtYXggbWVtb3J5IHRvIDogJXNcbiIsIGRvbWlkLCBtZW0pOworICAgICAgICBmcHJpbnRmKHN0 ZGVyciwgImNhbm5vdCBzZXQgZG9taWQgJXUgZHluYW1pYyBtYXggbWVtb3J5IHRvIDogJXNcbiIs IGRvbWlkLCBtZW0pOwogICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwogICAgIH0KIApAQCAt NDEzMyw3ICs0MTMzLDcgQEAgc3RhdGljIHZvaWQgc2h1dGRvd25fZG9tYWluKHVpbnQzMl90IGRv bWlkLAogewogICAgIGludCByYzsKIAotICAgIGZwcmludGYoc3RkZXJyLCAiU2h1dHRpbmcgZG93 biBkb21haW4gJWRcbiIsIGRvbWlkKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIlNodXR0aW5nIGRv d24gZG9tYWluICV1XG4iLCBkb21pZCk7CiAgICAgcmM9bGlieGxfZG9tYWluX3NodXRkb3duKGN0 eCwgZG9taWQpOwogICAgIGlmIChyYyA9PSBFUlJPUl9OT1BBUkFWSVJUKSB7CiAgICAgICAgIGlm IChmYWxsYmFja190cmlnZ2VyKSB7CkBAIC00MTY1LDcgKzQxNjUsNyBAQCBzdGF0aWMgdm9pZCBy ZWJvb3RfZG9tYWluKHVpbnQzMl90IGRvbWlkLCBsaWJ4bF9ldmdlbl9kb21haW5fZGVhdGggKipk ZWF0aHcsCiB7CiAgICAgaW50IHJjOwogCi0gICAgZnByaW50ZihzdGRlcnIsICJSZWJvb3Rpbmcg ZG9tYWluICVkXG4iLCBkb21pZCk7CisgICAgZnByaW50ZihzdGRlcnIsICJSZWJvb3RpbmcgZG9t YWluICV1XG4iLCBkb21pZCk7CiAgICAgcmM9bGlieGxfZG9tYWluX3JlYm9vdChjdHgsIGRvbWlk KTsKICAgICBpZiAocmMgPT0gRVJST1JfTk9QQVJBVklSVCkgewogICAgICAgICBpZiAoZmFsbGJh Y2tfdHJpZ2dlcikgewpAQCAtNTYyNSw3ICs1NjI1LDcgQEAgaW50IG1haW5fY29uZmlnX3VwZGF0 ZShpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAgICAgIHByaW50Zl9pbmZvKGRlZmF1bHRfb3V0 cHV0X2Zvcm1hdCwgLTEsICZkX2NvbmZpZywgc3Rkb3V0KTsKIAogICAgIGlmICghZHJ5cnVuX29u bHkpIHsKLSAgICAgICAgZnByaW50ZihzdGRlcnIsICJzZXR0aW5nIGRvbSVkIGNvbmZpZ3VyYXRp b25cbiIsIGRvbWlkKTsKKyAgICAgICAgZnByaW50ZihzdGRlcnIsICJzZXR0aW5nIGRvbSV1IGNv bmZpZ3VyYXRpb25cbiIsIGRvbWlkKTsKICAgICAgICAgcmMgPSBsaWJ4bF91c2VyZGF0YV9zdG9y ZShjdHgsIGRvbWlkLCAieGwiLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b25maWdfZGF0YSwgY29uZmlnX2xlbik7CiAgICAgICAgIGlmIChyYykgewpAQCAtNTk1MSw3ICs1 OTUxLDcgQEAgc3RhdGljIGludCB2Y3B1c2V0KHVpbnQzMl90IGRvbWlkLCBjb25zdCBjaGFyKiBu cl92Y3B1cywgaW50IGNoZWNrX2hvc3QpCiAgICAgaWYgKHJjID09IEVSUk9SX0RPTUFJTl9OT1RG T1VORCkKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJEb21haW4gJXUgZG9lcyBub3QgZXhpc3Qu XG4iLCBkb21pZCk7CiAgICAgZWxzZSBpZiAocmMpCi0gICAgICAgIGZwcmludGYoc3RkZXJyLCAi bGlieGxfc2V0X3ZjcHVvbmxpbmUgZmFpbGVkIGRvbWlkPSVkIG1heF92Y3B1cz0lZCwiIFwKKyAg ICAgICAgZnByaW50ZihzdGRlcnIsICJsaWJ4bF9zZXRfdmNwdW9ubGluZSBmYWlsZWQgZG9taWQ9 JXUgbWF4X3ZjcHVzPSVkLCIgXAogICAgICAgICAgICAgICAgICIgcmM6ICVkXG4iLCBkb21pZCwg bWF4X3ZjcHVzLCByYyk7CiAKICAgICBsaWJ4bF9iaXRtYXBfZGlzcG9zZSgmY3B1bWFwKTsKQEAg LTcxMTMsNyArNzExMyw3IEBAIGludCBtYWluX2RvbWlkKGludCBhcmdjLCBjaGFyICoqYXJndikK ICAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKICAgICB9CiAKLSAgICBwcmludGYoIiVkXG4i LCBkb21pZCk7CisgICAgcHJpbnRmKCIldVxuIiwgZG9taWQpOwogCiAgICAgcmV0dXJuIEVYSVRf U1VDQ0VTUzsKIH0KQEAgLTcxMzgsNyArNzEzOCw3IEBAIGludCBtYWluX2RvbW5hbWUoaW50IGFy Z2MsIGNoYXIgKiphcmd2KQogCiAgICAgZG9tbmFtZSA9IGxpYnhsX2RvbWlkX3RvX25hbWUoY3R4 LCBkb21pZCk7CiAgICAgaWYgKCFkb21uYW1lKSB7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAi Q2FuJ3QgZ2V0IGRvbWFpbiBuYW1lIG9mIGRvbWFpbiBpZCAnJWQnLCBtYXliZSB0aGlzIGRvbWFp biBkb2VzIG5vdCBleGlzdC5cbiIsIGRvbWlkKTsKKyAgICAgICAgZnByaW50ZihzdGRlcnIsICJD YW4ndCBnZXQgZG9tYWluIG5hbWUgb2YgZG9tYWluIGlkICcldScsIG1heWJlIHRoaXMgZG9tYWlu IGRvZXMgbm90IGV4aXN0LlxuIiwgZG9taWQpOwogICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJF OwogICAgIH0KIAotLSAKMi43LjQKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK