xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: [PATCH for-4.8 2/3] libacpi: require ACPI_BUILD_DIR to be set
Date: Fri, 14 Oct 2016 18:02:31 +0100	[thread overview]
Message-ID: <1476464552-12969-3-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1476464552-12969-1-git-send-email-wei.liu2@citrix.com>

It's better to have a explicit error than a build failure returned by
gcc.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jan Beulich <JBeulich@suse.com>
---
 tools/libacpi/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
index 24eb0c2..c1f0af8 100644
--- a/tools/libacpi/Makefile
+++ b/tools/libacpi/Makefile
@@ -15,6 +15,10 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
+ifeq ($(ACPI_BUILD_DIR),)
+$(error ACPI_BUILD_DIR not set)
+endif
+
 MK_DSDT = $(ACPI_BUILD_DIR)/mk_dsdt
 
 C_SRC-$(GPL) = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-10-14 17:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 17:02 [PATCH for-4.8 0/3] libacpi fixes Wei Liu
2016-10-14 17:02 ` [PATCH for-4.8 1/3] libacpi: fix arm64 build Wei Liu
2016-10-17 10:47   ` Wei Liu
2016-10-17 14:57     ` Steve Capper
2016-10-17 16:55       ` Wei Liu
2016-10-17 23:36         ` Stefano Stabellini
2016-10-18  7:52           ` Steve Capper
2016-10-18 11:21             ` Wei Liu
2016-10-18 11:43               ` Wei Liu
2016-10-18 11:17           ` Wei Liu
2016-10-14 17:02 ` Wei Liu [this message]
2016-10-24 12:48   ` [PATCH for-4.8 2/3] libacpi: require ACPI_BUILD_DIR to be set Jan Beulich
2016-10-14 17:02 ` [PATCH for-4.8 3/3] libacpi: add back the "G" in "GNU" in licence header Wei Liu
2016-10-14 17:19 ` [PATCH for-4.8 0/3] libacpi fixes Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476464552-12969-3-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).