From: Paul Lai <paul.c.lai@intel.com>
To: xen-devel@lists.xensource.com
Cc: ravi.sahita@intel.com, george.dunlap@citrix.com, jbeulich@suse.com
Subject: [PATCH Altp2m cleanup 2/3 v11 0/2] clean up altp2m code
Date: Wed, 19 Oct 2016 13:32:21 -0700 [thread overview]
Message-ID: <1476909143-28616-1-git-send-email-paul.c.lai@intel.com> (raw)
The altp2m clean work is motivated by the following URLs:
https://lists.xenproject.org/archives/html/xen-devel/2015-07/msg04454.html
Most of the work has been:
Lots of white space, indentation, and other coding style preference
corrections.
Lots of moving altp2m functions to the altp2m file.
Lots of moving ept functions to the ept file.
Paul Lai (2):
Move altp2m specific functions to altp2m files.
Moving ept code to ept specific files.
xen/arch/x86/mm/altp2m.c | 55 +++++++++++++++++++++++++++++++++++++++
xen/arch/x86/mm/hap/hap.c | 40 +++++++++-------------------
xen/arch/x86/mm/p2m-ept.c | 39 +++++++++++++++++++++++++++
xen/arch/x86/mm/p2m.c | 43 ++----------------------------
xen/include/asm-x86/altp2m.h | 4 ++-
xen/include/asm-x86/hvm/vmx/vmx.h | 3 +++
xen/include/asm-x86/p2m.h | 9 +++----
7 files changed, 117 insertions(+), 76 deletions(-)
--
since v10
Removed the check for d == 0 at the head of altp2m_domain_init() per request.
Fixing code style issues missed in v10. It was apparent that our eyes
are failing to see code style issues, so we started using some vim scripts
to assist. Here's one for spaces after parens:
pclai@pclaidev:/rhel-home/pclai/p2m_new/xen/output$ cat ~/vim_xen
:highlight ForIfLParenNoSpace ctermbg=red guibg=red
:highlight ForIfRParenNoSpace ctermbg=red guibg=red
:match ForIfLParenNoSpace /['for''if'] ([a-zA-Z0-9]/
:2match ForIfRParenNoSpace /['for''if'] .*[a-zA-Z0-9-+]+[)]$/
Here's another to catch dangling left curly braces:
pclai@pclaidev:/rhel-home/pclai/p2m_new/xen/output$ cat ~/vim_xen_curly
:highlight RParenCurly ctermbg=red guibg=red
:match RParenCurly /) *[{]$/
We specifically unraval p2m_alloc_table() and hap_set_allocation() by
hand instead of calling p2m_teardown().
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-10-19 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 20:32 Paul Lai [this message]
2016-10-19 20:32 ` [PATCH Altp2m cleanup 2/3 v11 1/2] Move altp2m specific functions to altp2m files Paul Lai
2016-10-24 13:51 ` Jan Beulich
2016-10-19 20:32 ` [PATCH Altp2m cleanup 2/3 v11 2/2] Moving ept code to ept specific files Paul Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476909143-28616-1-git-send-email-paul.c.lai@intel.com \
--to=paul.c.lai@intel.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=ravi.sahita@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).