xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Meng Xu <mengxu@cis.upenn.edu>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Dagaen Golomb <dgolomb@cis.upenn.edu>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Haoran Li <lihaoran@wustl.edu>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	Linh Thi Xuan Phan <linhphan@cis.upenn.edu>,
	Meng Xu <xumengpanda@gmail.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Tianyang Chen <tiche@cis.upenn.edu>
Subject: [PATCH] xen:rtds: Update last_start whenever cur_budget is updated
Date: Wed, 26 Oct 2016 15:06:29 -0400	[thread overview]
Message-ID: <1477508789-3827-1-git-send-email-mengxu@cis.upenn.edu> (raw)

We keep last_start updated whenever cur_budget is updated.
This avoids subtle bugs in case burn_budget() will be called
in other places in the future.

Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
---
Cc: Dario Faggioli <dario.faggioli@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Linh Thi Xuan Phan <linhphan@cis.upenn.edu>
Cc: Haoran Li <lihaoran@wustl.edu>
Cc: Meng Xu <xumengpanda@gmail.com>
Cc: Dagaen Golomb <dgolomb@cis.upenn.edu>
Cc: Tianyang Chen <tiche@cis.upenn.edu>
---
 xen/common/sched_rt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index 4b4f232..434b773 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -953,6 +953,7 @@ burn_budget(const struct scheduler *ops, struct rt_vcpu *svc, s_time_t now)
     }
 
     svc->cur_budget -= delta;
+    svc->last_start = now;
 
     if ( svc->cur_budget <= 0 )
     {
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

             reply	other threads:[~2016-10-26 19:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 19:06 Meng Xu [this message]
2016-10-27  9:14 ` [PATCH] xen:rtds: Update last_start whenever cur_budget is updated Dario Faggioli
2016-10-27 10:03   ` Wei Liu
2016-10-27 13:40     ` Meng Xu
2016-10-27 13:42     ` Meng Xu
2016-10-27 13:43       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477508789-3827-1-git-send-email-mengxu@cis.upenn.edu \
    --to=mengxu@cis.upenn.edu \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=dgolomb@cis.upenn.edu \
    --cc=lihaoran@wustl.edu \
    --cc=linhphan@cis.upenn.edu \
    --cc=tiche@cis.upenn.edu \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xumengpanda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).