From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3] xen:rtds: Fix bug in budget accounting Date: Thu, 27 Oct 2016 10:54:23 +0200 Message-ID: <1477558463.16647.6.camel@citrix.com> References: <1477508766-3781-1-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5065539759277905504==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzgSX-0003Rx-A6 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2016 08:54:49 +0000 In-Reply-To: <1477508766-3781-1-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , xen-devel@lists.xenproject.org Cc: Wei Liu , Dagaen Golomb , George Dunlap , Haoran Li , Linh Thi Xuan Phan , Meng Xu , Tianyang Chen List-Id: xen-devel@lists.xenproject.org --===============5065539759277905504== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-1Et4RHbrAKNoWsCfo2do" --=-1Et4RHbrAKNoWsCfo2do Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: > Fix: > We keeps last_start always within the current period for a VCPU, so > that > we only deduct the time spent in the current period from the VCPU > budget. > We always update last_start whenever we update cur_deadline for a > VCPU. >=20 > Signed-off-by: Meng Xu > Reported-by: Dagaen Golomb >=20 Acked-by: Dario Faggioli Thanks. Ehi, Wei. As said yesterday on IRC about the other patch: =C2=A0- this is a bugfix =C2=A0- this is a super-self contained change (all within RTDS) =C2=A0- RTDS is Experimental =C2=A0- it brings value, as it removes a subtle but annoying =C2=A0 =C2=A0behavioral bug in the scheduler So, I know it's late, but if still possible, I think we should have it in 4.8. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-1Et4RHbrAKNoWsCfo2do Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYEcDHAAoJEBZCeImluHPuVUAQAK44X7lrd5TfTTBiUg1MiYVo w3rJevqu8xpAhQ858bB6Xq4pObS7aec4XGuoRebsI5DW0fMiA3Ui/tdpFjQwBz7M jMROUyl1fKovP4qexbavfp3J5YM/a37E6uQfssvuz118UFHOSBchS1G1k8NYEtr5 kV9kW48//pI8ZDyi2FD9txH6MHauNSN+x02DTZdph0RDn38TmFFXh4Gtl8LPf2AO dAx9NnXV3SuWX2De5AB1/3Ca5ZwHJ6i2cuM+p0l0miSo0iXEL1beukCpJZ7rMJj4 f8jOgyPWoWtpB+whw5xkwLH6sQYWGIetqNIF1+1dlYSPP+XQop3zoLCzWZlsd600 9SJ2PyA2lxj42IE3xjAUXuNlKBgszwgGMyBv6nKpH/IxGLGjnkDWAY2XY5xRD/uC N1DZHbvDxT08cewRaQXo0d9d1JIiNjr83nh74qzykKRl1BwGpaNvjPyTMkH+xp4T v+RtjnRfFa260cqZ0S5kt4OtbBnr8TW1VOX3aeWMrl0SPhRao3lr+YgzwHCnLt/l t0nCjPJ75ewRqyYLj67Tm1ZQvtY01b1jxfLf3dpKzKfKAEO4ejHJcDLE+xZ9Bm7G QOrt/EPOP0hTtf8pgGCa++aEBjAAAn7G8YCbML+srftAXZUL7CmhRgGlPAFtyucF oIaBmQeFbl2GQcFhQ6eG =HxGE -----END PGP SIGNATURE----- --=-1Et4RHbrAKNoWsCfo2do-- --===============5065539759277905504== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5065539759277905504==--