From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen:rtds: Update last_start whenever cur_budget is updated Date: Thu, 27 Oct 2016 11:14:36 +0200 Message-ID: <1477559676.16647.19.camel@citrix.com> References: <1477508789-3827-1-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2588057280226286291==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzgm0-0004gl-Ea for xen-devel@lists.xenproject.org; Thu, 27 Oct 2016 09:14:56 +0000 In-Reply-To: <1477508789-3827-1-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , xen-devel@lists.xenproject.org Cc: Wei Liu , Dagaen Golomb , George Dunlap , Haoran Li , Linh Thi Xuan Phan , Meng Xu , Tianyang Chen List-Id: xen-devel@lists.xenproject.org --===============2588057280226286291== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-NHuzFu9nkbsJn0LtnVvy" --=-NHuzFu9nkbsJn0LtnVvy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: > We keep last_start updated whenever cur_budget is updated. > This avoids subtle bugs in case burn_budget() will be called > in other places in the future. >=20 I'd change this into something like: "Make budget accounting code more consistent by making sure the values used to compute how much budget has been consumed are updated together. This makes code resilient to calling burn_budget() from more than just one place --in case we will need to do that-- without risking subtle bugs." Also, when that is the case, like here, you need to explicitly state that no functional changes are intended. With all this done to the changelog: > Signed-off-by: Meng Xu > Acked-by: Dario Faggioli This can go in 4.8, but can also well wait for 4.9. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-NHuzFu9nkbsJn0LtnVvy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYEcV8AAoJEBZCeImluHPuwh8P/2aHsuGl3AaPQBMWc+zTkG/s 1MUr1yMlyMht/JJShQbO7Jn3akwp5LlncrCHbS0gdy1r3vY36Sa4xw8gimk8pFMb EQaLzOx4ef4SX1jj/8PrdfguTxKYlyD9EsqhqGnSgMOIMbQnTO5nKx+Hws6ziI0G k+tZ4FXDHrj9mS4n1WSUO/7bMZNYcifMEHJl0bo6MPIne9t40GxdPeqhhftpeGul UWSAbDId9ega9jI9v9xMma673Is1wllKkz9GmhD4LYFQqLXEWgbNVgUZESo2OIum K4lSg6/QAUYlw1abFFlGYORNJzmnif4HJgzebalm8dy+GOW7inJMuPxElEGzNpN9 dVrkToPp6F5szf/PaN7Ok1KwT/BDNkfWRP2l/LEmncmdNokLi0pdbApiWOYHqMqP /A+KI9kjOCAysWc3EJs64MwOyPyUFJtDroJ/YwVmh5e2X4T8rqZ34S/jVlzD6v3J s2wDcrm4411VCjaQ+obXQLJGnCubCFfr7QCrZbhqWHlnupAUkvL0081tW3UI6ymw jDq7fsKoKTZw3EKyokQBpbwObqBp96RnofaQ2NO4Nss5ivyINNQYR8SzaNofSH3t qFIBvWGTTeC+9E5M1AtEJ/Y9hW7S+3A7N/41H/XAZ9oPIKSFhScifCOtpin7wh4f mDG3lXR/BZIg2pxuYYQm =L+HF -----END PGP SIGNATURE----- --=-NHuzFu9nkbsJn0LtnVvy-- --===============2588057280226286291== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2588057280226286291==--