[PATCH] stubdom: fix stubdom-vtpm build

[PATCH] stubdom: fix stubdom-vtpm build

[Juergen Gross]

stubdom-vtpm needs gmp and expects it under
stubdom/cross-root-x86_64/x86_64-xen-elf/lib while gmp seems to install
it under stubdom/cross-root-x86_64/x86_64-xen-elf/lib64

Modify the Makefile to account for this by moving the gmp.a file from
lib64 to lib if necessary.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 stubdom/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 0252bcc..4851d03 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -176,11 +176,13 @@ gmp-$(XEN_TARGET_ARCH): gmp-$(GMP_VERSION).tar.bz2 $(NEWLIB_STAMPFILE)
 	touch $@
 
 GMP_STAMPFILE=$(CROSS_ROOT)/$(GNU_TARGET_ARCH)-xen-elf/lib/libgmp.a
+GMP_STAMPFILE64=$(CROSS_ROOT)/$(GNU_TARGET_ARCH)-xen-elf/lib64/libgmp.a
 cross-gmp: $(GMP_STAMPFILE)
 $(GMP_STAMPFILE): gmp-$(XEN_TARGET_ARCH)
 	( cd $< && \
 	  $(MAKE) && \
 	  $(MAKE) DESTDIR= install )
+	if [ ! -f "$(GMP_STAMPFILE)" -a -f "$(GMP_STAMPFILE64)" ]; then mv $(GMP_STAMPFILE64) $(GMP_STAMPFILE); fi
 
 #############
 # cross-polarssl
-- 
2.6.6


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] stubdom: fix stubdom-vtpm build

[Jan Beulich]

>>> On 28.10.16 at 17:10, <JGross@suse.com> wrote:
> stubdom-vtpm needs gmp and expects it under
> stubdom/cross-root-x86_64/x86_64-xen-elf/lib while gmp seems to install
> it under stubdom/cross-root-x86_64/x86_64-xen-elf/lib64

Are you sure this is universal, rather dependent upon some
(possibly even host) configuration item? I think that some distros
have switched to (or have always used) /lib as the main library
directory for x86-64, while others (like SUSE's) stick to the
originally mandated /lib64. Over the years I have found quite a
few projects where, in order to become consistent with SUSE's
model, I had to override the global default of /lib with /lib64 just
for x86-64 (but not for e.g. ia64).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] stubdom: fix stubdom-vtpm build

[Juergen Gross]

On 31/10/16 08:55, Jan Beulich wrote:
>>>> On 28.10.16 at 17:10, <JGross@suse.com> wrote:
>> stubdom-vtpm needs gmp and expects it under
>> stubdom/cross-root-x86_64/x86_64-xen-elf/lib while gmp seems to install
>> it under stubdom/cross-root-x86_64/x86_64-xen-elf/lib64
> 
> Are you sure this is universal, rather dependent upon some
> (possibly even host) configuration item? I think that some distros
> have switched to (or have always used) /lib as the main library
> directory for x86-64, while others (like SUSE's) stick to the
> originally mandated /lib64. Over the years I have found quite a
> few projects where, in order to become consistent with SUSE's
> model, I had to override the global default of /lib with /lib64 just
> for x86-64 (but not for e.g. ia64).

No, I don't think it is universal. This is the reason I did the move
of the file only in case it is to be found under lib64 but not under
lib.

I've tested the build to break with plain

./configure

and with

./configure --prefix=/usr --libdir=/usr/lib64

which I use normally to match my SUSE environment.

OTOH looking at Wei's recent patch to modify gmp's configure to
specify cross compilation I now believe the correct answer to my
problem is to add

--libdir=$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/lib

to the configure statement of gmp. I'll send V2 of the patch.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel