From: Julien Grall <julien.grall@arm.com>
To: xen-devel@lists.xen.org
Cc: Julien Grall <julien.grall@arm.com>,
sstabellini@kernel.org, wei.liu2@citrix.com
Subject: [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug
Date: Thu, 3 Nov 2016 14:36:35 +0000 [thread overview]
Message-ID: <1478183795-740-1-git-send-email-julien.grall@arm.com> (raw)
The variable debug is used to enable debug for the tools. As
early-printk is for the hypervisor we should use CONFIG_DEBUG.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
This patch is candidate for Xen 4.8. This is a follow-up of [1].
[1] https://lists.xenproject.org/archives/html/xen-devel/2016-11/msg00082.html
---
xen/arch/arm/Rules.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index 93304be..569a0ba 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -24,7 +24,7 @@ endif
EARLY_PRINTK := n
-ifeq ($(debug),y)
+ifeq ($(CONFIG_DEBUG),y)
# See docs/misc/arm/early-printk.txt for syntax
@@ -77,7 +77,7 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD)
CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS)
CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT)
-else # !debug
+else # !CONFIG_DEBUG
ifneq ($(CONFIG_EARLY_PRINTK),)
# Early printk is dependant on a debug build.
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-11-03 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 14:36 Julien Grall [this message]
2016-11-03 14:44 ` [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478183795-740-1-git-send-email-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).