xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, jbeulich@suse.com,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	roger.pau@citrix.com
Subject: [PATCH v2 03/11] pvh: Set online VCPU map to avail_vcpus
Date: Wed,  9 Nov 2016 09:39:51 -0500	[thread overview]
Message-ID: <1478702399-14538-4-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1478702399-14538-1-git-send-email-boris.ostrovsky@oracle.com>

ACPI builder marks VCPUS set in vcpu_online map as enabled in MADT.
With ACPI-based CPU hotplug we only want VCPUs that are started by
the guest to be marked as such. Remaining VCPUs will be set to
"enable" by AML code during hotplug.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
Changes in v2:
* Clarified in the commit message that it's AML that updates MADT

 tools/libxl/libxl_x86_acpi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/libxl_x86_acpi.c b/tools/libxl/libxl_x86_acpi.c
index ff0e2df..949f555 100644
--- a/tools/libxl/libxl_x86_acpi.c
+++ b/tools/libxl/libxl_x86_acpi.c
@@ -98,7 +98,7 @@ static int init_acpi_config(libxl__gc *gc,
     uint32_t domid = dom->guest_domid;
     xc_dominfo_t info;
     struct hvm_info_table *hvminfo;
-    int i, rc = 0;
+    int rc = 0;
 
     config->dsdt_anycpu = config->dsdt_15cpu = dsdt_pvh;
     config->dsdt_anycpu_len = config->dsdt_15cpu_len = dsdt_pvh_len;
@@ -144,8 +144,8 @@ static int init_acpi_config(libxl__gc *gc,
         hvminfo->nr_vcpus = info.max_vcpu_id + 1;
     }
 
-    for (i = 0; i < hvminfo->nr_vcpus; i++)
-        hvminfo->vcpu_online[i / 8] |= 1 << (i & 7);
+    memcpy(hvminfo->vcpu_online, b_info->avail_vcpus.map,
+           b_info->avail_vcpus.size);
 
     config->hvminfo = hvminfo;
 
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-09 14:39 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 14:39 [PATCH v2 00/11] PVH VCPU hotplug support Boris Ostrovsky
2016-11-09 14:39 ` [PATCH v2 01/11] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus Boris Ostrovsky
2016-11-09 15:04   ` Andrew Cooper
2016-11-09 15:29     ` Boris Ostrovsky
2016-11-09 19:23       ` Andrew Cooper
2016-11-09 19:47         ` Boris Ostrovsky
2016-11-14 14:59           ` Boris Ostrovsky
2016-11-14 17:17             ` Andrew Cooper
2016-11-14 17:48               ` Boris Ostrovsky
2016-11-14 18:19                 ` Andrew Cooper
2016-11-14 18:44                   ` Boris Ostrovsky
2016-11-15 16:41                     ` Andrew Cooper
2016-11-15 17:04                       ` Boris Ostrovsky
2016-11-15 17:30                         ` Andrew Cooper
2016-11-15  8:34   ` Jan Beulich
2016-11-15 14:28     ` Boris Ostrovsky
2016-11-15 14:33       ` Jan Beulich
2016-11-15 15:00         ` Boris Ostrovsky
2016-11-09 14:39 ` [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-11-09 14:48   ` Julien Grall
2016-11-09 14:54     ` Boris Ostrovsky
2016-11-09 14:48   ` Paul Durrant
2016-11-09 14:59   ` Andrew Cooper
2016-11-09 15:14     ` Boris Ostrovsky
2016-11-09 19:58       ` Andrew Cooper
2016-11-09 21:01         ` Boris Ostrovsky
2016-11-14 15:01           ` Boris Ostrovsky
2016-11-14 17:19             ` Andrew Cooper
2016-11-15  8:47   ` Jan Beulich
2016-11-15 14:47     ` Boris Ostrovsky
2016-11-15 15:13       ` Jan Beulich
2016-11-15 15:41         ` Boris Ostrovsky
2016-11-15 15:53           ` Jan Beulich
2016-11-15 16:23             ` Boris Ostrovsky
2016-11-15 16:33               ` Jan Beulich
2016-11-15 16:58                 ` Boris Ostrovsky
2016-11-15 16:59                   ` Jan Beulich
2016-11-15 18:31                   ` Andrew Cooper
2016-11-09 14:39 ` Boris Ostrovsky [this message]
2016-11-11 19:57   ` [PATCH v2 03/11] pvh: Set online VCPU map to avail_vcpus Konrad Rzeszutek Wilk
2016-11-12 15:40     ` Wei Liu
2016-11-09 14:39 ` [PATCH v2 04/11] acpi: Make pmtimer optional in FADT Boris Ostrovsky
2016-11-15  8:49   ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 05/11] acpi: Power and Sleep ACPI buttons are not emulated for PVH guests Boris Ostrovsky
2016-11-11 19:56   ` Konrad Rzeszutek Wilk
2016-11-15  8:54   ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 06/11] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-11 19:58   ` Konrad Rzeszutek Wilk
2016-11-15  8:57   ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 07/11] pvh/ioreq: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-11-09 14:56   ` Paul Durrant
2016-11-11 20:01   ` Konrad Rzeszutek Wilk
2016-11-15  9:04   ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 08/11] pvh/acpi: Handle ACPI accesses for PVH guests Boris Ostrovsky
2016-11-09 14:58   ` Paul Durrant
2016-11-11 20:07   ` Konrad Rzeszutek Wilk
2016-11-15  9:24   ` Jan Beulich
2016-11-15 14:55     ` Boris Ostrovsky
2016-11-15 15:17       ` Jan Beulich
2016-11-15 15:44         ` Boris Ostrovsky
2016-11-15 15:56           ` Jan Beulich
2016-11-15 19:19             ` Andrew Cooper
2016-11-15 19:38               ` Boris Ostrovsky
2016-11-15 20:07                 ` Andrew Cooper
2016-11-15 20:20                   ` Boris Ostrovsky
2016-11-17  0:00                     ` Boris Ostrovsky
2016-11-17  0:08                       ` Andrew Cooper
2016-11-16  9:23               ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 09/11] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-11-15  9:29   ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 10/11] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-11-15  9:36   ` Jan Beulich
2016-11-15 14:57     ` Boris Ostrovsky
2016-11-15 15:18       ` Jan Beulich
2016-11-15  9:38   ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 11/11] docs: Describe PVHv2's VCPU hotplug procedure Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478702399-14538-4-git-send-email-boris.ostrovsky@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).