From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, Paul Durrant <paul.durrant@citrix.com>,
jbeulich@suse.com, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
roger.pau@citrix.com
Subject: [PATCH v2 08/11] pvh/acpi: Handle ACPI accesses for PVH guests
Date: Wed, 9 Nov 2016 09:39:56 -0500 [thread overview]
Message-ID: <1478702399-14538-9-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1478702399-14538-1-git-send-email-boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
CC: Paul Durrant <paul.durrant@citrix.com>
---
Changes in v2:
* Use 'true/false' values for bools
xen/arch/x86/hvm/ioreq.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
index e6ff48f..3ef01cf 100644
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -1383,6 +1383,78 @@ static int hvm_access_cf8(
static int acpi_ioaccess(
int dir, unsigned int port, unsigned int bytes, uint32_t *val)
{
+ unsigned int i;
+ unsigned int bits = bytes * 8;
+ unsigned int idx = port & 3;
+ uint8_t *reg = NULL;
+ bool is_cpu_map = false;
+ struct domain *currd = current->domain;
+
+ BUILD_BUG_ON((ACPI_PM1A_EVT_BLK_LEN != 4) ||
+ (ACPI_GPE0_BLK_LEN_V1 != 4));
+
+ if ( has_ioreq_cpuhp(currd) )
+ return X86EMUL_UNHANDLEABLE;
+
+ switch (port)
+ {
+ case ACPI_PM1A_EVT_BLK_ADDRESS_V1 ...
+ (ACPI_PM1A_EVT_BLK_ADDRESS_V1 + ACPI_PM1A_EVT_BLK_LEN - 1):
+ reg = currd->arch.hvm_domain.acpi_io.pm1a;
+ break;
+ case ACPI_GPE0_BLK_ADDRESS_V1 ...
+ (ACPI_GPE0_BLK_ADDRESS_V1 + ACPI_GPE0_BLK_LEN_V1 - 1):
+ reg = currd->arch.hvm_domain.acpi_io.gpe;
+ break;
+ case ACPI_CPU_MAP ... (ACPI_CPU_MAP + ACPI_CPU_MAP_LEN - 1):
+ is_cpu_map = true;
+ break;
+ default:
+ return X86EMUL_UNHANDLEABLE;
+ }
+
+ if ( bytes == 0 )
+ return X86EMUL_OKAY;
+
+ if ( dir == IOREQ_READ )
+ {
+ *val &= ~((1U << bits) - 1);
+
+ if ( is_cpu_map )
+ {
+ unsigned int first_bit, last_bit;
+
+ first_bit = (port - ACPI_CPU_MAP) * 8;
+ last_bit = min(currd->arch.avail_vcpus, first_bit + bits);
+ for ( i = first_bit; i < last_bit; i++ )
+ *val |= (1U << (i - first_bit));
+ }
+ else
+ memcpy(val, ®[idx], bytes);
+ }
+ else
+ {
+ if ( is_cpu_map )
+ /*
+ * CPU map is only read by DSDT's PRSC method and should never
+ * be written by a guest.
+ */
+ return X86EMUL_UNHANDLEABLE;
+
+ /* Write either status or enable reegister. */
+ if ( (bytes > 2) || ((bytes == 2) && (port & 1)) )
+ return X86EMUL_UNHANDLEABLE;
+
+ if ( idx < 2 ) /* status, write 1 to clear. */
+ {
+ reg[idx] &= ~(*val & 0xff);
+ if ( bytes == 2 )
+ reg[idx + 1] &= ~((*val >> 8) & 0xff);
+ }
+ else /* enable */
+ memcpy(®[idx], val, bytes);
+ }
+
return X86EMUL_OKAY;
}
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-09 14:39 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 14:39 [PATCH v2 00/11] PVH VCPU hotplug support Boris Ostrovsky
2016-11-09 14:39 ` [PATCH v2 01/11] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus Boris Ostrovsky
2016-11-09 15:04 ` Andrew Cooper
2016-11-09 15:29 ` Boris Ostrovsky
2016-11-09 19:23 ` Andrew Cooper
2016-11-09 19:47 ` Boris Ostrovsky
2016-11-14 14:59 ` Boris Ostrovsky
2016-11-14 17:17 ` Andrew Cooper
2016-11-14 17:48 ` Boris Ostrovsky
2016-11-14 18:19 ` Andrew Cooper
2016-11-14 18:44 ` Boris Ostrovsky
2016-11-15 16:41 ` Andrew Cooper
2016-11-15 17:04 ` Boris Ostrovsky
2016-11-15 17:30 ` Andrew Cooper
2016-11-15 8:34 ` Jan Beulich
2016-11-15 14:28 ` Boris Ostrovsky
2016-11-15 14:33 ` Jan Beulich
2016-11-15 15:00 ` Boris Ostrovsky
2016-11-09 14:39 ` [PATCH v2 02/11] acpi: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-11-09 14:48 ` Julien Grall
2016-11-09 14:54 ` Boris Ostrovsky
2016-11-09 14:48 ` Paul Durrant
2016-11-09 14:59 ` Andrew Cooper
2016-11-09 15:14 ` Boris Ostrovsky
2016-11-09 19:58 ` Andrew Cooper
2016-11-09 21:01 ` Boris Ostrovsky
2016-11-14 15:01 ` Boris Ostrovsky
2016-11-14 17:19 ` Andrew Cooper
2016-11-15 8:47 ` Jan Beulich
2016-11-15 14:47 ` Boris Ostrovsky
2016-11-15 15:13 ` Jan Beulich
2016-11-15 15:41 ` Boris Ostrovsky
2016-11-15 15:53 ` Jan Beulich
2016-11-15 16:23 ` Boris Ostrovsky
2016-11-15 16:33 ` Jan Beulich
2016-11-15 16:58 ` Boris Ostrovsky
2016-11-15 16:59 ` Jan Beulich
2016-11-15 18:31 ` Andrew Cooper
2016-11-09 14:39 ` [PATCH v2 03/11] pvh: Set online VCPU map to avail_vcpus Boris Ostrovsky
2016-11-11 19:57 ` Konrad Rzeszutek Wilk
2016-11-12 15:40 ` Wei Liu
2016-11-09 14:39 ` [PATCH v2 04/11] acpi: Make pmtimer optional in FADT Boris Ostrovsky
2016-11-15 8:49 ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 05/11] acpi: Power and Sleep ACPI buttons are not emulated for PVH guests Boris Ostrovsky
2016-11-11 19:56 ` Konrad Rzeszutek Wilk
2016-11-15 8:54 ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 06/11] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-11 19:58 ` Konrad Rzeszutek Wilk
2016-11-15 8:57 ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 07/11] pvh/ioreq: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-11-09 14:56 ` Paul Durrant
2016-11-11 20:01 ` Konrad Rzeszutek Wilk
2016-11-15 9:04 ` Jan Beulich
2016-11-09 14:39 ` Boris Ostrovsky [this message]
2016-11-09 14:58 ` [PATCH v2 08/11] pvh/acpi: Handle ACPI accesses for PVH guests Paul Durrant
2016-11-11 20:07 ` Konrad Rzeszutek Wilk
2016-11-15 9:24 ` Jan Beulich
2016-11-15 14:55 ` Boris Ostrovsky
2016-11-15 15:17 ` Jan Beulich
2016-11-15 15:44 ` Boris Ostrovsky
2016-11-15 15:56 ` Jan Beulich
2016-11-15 19:19 ` Andrew Cooper
2016-11-15 19:38 ` Boris Ostrovsky
2016-11-15 20:07 ` Andrew Cooper
2016-11-15 20:20 ` Boris Ostrovsky
2016-11-17 0:00 ` Boris Ostrovsky
2016-11-17 0:08 ` Andrew Cooper
2016-11-16 9:23 ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 09/11] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-11-15 9:29 ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 10/11] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-11-15 9:36 ` Jan Beulich
2016-11-15 14:57 ` Boris Ostrovsky
2016-11-15 15:18 ` Jan Beulich
2016-11-15 9:38 ` Jan Beulich
2016-11-09 14:39 ` [PATCH v2 11/11] docs: Describe PVHv2's VCPU hotplug procedure Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478702399-14538-9-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).