* [PATCH] x86/hvm: Fix non-debug build folling c/s 0745f665a5
@ 2016-11-21 15:32 Andrew Cooper
2016-11-21 16:06 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2016-11-21 15:32 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Boris Ostrovsky, Wei Liu, Suravee Suthikulpanit,
Jan Beulich
The variable is named inst_len, not insn_len.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
I definitely fixed this once duing development, but it clearly slipped back
in. My appologies.
---
xen/arch/x86/hvm/svm/emulate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c
index ca670bf..2b47db9 100644
--- a/xen/arch/x86/hvm/svm/emulate.c
+++ b/xen/arch/x86/hvm/svm/emulate.c
@@ -98,8 +98,8 @@ int __get_instruction_length_from_list(struct vcpu *v,
*/
#ifdef NDEBUG
if ( (inst_len = svm_nextrip_insn_length(v)) > MAX_INST_LEN )
- gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", insn_len);
- else if ( insn_len != 0 )
+ gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", inst_len);
+ else if ( inst_len != 0 )
return inst_len;
if ( vmcb->exitcode == VMEXIT_IOIO )
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86/hvm: Fix non-debug build folling c/s 0745f665a5
2016-11-21 15:32 [PATCH] x86/hvm: Fix non-debug build folling c/s 0745f665a5 Andrew Cooper
@ 2016-11-21 16:06 ` Boris Ostrovsky
2016-11-21 16:41 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Boris Ostrovsky @ 2016-11-21 16:06 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Wei Liu, Suravee Suthikulpanit, Jan Beulich
On 11/21/2016 10:32 AM, Andrew Cooper wrote:
> The variable is named inst_len, not insn_len.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>
> I definitely fixed this once duing development, but it clearly slipped back
> in. My appologies.
> ---
> xen/arch/x86/hvm/svm/emulate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c
> index ca670bf..2b47db9 100644
> --- a/xen/arch/x86/hvm/svm/emulate.c
> +++ b/xen/arch/x86/hvm/svm/emulate.c
> @@ -98,8 +98,8 @@ int __get_instruction_length_from_list(struct vcpu *v,
> */
> #ifdef NDEBUG
> if ( (inst_len = svm_nextrip_insn_length(v)) > MAX_INST_LEN )
> - gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", insn_len);
> - else if ( insn_len != 0 )
> + gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", inst_len);
Since you are fixing this up anyway, insn_let in format string should
also be updated.
With that,
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> + else if ( inst_len != 0 )
> return inst_len;
>
> if ( vmcb->exitcode == VMEXIT_IOIO )
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/hvm: Fix non-debug build folling c/s 0745f665a5
2016-11-21 16:06 ` Boris Ostrovsky
@ 2016-11-21 16:41 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-11-21 16:41 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: Andrew Cooper, Wei Liu, Suravee Suthikulpanit, Jan Beulich,
Xen-devel
On Mon, Nov 21, 2016 at 11:06:23AM -0500, Boris Ostrovsky wrote:
> On 11/21/2016 10:32 AM, Andrew Cooper wrote:
> > The variable is named inst_len, not insn_len.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> > CC: Jan Beulich <JBeulich@suse.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >
> > I definitely fixed this once duing development, but it clearly slipped back
> > in. My appologies.
> > ---
> > xen/arch/x86/hvm/svm/emulate.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c
> > index ca670bf..2b47db9 100644
> > --- a/xen/arch/x86/hvm/svm/emulate.c
> > +++ b/xen/arch/x86/hvm/svm/emulate.c
> > @@ -98,8 +98,8 @@ int __get_instruction_length_from_list(struct vcpu *v,
> > */
> > #ifdef NDEBUG
> > if ( (inst_len = svm_nextrip_insn_length(v)) > MAX_INST_LEN )
> > - gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", insn_len);
> > - else if ( insn_len != 0 )
> > + gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", inst_len);
>
> Since you are fixing this up anyway, insn_let in format string should
> also be updated.
>
> With that,
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-21 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-21 15:32 [PATCH] x86/hvm: Fix non-debug build folling c/s 0745f665a5 Andrew Cooper
2016-11-21 16:06 ` Boris Ostrovsky
2016-11-21 16:41 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).