From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 01/15] docs: L2 Cache Allocation Technology (CAT) feature document. Date: Fri, 25 Nov 2016 18:19:17 +0100 Message-ID: <1480094357.2712.177.camel@citrix.com> References: <1477366863-5246-1-git-send-email-yi.y.sun@linux.intel.com> <1477366863-5246-2-git-send-email-yi.y.sun@linux.intel.com> <20161111213309.GA23768@char.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1364581017232047444==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAK9s-0002do-PH for xen-devel@lists.xenproject.org; Fri, 25 Nov 2016 17:19:32 +0000 In-Reply-To: <20161111213309.GA23768@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk , Yi Sun Cc: wei.liu2@citrix.com, he.chen@linux.intel.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org, chao.p.peng@linux.intel.com List-Id: xen-devel@lists.xenproject.org --===============1364581017232047444== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-IWA8G5pKTL0U/95dcT2J" --=-IWA8G5pKTL0U/95dcT2J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-11-11 at 16:33 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Oct 25, 2016 at 11:40:49AM +0800, Yi Sun wrote: > > --- /dev/null > > +++ b/docs/features/l2_cat.pandoc > > @@ -0,0 +1,314 @@ > > +% Intel L2 Cache Allocation Technology (L2 CAT) Feature > > +% Revision 2.0 > > + > > +\clearpage > > + > > +# Basics > > + > > +---------------- ----------------------------------------------- > > ----- > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Status: **Tech P= review** > > + > > +Architecture(s): Intel x86 > > + > > +=C2=A0=C2=A0=C2=A0Component(s): Hypervisor, toolstack > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Hardware: Atom codename Gold= mont and beyond > Atom codename Goldmont and beyond CPUs It may sound obvious, but I'd explicitly add that bit. > > +---------------- ----------------------------------------------- > > ----- > > + > > +# Overview > > + > > +L2 CAT allows an OS or Hypervisor/VMM to control allocation of a >=20 > Could you define CAT? >=20 > >=20 > > +CPU's shared L2 cache based on application priority or Class of > > Service > > +(COS). Each CLOS is configured using capacity bitmasks (CBM) which > > +represent cache capacity and indicate the degree of overlap and > > +isolation between classes. Once L2 CAT is configured, the > > processor > > +allows access to portions of L2 cache according to the established > > +class of service (COS). > > + > > +# Technical information > > + > > +L2 CAT is a member of Intel PSR features and part of CAT, it > > shares >=20 > Could you define 'PSR' here? Usually when you introduce an acronym > you do something like: >=20 > Intel Problem Solver Resolver (PSR) >=20 Wasn't it the 'Intel Probabilistic Silicon Reorganizer' ? :-D :-D > and that makes it easy for folks to map the acronym to the full > feature. >=20 Actually, given the density of acronyms, I'd say it would be good to add a "## Terminology" section at the top, and define all of them there upfront. Also, I see that you're meaning this to be committed in tree and act as the L2 CAT feature document. I know that you've been asked to put it in tree (although, the request was for docs/misc/) and I think it's good to have a feature document for L2 CAT. It contains a lot more technical details than the other (few) feature documents we have in tree right now. Personally, I'm fine with that, but I'd say that at least try to filling these sections would be important: (from docs/features/template.pandoc) =C2=A0 # Limitations =C2=A0 Information concerning incompatibilities with other features or =C2=A0 hardware combinations. =C2=A0 # Testing =C2=A0 Information concerning how to properly test changes affecting this= =C2=A0 =C2=A0 feature. =C2=A0 # Areas for improvement =C2=A0 List of enhancements which could be undertaken, e.g. to improve the =C2=A0 feature itself, or improve interaction with other features. =C2=A0 # Known issues =C2=A0 List of known issues or bugs.=C2=A0=C2=A0For tech preview or experim= ental =C2=A0 features, this section must contain the list of items needing fixing =C2=A0 for its status to be upgraded. Also, it would be really good to have similar documents for the other PSR features we have upstream already (perhaps finding a way for not duplicating all the common information). Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-IWA8G5pKTL0U/95dcT2J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYOHKVAAoJEBZCeImluHPuauEP/2z94VJH/KH/BMLYHDTtX//q VJEIih+xl9AXgr247fHepk2mB+JsyQAGIpPzdTwtrdCUhTv5ft/ajf4VoLsCsTr+ 3Jcd15LjQopLo26DKRKgnFm6XxVQqMOD4gVcEIqoKoCIvxf03b8wYiw1MSbVFSg/ GJ57SfjFMtqxHO0xtgtNsDOb6wBh2+IzEbiICZizaDePsbb+40ip67R/C4p4QtZ2 Zbvrt1pi2axjTtD8QBJtWYTWiwFS/5+ssAMwMhstaB+JgxbNoQgNO6WHwtLyyVJp YVOGKA69R+oxcjbcXQC0awKURA9lCVRtc2qKECX3luDnKlMIzY+j6qO0APIEcMC+ iaBeIGa2CjTlEWDEEq1Q9tZpceN57r7t6po5rUs5TbcrfxCei4+IK5CyNZ0hZ0Rt 6w2qZkYH9PvImDH0XSqxG/CrlXI0Me2zoYgctMV4wdZ0X4SovJxoVr+NbBChoRJ5 wCiImwRX625xV81YgBCrKJixjeEXYEyXYEYONVJGDn7Jm4aFc80frNWCn+6v0dV7 H4Tyq14ChRFg4+HuQdRsN/L4x/tdzcKgo5KeQOiQduDUAJ8CdwwvwkUTJ+MJKJHm t2Ns6w/J1oEZzBzggPre4oTJBw+6Y1P2RNgLoryWdGYl8r/XKSsttrLK65yNQ6Jd Uq4Z9Z1H8DvTs1I4JpQR =ZtOF -----END PGP SIGNATURE----- --=-IWA8G5pKTL0U/95dcT2J-- --===============1364581017232047444== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1364581017232047444==--