Re: [PATCH v3 01/15] docs: L2 Cache Allocation Technology (CAT) feature document.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2120 bytes --]

On Tue, 2016-11-29 at 12:52 +0800, Yi Sun wrote:
> On 16-11-25 18:39:41, Dario Faggioli wrote:
> > On Tue, 2016-10-25 at 11:40 +0800, Yi Sun wrote:
> > > +* xl interfaces:
> > > +
> > > +  1. `psr-cat-show [OPTIONS] domain-id`:
> > > +
> > > +     Show domain L2 or L3 CAT CBM.
> > > +
> > > +     New option `-l` is added.
> > > +     `-l2`: Specify cbm for L2 cache.
> > > +     `-l3`: Specify cbm for L3 cache.
> > > +
> > > +     If neither `-l2` nor `-l3` is given, level 3 is the default
> > > option.
> > > +
> > Sorry for saying this only now, but wouldn't it be more natural, if
> > neither -l2 not -l3 is specified, to show both (or, in general, all
> > that is supported)?
> > 
> This is for backward compatibility. The original command only
> supports
> L3 CAT and it does not have '-l' option.
> 
> But for show command, your suggestion is good. We can show both or
> prompt user if any one is not supported.
> 
I don't understand. I was actually talking about 'show' already, basing
on this that I see in the patch:

+  1. `psr-cat-show [OPTIONS] domain-id`:> > > 
+
+     Show domain L2 or L3 CAT CBM.

However, now that I look better, I notice that, when explaining the
options, you write "Specify cbm for L2 cache.", which is not what I
expect show to do. Shouldn't that say "Show" or "Display"?

Cut-&-paste error (from below), or there is really something I'm
missing?

> > > +  2. `psr-cat-cbm-set [OPTIONS] domain-id cbm`:
> > > +
> > > +     Set domain L2 or L3 CBM.
> > > +
> > > +     New option `-l` is added.
> > > +     `-l2`: Specify cbm for L2 cache.
> > > +     `-l3`: Specify cbm for L3 cache.
> > > +
> > > +     If neither `-l2` nor `-l3` is given, level 3 is the default
> > > option.
> > > +

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel