[PATCH 0/2] Fix randconfig build in travis-ci

[PATCH 0/2] Fix randconfig build in travis-ci

[Wei Liu]

Wei Liu (2):
  Kconfig: introduce allrandom.config
  Travis-ci: specify KCONFIG_ALLCONFIG for randconfig

 scripts/travis-build               | 2 +-
 xen/tools/kconfig/allrandom.config | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 xen/tools/kconfig/allrandom.config

-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 1/2] Kconfig: introduce allrandom.config

[Wei Liu]

This would be used to force selection of certain items in randconfig.

We need this to force gcov format to be autodetected in randconfig
target, which would avoid generating known-incompatible combinations.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Doug Goldstein <cardoe@cardoe.com>
---
 xen/tools/kconfig/allrandom.config | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 xen/tools/kconfig/allrandom.config

diff --git a/xen/tools/kconfig/allrandom.config b/xen/tools/kconfig/allrandom.config
new file mode 100644
index 0000000..e49e7d6
--- /dev/null
+++ b/xen/tools/kconfig/allrandom.config
@@ -0,0 +1 @@
+CONFIG_GCOV_FORMAT_AUTODETECT=y
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 2/2] Travis-ci: specify KCONFIG_ALLCONFIG for randconfig

[Wei Liu]

The file provided contains symbols that must be set to certain values.
This then prevents random build breakage in travis due to
known-incompatible symbol selections.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Doug Goldstein <cardoe@cardoe.com>
---
 scripts/travis-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/travis-build b/scripts/travis-build
index 584d008..0cb15a8 100755
--- a/scripts/travis-build
+++ b/scripts/travis-build
@@ -4,7 +4,7 @@ $CC --version
 
 # random config or default config
 if [[ "${RANDCONFIG}" == "y" ]]; then
-    make -C xen randconfig
+    make -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
 else
     make -C xen defconfig
 fi
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] Kconfig: introduce allrandom.config

[Andrew Cooper]

On 05/12/16 16:45, Wei Liu wrote:
> This would be used to force selection of certain items in randconfig.
>
> We need this to force gcov format to be autodetected in randconfig
> target, which would avoid generating known-incompatible combinations.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
>  xen/tools/kconfig/allrandom.config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 xen/tools/kconfig/allrandom.config
>
> diff --git a/xen/tools/kconfig/allrandom.config b/xen/tools/kconfig/allrandom.config
> new file mode 100644
> index 0000000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@

I'd put a comment here saying

# Explicit option choices not subject to regular RANDCONFIG

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> +CONFIG_GCOV_FORMAT_AUTODETECT=y


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] Travis-ci: specify KCONFIG_ALLCONFIG for randconfig

[Andrew Cooper]

On 05/12/16 16:45, Wei Liu wrote:
> The file provided contains symbols that must be set to certain values.
> This then prevents random build breakage in travis due to
> known-incompatible symbol selections.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] Kconfig: introduce allrandom.config

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 924 bytes --]

On 12/5/16 10:45 AM, Wei Liu wrote:
> This would be used to force selection of certain items in randconfig.
> 
> We need this to force gcov format to be autodetected in randconfig
> target, which would avoid generating known-incompatible combinations.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
>  xen/tools/kconfig/allrandom.config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 xen/tools/kconfig/allrandom.config
> 
> diff --git a/xen/tools/kconfig/allrandom.config b/xen/tools/kconfig/allrandom.config
> new file mode 100644
> index 0000000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@
> +CONFIG_GCOV_FORMAT_AUTODETECT=y
> 

Thank you for doing this Wei. I do agree with Andrew about the explicit
comment.

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] Travis-ci: specify KCONFIG_ALLCONFIG for randconfig

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 915 bytes --]

On 12/5/16 10:45 AM, Wei Liu wrote:
> The file provided contains symbols that must be set to certain values.
> This then prevents random build breakage in travis due to
> known-incompatible symbol selections.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
>  scripts/travis-build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/travis-build b/scripts/travis-build
> index 584d008..0cb15a8 100755
> --- a/scripts/travis-build
> +++ b/scripts/travis-build
> @@ -4,7 +4,7 @@ $CC --version
>  
>  # random config or default config
>  if [[ "${RANDCONFIG}" == "y" ]]; then
> -    make -C xen randconfig
> +    make -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
>  else
>      make -C xen defconfig
>  fi
> 

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel