* [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.
@ 2016-12-10 17:59 Sander Eikelenboom
2016-12-12 8:17 ` Cedric Bosdonnat
2016-12-12 9:14 ` Wei Liu
0 siblings, 2 replies; 5+ messages in thread
From: Sander Eikelenboom @ 2016-12-10 17:59 UTC (permalink / raw)
To: xen-devel; +Cc: Sander Eikelenboom, Wei Liu, Cédric Bosdonnat
Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous
negation which gave the isstubdom bool the opposite semantics,
causing the subsequent code to take the wrong code path.
Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
---
tools/libxl/libxl_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 3b707f3..8395352 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, i
int irq, i, rc, hvm = 0;
uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
uint32_t domainid = domid;
- bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
+ bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
if (type == LIBXL_DOMAIN_TYPE_INVALID)
return ERROR_FAIL;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.
2016-12-10 17:59 [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough Sander Eikelenboom
@ 2016-12-12 8:17 ` Cedric Bosdonnat
2016-12-12 9:14 ` Wei Liu
2016-12-12 9:14 ` Wei Liu
1 sibling, 1 reply; 5+ messages in thread
From: Cedric Bosdonnat @ 2016-12-12 8:17 UTC (permalink / raw)
To: Sander Eikelenboom, xen-devel; +Cc: Wei Liu
Nice catch!
ACK from me, thought I don't know if it really counts ;)
--
Cedric
On Sat, 2016-12-10 at 18:59 +0100, Sander Eikelenboom wrote:
> Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous
> negation which gave the isstubdom bool the opposite semantics,
> causing the subsequent code to take the wrong code path.
>
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> ---
> tools/libxl/libxl_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 3b707f3..8395352 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, i
> int irq, i, rc, hvm = 0;
> uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
> uint32_t domainid = domid;
> - bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
> + bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>
> if (type == LIBXL_DOMAIN_TYPE_INVALID)
> return ERROR_FAIL;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.
2016-12-10 17:59 [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough Sander Eikelenboom
2016-12-12 8:17 ` Cedric Bosdonnat
@ 2016-12-12 9:14 ` Wei Liu
2016-12-12 10:16 ` Sander Eikelenboom
1 sibling, 1 reply; 5+ messages in thread
From: Wei Liu @ 2016-12-12 9:14 UTC (permalink / raw)
To: Sander Eikelenboom; +Cc: Wei Liu, Cédric Bosdonnat, xen-devel
On Sat, Dec 10, 2016 at 06:59:08PM +0100, Sander Eikelenboom wrote:
> Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous
> negation which gave the isstubdom bool the opposite semantics,
> causing the subsequent code to take the wrong code path.
>
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Though I would like to shorten the title a bit. That is, I will move the
clause "which ..." to the end of the commit log.
Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an
erroneous negation which gave the isstubdom bool the opposite semantics,
causing the subsequent code to take the wrong code path, which breaks
...
> ---
> tools/libxl/libxl_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 3b707f3..8395352 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, i
> int irq, i, rc, hvm = 0;
> uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
> uint32_t domainid = domid;
> - bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
> + bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>
> if (type == LIBXL_DOMAIN_TYPE_INVALID)
> return ERROR_FAIL;
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.
2016-12-12 9:14 ` Wei Liu
@ 2016-12-12 10:16 ` Sander Eikelenboom
0 siblings, 0 replies; 5+ messages in thread
From: Sander Eikelenboom @ 2016-12-12 10:16 UTC (permalink / raw)
To: Wei Liu; +Cc: Cédric Bosdonnat, xen-devel
On 12/12/16 10:14, Wei Liu wrote:
> On Sat, Dec 10, 2016 at 06:59:08PM +0100, Sander Eikelenboom wrote:
>> Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous
>> negation which gave the isstubdom bool the opposite semantics,
>> causing the subsequent code to take the wrong code path.
>>
>> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> Though I would like to shorten the title a bit. That is, I will move the
> clause "which ..." to the end of the commit log.
Sure, thanks for taking care !
--
Sander
> Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an
> erroneous negation which gave the isstubdom bool the opposite semantics,
> causing the subsequent code to take the wrong code path, which breaks
> ...
>
>> ---
>> tools/libxl/libxl_pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
>> index 3b707f3..8395352 100644
>> --- a/tools/libxl/libxl_pci.c
>> +++ b/tools/libxl/libxl_pci.c
>> @@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, i
>> int irq, i, rc, hvm = 0;
>> uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
>> uint32_t domainid = domid;
>> - bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
>> + bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>>
>> if (type == LIBXL_DOMAIN_TYPE_INVALID)
>> return ERROR_FAIL;
>> --
>> 2.1.4
>>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-12 10:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-10 17:59 [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough Sander Eikelenboom
2016-12-12 8:17 ` Cedric Bosdonnat
2016-12-12 9:14 ` Wei Liu
2016-12-12 9:14 ` Wei Liu
2016-12-12 10:16 ` Sander Eikelenboom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).