From: Cedric Bosdonnat <cbosdonnat@suse.com>
To: Sander Eikelenboom <linux@eikelenboom.it>, xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.
Date: Mon, 12 Dec 2016 09:17:42 +0100 [thread overview]
Message-ID: <1481530662.2854.0.camel@suse.com> (raw)
In-Reply-To: <1481392748-26814-1-git-send-email-linux@eikelenboom.it>
Nice catch!
ACK from me, thought I don't know if it really counts ;)
--
Cedric
On Sat, 2016-12-10 at 18:59 +0100, Sander Eikelenboom wrote:
> Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous
> negation which gave the isstubdom bool the opposite semantics,
> causing the subsequent code to take the wrong code path.
>
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> ---
> tools/libxl/libxl_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 3b707f3..8395352 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, i
> int irq, i, rc, hvm = 0;
> uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
> uint32_t domainid = domid;
> - bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
> + bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>
> if (type == LIBXL_DOMAIN_TYPE_INVALID)
> return ERROR_FAIL;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-12 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 17:59 [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough Sander Eikelenboom
2016-12-12 8:17 ` Cedric Bosdonnat [this message]
2016-12-12 9:14 ` Wei Liu
2016-12-12 9:14 ` Wei Liu
2016-12-12 10:16 ` Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481530662.2854.0.camel@suse.com \
--to=cbosdonnat@suse.com \
--cc=linux@eikelenboom.it \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).