From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH v1 4/7] livepatch: Set timeout unit to nanoseconds
Date: Mon, 12 Dec 2016 16:18:07 +0000 [thread overview]
Message-ID: <1481559490-13844-5-git-send-email-ross.lagerwall@citrix.com> (raw)
In-Reply-To: <1481559490-13844-1-git-send-email-ross.lagerwall@citrix.com>
The hypervisor already expects the timeout from the hypercall to be in
nanoseconds, so set this expectation everywhere.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
tools/libxc/include/xenctrl.h | 2 +-
xen/common/livepatch.c | 4 ++--
xen/include/public/sysctl.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index 2c83544..4ab0f57 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -2703,7 +2703,7 @@ int xc_livepatch_list(xc_interface *xch, unsigned int max, unsigned int start,
* The operations are asynchronous and the hypervisor may take a while
* to complete them. The `timeout` offers an option to expire the
* operation if it could not be completed within the specified time
- * (in ms). Value of 0 means let hypervisor decide the best timeout.
+ * (in ns). Value of 0 means let hypervisor decide the best timeout.
*/
int xc_livepatch_apply(xc_interface *xch, char *name, uint32_t timeout);
int xc_livepatch_revert(xc_interface *xch, char *name, uint32_t timeout);
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index fc8ef99..246e673 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -1227,8 +1227,8 @@ static int schedule_work(struct payload *data, uint32_t cmd, uint32_t timeout)
livepatch_work.data = data;
livepatch_work.timeout = timeout ?: MILLISECS(30);
- dprintk(XENLOG_DEBUG, LIVEPATCH "%s: timeout is %"PRI_stime"ms\n",
- data->name, livepatch_work.timeout / MILLISECS(1));
+ dprintk(XENLOG_DEBUG, LIVEPATCH "%s: timeout is %"PRIu32"ns\n",
+ data->name, livepatch_work.timeout);
atomic_set(&livepatch_work.semaphore, -1);
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 28ac56c..3c67858 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -1068,7 +1068,7 @@ struct xen_sysctl_livepatch_action {
#define LIVEPATCH_ACTION_REPLACE 4
uint32_t cmd; /* IN: LIVEPATCH_ACTION_*. */
uint32_t timeout; /* IN: Zero if no timeout. */
- /* Or upper bound of time (ms) */
+ /* Or upper bound of time (ns) */
/* for operation to take. */
};
typedef struct xen_sysctl_livepatch_action xen_sysctl_livepatch_action_t;
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-12 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:18 [PATCH v1 0/7] xen-livepatch misc fixes/changes Ross Lagerwall
2016-12-12 16:18 ` [PATCH v1 1/7] tools/livepatch: Show the correct expected state before action Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-12 16:18 ` [PATCH v1 2/7] tools/livepatch: Set stdout and stderr unbuffered Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-14 6:44 ` Ross Lagerwall
2016-12-14 7:43 ` Wei Liu
2016-12-12 16:18 ` [PATCH v1 3/7] tools/livepatch: Improve output Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-12 17:11 ` Konrad Rzeszutek Wilk
2016-12-12 16:18 ` Ross Lagerwall [this message]
2016-12-12 17:02 ` [PATCH v1 4/7] livepatch: Set timeout unit to nanoseconds Wei Liu
2016-12-12 17:13 ` Konrad Rzeszutek Wilk
2016-12-12 16:18 ` [PATCH v1 5/7] tools/livepatch: Remove pointless retry loop Ross Lagerwall
2016-12-12 17:03 ` Wei Liu
2016-12-12 16:18 ` [PATCH v1 6/7] tools/livepatch: Remove unused struct member Ross Lagerwall
2016-12-12 17:03 ` Wei Liu
2016-12-12 17:13 ` Konrad Rzeszutek Wilk
2016-12-12 16:18 ` [PATCH v1 7/7] tools/livepatch: Exit with 2 if a timeout occurs Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481559490-13844-5-git-send-email-ross.lagerwall@citrix.com \
--to=ross.lagerwall@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).