From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH] libxl: init_acpi_config should return rc in exit path
Date: Wed, 14 Dec 2016 11:44:36 +0000 [thread overview]
Message-ID: <1481715876-32059-1-git-send-email-wei.liu2@citrix.com> (raw)
... otherwise it returns 0 even if the function fails.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
This should be backported to 4.8.
---
tools/libxl/libxl_x86_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_x86_acpi.c b/tools/libxl/libxl_x86_acpi.c
index 686ac8e..6cf0c30 100644
--- a/tools/libxl/libxl_x86_acpi.c
+++ b/tools/libxl/libxl_x86_acpi.c
@@ -154,7 +154,7 @@ static int init_acpi_config(libxl__gc *gc,
config->acpi_revision = 5;
out:
- return 0;
+ return rc;
}
int libxl__dom_load_acpi(libxl__gc *gc,
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-12-14 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 11:44 Wei Liu [this message]
2016-12-14 11:49 ` [PATCH] libxl: init_acpi_config should return rc in exit path Andrew Cooper
2016-12-14 12:28 ` Wei Liu
2016-12-16 15:10 ` Boris Ostrovsky
2016-12-16 15:16 ` Wei Liu
2016-12-16 15:21 ` Boris Ostrovsky
2016-12-16 15:20 ` Wei Liu
2016-12-16 15:42 ` Ian Jackson
2016-12-16 11:05 ` Ian Jackson
2016-12-16 11:09 ` Wei Liu
2016-12-16 16:23 ` Wei Liu
2016-12-16 16:25 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481715876-32059-1-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).