From mboxrd@z Thu Jan 1 00:00:00 1970 From: Praveen Kumar Subject: [PATCH] Removal of redundant check Date: Wed, 14 Dec 2016 23:49:58 +0530 Message-ID: <1481739598.6878.10.camel@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-45c80ONF5ZT8Xmc+Jw1j" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xen.org Cc: george.dunlap@eu.citrix.com, Dario Faggioli List-Id: xen-devel@lists.xenproject.org --=-45c80ONF5ZT8Xmc+Jw1j Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The patch gets rid of a redundant check in csched_vcpu_acct which adds more code clarity and performance. This patch also adds an ASSERT to the same effect, in order to make assumption ( i.e., no calling this on idle vcpus) even more clear and as a guard for future mis-use. Signed-off-by: Praveen Kumar diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index fc3a321..dfe8545 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -941,6 +941,7 @@ csched_vcpu_acct(struct csched_private *prv, unsigned int cpu)      ASSERT( current->processor == cpu );      ASSERT( svc->sdom != NULL ); +    ASSERT( !is_idle_vcpu(svc->vcpu) );      /*       * If this VCPU's priority was boosted when it last awoke, reset it. @@ -957,8 +958,7 @@ csched_vcpu_acct(struct csched_private *prv, unsigned int cpu)      /*       * Update credits       */ -    if ( !is_idle_vcpu(svc->vcpu) ) -        burn_credits(svc, NOW()); +    burn_credits(svc, NOW());      /*       * Put this VCPU and domain back on the active list if it was --=-45c80ONF5ZT8Xmc+Jw1j Content-Disposition: attachment; filename="redundantCheckRemoval.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="redundantCheckRemoval.patch"; charset="UTF-8" VGhlIHBhdGNoIGdldHMgcmlkIG9mIGEgcmVkdW5kYW50IGNoZWNrIGluIGNzY2hlZF92Y3B1X2Fj Y3Qgd2hpY2ggYWRkcyBtb3JlIGNvZGUKY2xhcml0eSBhbmQgcGVyZm9ybWFuY2UuIFRoaXMgcGF0 Y2ggYWxzbyBhZGRzIGFuIEFTU0VSVCB0byB0aGUgc2FtZSBlZmZlY3QsIGluCm9yZGVyIHRvIG1h a2UgYXNzdW1wdGlvbiAoIGkuZS4sIG5vIGNhbGxpbmcgdGhpcyBvbiBpZGxlIHZjcHVzKSBldmVu IG1vcmUgY2xlYXIKYW5kIGFzIGEgZ3VhcmQgZm9yIGZ1dHVyZSBtaXMtdXNlLgoKU2lnbmVkLW9m Zi1ieTogUHJhdmVlbiBLdW1hciA8a3ByYXZlZW4ubGttbEBnbWFpbC5jb20+CgpkaWZmIC0tZ2l0 IGEveGVuL2NvbW1vbi9zY2hlZF9jcmVkaXQuYyBiL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0LmMK aW5kZXggZmMzYTMyMS4uZGZlODU0NSAxMDA2NDQKLS0tIGEveGVuL2NvbW1vbi9zY2hlZF9jcmVk aXQuYworKysgYi94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdC5jCkBAIC05NDEsNiArOTQxLDcgQEAg Y3NjaGVkX3ZjcHVfYWNjdChzdHJ1Y3QgY3NjaGVkX3ByaXZhdGUgKnBydiwgdW5zaWduZWQgaW50 IGNwdSkKCiAgICAgQVNTRVJUKCBjdXJyZW50LT5wcm9jZXNzb3IgPT0gY3B1ICk7CiAgICAgQVNT RVJUKCBzdmMtPnNkb20gIT0gTlVMTCApOworICAgIEFTU0VSVCggIWlzX2lkbGVfdmNwdShzdmMt PnZjcHUpICk7CgogICAgIC8qCiAgICAgICogSWYgdGhpcyBWQ1BVJ3MgcHJpb3JpdHkgd2FzIGJv b3N0ZWQgd2hlbiBpdCBsYXN0IGF3b2tlLCByZXNldCBpdC4KQEAgLTk1Nyw4ICs5NTgsNyBAQCBj c2NoZWRfdmNwdV9hY2N0KHN0cnVjdCBjc2NoZWRfcHJpdmF0ZSAqcHJ2LCB1bnNpZ25lZCBpbnQg Y3B1KQogICAgIC8qCiAgICAgICogVXBkYXRlIGNyZWRpdHMKICAgICAgKi8KLSAgICBpZiAoICFp c19pZGxlX3ZjcHUoc3ZjLT52Y3B1KSApCi0gICAgICAgIGJ1cm5fY3JlZGl0cyhzdmMsIE5PVygp KTsKKyAgICBidXJuX2NyZWRpdHMoc3ZjLCBOT1coKSk7CgogICAgIC8qCiAgICAgICogUHV0IHRo aXMgVkNQVSBhbmQgZG9tYWluIGJhY2sgb24gdGhlIGFjdGl2ZSBsaXN0IGlmIGl0IHdhcwo= --=-45c80ONF5ZT8Xmc+Jw1j Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --=-45c80ONF5ZT8Xmc+Jw1j--