From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: xen-devel@lists.xen.org
Cc: edgar.iglesias@xilinx.com, wei.liu2@citrix.com,
julien.grall@arm.com, sstabellini@kernel.org,
ian.jackson@eu.citrix.com
Subject: [PATCH v1 1/2] tools/xenstat: Remove redundant check for curses.h
Date: Thu, 15 Dec 2016 13:36:08 +0100 [thread overview]
Message-ID: <1481805369-9042-2-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1481805369-9042-1-git-send-email-edgar.iglesias@gmail.com>
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
This check for curses.h does not consider cross-compilation.
It only checks host paths.
Luckily, commit 65da4913214120ddc95bd846cb3649a29f87146a
introduced proper configure checks for ncurses so we can
remove the redundant check in the Makefile.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
tools/xenstat/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/xenstat/Makefile b/tools/xenstat/Makefile
index 901be4a..09ec1b7 100644
--- a/tools/xenstat/Makefile
+++ b/tools/xenstat/Makefile
@@ -6,10 +6,8 @@ SUBDIRS += libxenstat
# This doesn't cross-compile (cross-compile environments rarely have curses)
ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
-ifeq ($(wildcard /usr/include/curses.h),/usr/include/curses.h)
SUBDIRS += xentop
endif
-endif
.PHONY: all install clean distclean
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-15 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 12:36 [PATCH v1 0/2] tools: Allow cross-compilation of xentop Edgar E. Iglesias
2016-12-15 12:36 ` Edgar E. Iglesias [this message]
2016-12-15 12:36 ` [PATCH v1 2/2] tools/xenstat: Don't disable xentop when cross-compiling Edgar E. Iglesias
2016-12-16 10:44 ` [PATCH v1 0/2] tools: Allow cross-compilation of xentop Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481805369-9042-2-git-send-email-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).