From: Dario Faggioli <dario.faggioli@citrix.com>
To: Praveen Kumar <kpraveen.lkml@gmail.com>, xen-devel@lists.xen.org
Cc: george.dunlap@eu.citrix.com
Subject: Re: [PATCH v3] xen: sched: removal of redundant check in Credit
Date: Sat, 17 Dec 2016 02:46:28 +0100 [thread overview]
Message-ID: <1481939188.3445.473.camel@citrix.com> (raw)
In-Reply-To: <1481916226-19177-1-git-send-email-kpraveen.lkml@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1404 bytes --]
On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote:
> The patch gets rid of a redundant check in csched_vcpu_acct. In fact,
> the function is only called from csched_tick, which already checks
> that current is not the idle vcpu. The patch also adds an ASSERT to
> the same effect, in order to make assumption ( i.e., no calling this
> on idle vcpus) even more clear and as a guard for future mis-use.
>
> Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
> Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
>
Better than before. But still, if I:
- save this mail as mbox
- try to import it in git
it fails.
OTOH, if I:
- save this mail as mbox
- run dos2unix on the mbox file
- try to import it in git
it works!
Which, since you're now using git-send-email, makes me think it may be
your editor/OS which is at fault and inserts spurious stuff at line
breaks (the classic CR vs. CR+LF thing).
What editor on what OS are you using?
Another possibility is that there is something wrong here at my hand.
George, do you have (similar) issues when trying to apply this patch?
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-17 1:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 19:23 [PATCH v3] xen: sched: removal of redundant check in Credit Praveen Kumar
2016-12-17 1:46 ` Dario Faggioli [this message]
2016-12-17 8:14 ` Praveen Kumar
2016-12-20 9:04 ` Praveen Kumar
2016-12-20 13:18 ` Dario Faggioli
2016-12-28 9:02 ` George Dunlap
2016-12-28 14:23 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481939188.3445.473.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=kpraveen.lkml@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).