[PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

[PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

[Ian Jackson]

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
---
 docs/misc/xen-command-line.markdown | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
index 0138978..68c81e6 100644
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -1260,6 +1260,7 @@ the **vga** option, which relies on real mode to set the video mode.
 Do not automatically reboot after an error.  This is useful for
 catching debug output.  Defaults to automatically reboot after 5
 seconds.
+This is equivalent to `reboot=no`
 
 ### nosmp
 > `= <boolean>`
@@ -1356,7 +1357,9 @@ The following resources are available:
 
 > Default: `0`
 
-Specify the host reboot method.
+Specify the host reboot method,
+used when Xen crashes.
+(This does not affect deliberate reboots initiated by dom0.)
 
 `warm` instructs Xen to not set the cold reboot flag.
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

[Jan Beulich]

>>> On 22.12.16 at 16:02, <ian.jackson@eu.citrix.com> wrote:
> @@ -1356,7 +1357,9 @@ The following resources are available:
>  
>  > Default: `0`
>  
> -Specify the host reboot method.
> +Specify the host reboot method,
> +used when Xen crashes.
> +(This does not affect deliberate reboots initiated by dom0.)

This should be moved down to where `no` is being described, as
it affects only that sub-option. The reboot methods, otoh, affect
all kinds of reboots.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

[Ian Jackson]

Jan Beulich writes ("Re: [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options"):
> On 22.12.16 at 16:02, <ian.jackson@eu.citrix.com> wrote:
> > -Specify the host reboot method.
> > +Specify the host reboot method,
> > +used when Xen crashes.
> > +(This does not affect deliberate reboots initiated by dom0.)
> 
> This should be moved down to where `no` is being described, as
> it affects only that sub-option. The reboot methods, otoh, affect
> all kinds of reboots.

So you might say
  reboot=triple reboot=efi reboot=no
and this would mean to do requested reboots with efi and crash reboots
not at all, with `reboot=triple' being completely ignored ?

This is ... a funny way for an option with a `=' to behave.
Perhaps we should deprecate this.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

[Jan Beulich]

>>> Ian Jackson <ian.jackson@eu.citrix.com> 12/22/16 8:00 PM >>>
>Jan Beulich writes ("Re: [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options"):
>> On 22.12.16 at 16:02, <ian.jackson@eu.citrix.com> wrote:
>> > -Specify the host reboot method.
>> > +Specify the host reboot method,
>> > +used when Xen crashes.
>> > +(This does not affect deliberate reboots initiated by dom0.)
>> 
>> This should be moved down to where `no` is being described, as
>> it affects only that sub-option. The reboot methods, otoh, affect
>> all kinds of reboots.
>
>So you might say
>reboot=triple reboot=efi reboot=no
>and this would mean to do requested reboots with efi and crash reboots
>not at all, with `reboot=triple' being completely ignored ?

Yes.

>This is ... a funny way for an option with a `=' to behave.
>Perhaps we should deprecate this.

I don't think we should. This override behavior has a use - when something is preset
in a config file, and you want to override it on the command line (which can be easily
the case namely under EFI). And this behavior is the same for most if not all other
command line options.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel