From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 5/5] libxl: Add explicit cast to libxl_psr_cat_set_cbm Date: Fri, 13 Jan 2017 10:05:22 +0100 Message-ID: <1484298322.9947.37.camel@citrix.com> References: <1451925649.13361.193.camel@citrix.com> <1453183100-50700-1-git-send-email-czylin@uwaterloo.ca> <22174.17133.666899.340909@mariner.uk.xensource.com> <1453213869.29930.58.camel@citrix.com> <22174.18851.370957.544009@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4225998860893663801==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , Ian Jackson Cc: Ian Campbell , Stefano Stabellini , Chester Lin , "xen-devel@lists.xen.org" , jtotto@uwaterloo.ca, hjarmstr@uwaterloo.ca List-Id: xen-devel@lists.xenproject.org --===============4225998860893663801== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-jJkSzTwQ2QSexl/Hcvoj" --=-jJkSzTwQ2QSexl/Hcvoj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-01-12 at 18:08 +0000, George Dunlap wrote: > On Tue, Jan 19, 2016 at 2:35 PM, Ian Jackson > wrote: > >=20 > > > On Tue, 2016-01-19 at 14:06 +0000, Ian Jackson wrote: > > > >=20 > > > > =C2=A0* XEN_DOMCTL_PSR_CAT_OP_SET_L3_* (public/domctl.h) > > > > =C2=A0* enum xc_psr_cat_type (xenctrl.h) > > > > =C2=A0* Enumeration("psr_cbm_type",...) (libxl_types.idl) > > >=20 > > > Forgot to say in my other reply, but we could try and abolish at > > > least the > > > xc one and have libxl internally use the domctl values. > >=20 > > Yes. > >=20 > > I like George's IDL suggestion. >=20 > Out of curiosity, did anything ever come of this?=C2=A0=C2=A0 > AFAICT, no. The patch with the casts was not taken, and we still have all the three enums/types in Xen, libxc and libxl. > If not it seems > like we should write it down somewhere. >=20 Indeed, especially because it was a good idea. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-jJkSzTwQ2QSexl/Hcvoj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYeJhSAAoJEBZCeImluHPufXcP+wYXPDglpj4E/9lOxAKeJNJp hR4/Bn/zbW7ZpHS8llNVN5AUT3i9tNxP4MtXUNx7N1UcLqQVAAT184cLNZ5qkTdC pCHsHftKCPQqRchh990omKqLg3U1vXNf4tNuQftuyTIuyYYmSQxMfJAiS1bHbcyH 261qkkYidGhGqAejHz50k6bSQSsg7Qh4yobmMXfLs7pw54sHkn7gHFxUppb0go2k 50RO1QQx5Tx9JQ9cZCnB+V3hkQX5CFf8zVeZNOJc/Xz9TtUATo76Qmh4z9fXP682 PqsGD0SN3Z/Cc0CXvjlJ2+jYIgqEvyIiWzoWJZutF+fdvGPiFTCf6Z3xo/cUtBrJ WT35SCuGtJlaLIJpQcQMP//YjFKzWokO6ixc45BQgIwCLCxV3Dk4I+kjU/jaO6rn DZG9U1QjPgAVVQuZzFfIQkMgJEIvqSs+r+DBUHv0FZa9YYbTXGkXY+eJayyZBuCh k9M416csoSOM0yCYLxxeLxVyOQammsENOqYF6lm/1IloX7J/FnpRUNYn+flIsm4e AhxmJ4wS49AgDHpWswwJaTYYTmrVirGV+E6wzo/30dbA/FmoEST7zcxeMESX52pb niTSTsdEzb7GRwi9kzZZ0OMyl6boYd6fSlzvhCHfoQ9tJX5wbMez6kEOzy1RraQS xpZ2nqZN8FacFi3MeCsH =NkEH -----END PGP SIGNATURE----- --=-jJkSzTwQ2QSexl/Hcvoj-- --===============4225998860893663801== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4225998860893663801==--