From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 4/5] xen: sched: impove use of cpumask scratch space in Credit1. Date: Wed, 18 Jan 2017 10:54:45 +0100 Message-ID: <1484733285.7492.67.camel@citrix.com> References: <148467379229.27920.2367500429219327194.stgit@Solace.fritz.box> <148467402295.27920.12760704062556867752.stgit@Solace.fritz.box> <587F4738020000780013120D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2512161176463594768==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTmxA-0007hL-Fw for xen-devel@lists.xenproject.org; Wed, 18 Jan 2017 09:54:52 +0000 In-Reply-To: <587F4738020000780013120D@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============2512161176463594768== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-QMhYFQ/sG6OOmbwYGyxB" --=-QMhYFQ/sG6OOmbwYGyxB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-01-18 at 02:45 -0700, Jan Beulich wrote: > > > > On 17.01.17 at 18:27, wrote: > > --- a/xen/include/xen/sched-if.h > > +++ b/xen/include/xen/sched-if.h > > @@ -47,6 +47,13 @@ DECLARE_PER_CPU(struct schedule_data, > > schedule_data); > > =C2=A0DECLARE_PER_CPU(struct scheduler *, scheduler); > > =C2=A0DECLARE_PER_CPU(struct cpupool *, cpupool); > > =C2=A0 > > +/* > > + * Scratch space, for avoiding having too many cpumask_var_t on > > the stack. >=20 > Mind dropping the stray / misleading _var infix from here?=20 > Ah, sure! > There's > no problem having many cpumask_var_t-s on the stack, as they're > small. cpumask_t instances are problematic. >=20 Of course. Will do. Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-QMhYFQ/sG6OOmbwYGyxB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYfztlAAoJEBZCeImluHPuX0AQAKp4Y8pru7cBsmD4M9vmskfr wzp8mCdp3mwvcmdMEvrVqOQQVV8aFD47SVoQDmbf5r04CdsTRGLkYVGK3uglaupK lH7qMuUN29x/gKJyMnEr2ifEpZw5Ps24Jjl538Xwv4rrFNPhMCuyroCsMhaks7P/ IP/Lse//jZrYM6nllCvNuIhlCXJsG/F7kEILLfFmn90bNzdNADUcJM2QOoPqtcl1 x67q89xl1phimKg0GwaZZDxEqZc4RW3nLzdExBas2WNmjnMoeTrgb4/2Tgz9LhBI 9VBL7drZqhwydGa136R7aPNdHcttbeVU8ALmLkjwdeH9Vcxtx2UNKEWtjLyELQ7Y sN2jsJQd0Bd7UNs6wOwMxKlNiJ+dC7ojd4f58LorKOW2/bRZ/0ELps1+gIsEDyXV f3I3gLjREhJvEaiY070Vji9TC4XQ89xNwWcRYbnONCxpRkIarcK0oblfo0VoQG0q sbTtFET39/j+uPxWZjeZ4RTqMLAwVkSalGh53jusSx+eWQWtBh44eLrybU0NU2AW hQDO0HEwK1GcQSvPJA09TGRQSUAQxIcDFQS+8BQuficfDvLcYIf4JApTPtJMDG2h LtKZNYhGrUtKQEOwsVQ9l+CRgmACVkGALgnj/BhCMp/4f71FaPeIifdvIHkxS/Ag WQRf1e1XEA9wtUYFeODp =UOf9 -----END PGP SIGNATURE----- --=-QMhYFQ/sG6OOmbwYGyxB-- --===============2512161176463594768== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2512161176463594768==--