From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 2/5] xen: credit2: never consider CPUs outside of our cpupool. Date: Tue, 24 Jan 2017 13:49:53 +0100 Message-ID: <1485262193.32103.50.camel@citrix.com> References: <148467379229.27920.2367500429219327194.stgit@Solace.fritz.box> <148467400670.27920.10444838852821010432.stgit@Solace.fritz.box> <307c0f57-ea12-6c8f-5f98-27e406d1de46@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4497359559579520595==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW0Y4-0002ZJ-7c for xen-devel@lists.xenproject.org; Tue, 24 Jan 2017 12:50:08 +0000 In-Reply-To: <307c0f57-ea12-6c8f-5f98-27e406d1de46@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , George Dunlap Cc: xen-devel , "anshul.makkar" , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============4497359559579520595== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-nmdqF+wuR/4CjWzusYD/" --=-nmdqF+wuR/4CjWzusYD/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-01-24 at 13:35 +0100, Juergen Gross wrote: > On 23/01/17 15:40, George Dunlap wrote: > >=C2=A0 > > Having a "cpupool-remove" operation that doesn't actually remove > > the > > cpu from the pool is a bit mad... >=20 > Logically it does remove the cpu from Pool-0. It is just that there > is > no other scheduler entity involved for doing so. >=20 Yes, it's removed from the pool, *but* it basically remains part of the pool's scheduler, that's the issue. As you say, there's no another scheduler to which we can attach it... So, as of now, I see two options: 1) create such (dummy) scheduler; 2) go all the way down toward deallocating the scheduler related data=C2=A0 =C2=A0 =C2=A0of the cpu (and reallocate them back when re-added). BTW, Anshul also hit this problem while also doing some work on Credit2, and told me he'd be giving some thinking to it, and try to figure some ideas out (as soon as he'd be free of a couple of other burdens :-D). Let's see what he'll come up with. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-nmdqF+wuR/4CjWzusYD/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYh01yAAoJEBZCeImluHPuIfQQAMl/lZz9O8rZksg+Xz9n7uXK r92UedlBt9233vpEvsu+LmuM+iog1MnHk/iipRxm2wI3atxGZHUpK94PXI9bNr5A X4517TuhSEOSAF9B9k7reAP5X0MYcgdXDoAVRaMKq/Np8jeONzmk1CVjBDucDac2 wMBljbzi7UXOQBMv/6OgZl37q8L9NiHPT0XGUsIwV87IdnCyBkeGgdwlzLdoeQQC 3N9F7uGqUZuqm69pki/FObvTxNsnsRXGxSzvm2o7RDinugY/6l9xnZ2Vg7tF1AOW dEGbjYg96y4MLr2nWTKkK/LX7n4Ya4OyniuCaO0u0hpOd1hfdHjTgWfsEb6xUDgr BJSU2o4TcaXWsMWaKbikXq+suorrjZx2JnzhdbePsZ9QrU35dObMOYJ/XUMxrHTg DqOlJ5WOwiK6U3bB+L7DdHx6OYQK+xGn78czzTnsDXZGWTy9S+dkfSL7wpXljQN2 fF/zTHyRJyS1mxM0rqOMQfg8waInn1HRYe0g6nKHL6ZcJ+8qDUs5LByJkhJaiLAZ UCV7kX8tyTRzrz+jJn1SrxypEY/MRPm+OB7E5ZPWZu46wHV8zdHeu1A3WeG5z6IX oKkE4Wkmf0xx01+1ZQx4PNfWNuw2TiO07rSeSRk0+mjYiOxXk4jzALlKIv8yELEo KLXtTPSIeHPydSDmfbhw =0HuX -----END PGP SIGNATURE----- --=-nmdqF+wuR/4CjWzusYD/-- --===============4497359559579520595== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4497359559579520595==--