* [PATCH] Fix mispelling of length
@ 2017-02-02 20:42 Julien Grall
2017-02-02 22:58 ` Stefano Stabellini
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Julien Grall @ 2017-02-02 20:42 UTC (permalink / raw)
To: xen-devel
Cc: sstabellini, Wei Liu, George Dunlap, Dario Faggioli, Ian Jackson,
Julien Grall
There are quite a few usage of "lenght" instead of "length" in different
part of the repo. Correct it once for all.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
tools/libxl/libxl_json.c | 4 ++--
xen/common/sched_credit2.c | 16 ++++++++--------
xen/include/asm-arm/alternative.h | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
index b60ae2b..0823b8c 100644
--- a/tools/libxl/libxl_json.c
+++ b/tools/libxl/libxl_json.c
@@ -69,8 +69,8 @@ struct libxl__yajl_ctx {
# define DEBUG_GEN_FREE(ctx) ((void)0)
# define DEBUG_GEN(ctx, type) ((void)0)
# define DEBUG_GEN_VALUE(ctx, type, value) ((void)0)
-# define DEBUG_GEN_STRING(ctx, value, lenght) ((void)0)
-# define DEBUG_GEN_NUMBER(ctx, value, lenght) ((void)0)
+# define DEBUG_GEN_STRING(ctx, value, length) ((void)0)
+# define DEBUG_GEN_NUMBER(ctx, value, length) ((void)0)
# define DEBUG_GEN_REPORT(ctx) ((void)0)
#endif
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index 93c6d32..84ee015 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -227,7 +227,7 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
* avg[0] = load*P
* avg[i+1] = avg[i] + delta*load*P/W - delta*avg[i]/W, 0 <= delta <= W
*
- * where W is the lenght of the window, P the multiplier for transitiong into
+ * where W is the length of the window, P the multiplier for transitiong into
* Q-format fixed point arithmetic and load is the instantaneous load of a
* runqueue, which basically is the number of runnable vcpus there are on the
* runqueue (for the meaning of the other terms, look at the doc comment to
@@ -276,7 +276,7 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
#define LOADAVG_PRECISION_SHIFT_MIN (4)
/*
- * Both the lenght of the window and the number of fractional bits can be
+ * Both the length of the window and the number of fractional bits can be
* decided with boot parameters.
*
* The length of the window is always expressed in nanoseconds. The actual
@@ -574,7 +574,7 @@ __runq_elem(struct list_head *elem)
* Track the runq load by gathering instantaneous load samples, and using
* exponentially weighted moving average (EWMA) for the 'decaying'.
*
- * We consider a window of lenght W=2^(prv->load_window_shift) nsecs
+ * We consider a window of length W=2^(prv->load_window_shift) nsecs
* (which takes LOADAVG_GRANULARITY_SHIFT into account).
*
* If load is the instantaneous load, the formula for EWMA looks as follows,
@@ -591,7 +591,7 @@ __runq_elem(struct list_head *elem)
* avgload = a*load + (1 - a)*avgload
*
* For determining a, we consider _when_ we are doing the load update, wrt
- * the lenght of the window. We define delta as follows:
+ * the length of the window. We define delta as follows:
*
* delta = t - load_last_update
*
@@ -602,7 +602,7 @@ __runq_elem(struct list_head *elem)
* There are two possible situations:
*
* a) delta <= W
- * this means that, during the last window of lenght W, the runeuque load
+ * this means that, during the last window of length W, the runeuque load
* was avgload for (W - detla) time, and load for delta time:
*
* |----------- W ---------|
@@ -621,7 +621,7 @@ __runq_elem(struct list_head *elem)
* 1 - a = 1 - (delta / W) = (W - delta) / W
*
* Which matches the above description of what happened in the last
- * window of lenght W.
+ * window of length W.
*
* Note that this also means that the weight that we assign to both the
* latest load sample, and to previous history, varies at each update.
@@ -2540,7 +2540,7 @@ csched2_schedule(
* The reset condition is "has a scheduler epoch come to an end?".
* The way this is enforced is checking whether the vcpu at the top
* of the runqueue has negative credits. This means the epochs have
- * variable lenght, as in one epoch expores when:
+ * variable length, as in one epoch expores when:
* 1) the vcpu at the top of the runqueue has executed for
* around 10 ms (with default parameters);
* 2) no other vcpu with higher credits wants to run.
@@ -3043,7 +3043,7 @@ csched2_init(struct scheduler *ops)
__func__, opt_load_window_shift);
opt_load_window_shift = LOADAVG_WINDOW_SHIFT;
}
- printk(XENLOG_INFO "load tracking window lenght %llu ns\n",
+ printk(XENLOG_INFO "load tracking window length %llu ns\n",
1ULL << opt_load_window_shift);
/* Basically no CPU information is available at this point; just
diff --git a/xen/include/asm-arm/alternative.h b/xen/include/asm-arm/alternative.h
index 6851217..9dcdcfb 100644
--- a/xen/include/asm-arm/alternative.h
+++ b/xen/include/asm-arm/alternative.h
@@ -160,7 +160,7 @@ static inline void apply_alternatives_all(void)
{
}
-static inline int apply_alternatives(void *start, size_t lenght)
+static inline int apply_alternatives(void *start, size_t length)
{
return 0;
}
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix mispelling of length
2017-02-02 20:42 [PATCH] Fix mispelling of length Julien Grall
@ 2017-02-02 22:58 ` Stefano Stabellini
2017-02-03 11:23 ` Wei Liu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2017-02-02 22:58 UTC (permalink / raw)
To: Julien Grall
Cc: sstabellini, Wei Liu, George Dunlap, Dario Faggioli, Ian Jackson,
xen-devel
On Thu, 2 Feb 2017, Julien Grall wrote:
> There are quite a few usage of "lenght" instead of "length" in different
> part of the repo. Correct it once for all.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> ---
> tools/libxl/libxl_json.c | 4 ++--
> xen/common/sched_credit2.c | 16 ++++++++--------
> xen/include/asm-arm/alternative.h | 2 +-
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
> index b60ae2b..0823b8c 100644
> --- a/tools/libxl/libxl_json.c
> +++ b/tools/libxl/libxl_json.c
> @@ -69,8 +69,8 @@ struct libxl__yajl_ctx {
> # define DEBUG_GEN_FREE(ctx) ((void)0)
> # define DEBUG_GEN(ctx, type) ((void)0)
> # define DEBUG_GEN_VALUE(ctx, type, value) ((void)0)
> -# define DEBUG_GEN_STRING(ctx, value, lenght) ((void)0)
> -# define DEBUG_GEN_NUMBER(ctx, value, lenght) ((void)0)
> +# define DEBUG_GEN_STRING(ctx, value, length) ((void)0)
> +# define DEBUG_GEN_NUMBER(ctx, value, length) ((void)0)
> # define DEBUG_GEN_REPORT(ctx) ((void)0)
> #endif
>
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 93c6d32..84ee015 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -227,7 +227,7 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
> * avg[0] = load*P
> * avg[i+1] = avg[i] + delta*load*P/W - delta*avg[i]/W, 0 <= delta <= W
> *
> - * where W is the lenght of the window, P the multiplier for transitiong into
> + * where W is the length of the window, P the multiplier for transitiong into
> * Q-format fixed point arithmetic and load is the instantaneous load of a
> * runqueue, which basically is the number of runnable vcpus there are on the
> * runqueue (for the meaning of the other terms, look at the doc comment to
> @@ -276,7 +276,7 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
> #define LOADAVG_PRECISION_SHIFT_MIN (4)
>
> /*
> - * Both the lenght of the window and the number of fractional bits can be
> + * Both the length of the window and the number of fractional bits can be
> * decided with boot parameters.
> *
> * The length of the window is always expressed in nanoseconds. The actual
> @@ -574,7 +574,7 @@ __runq_elem(struct list_head *elem)
> * Track the runq load by gathering instantaneous load samples, and using
> * exponentially weighted moving average (EWMA) for the 'decaying'.
> *
> - * We consider a window of lenght W=2^(prv->load_window_shift) nsecs
> + * We consider a window of length W=2^(prv->load_window_shift) nsecs
> * (which takes LOADAVG_GRANULARITY_SHIFT into account).
> *
> * If load is the instantaneous load, the formula for EWMA looks as follows,
> @@ -591,7 +591,7 @@ __runq_elem(struct list_head *elem)
> * avgload = a*load + (1 - a)*avgload
> *
> * For determining a, we consider _when_ we are doing the load update, wrt
> - * the lenght of the window. We define delta as follows:
> + * the length of the window. We define delta as follows:
> *
> * delta = t - load_last_update
> *
> @@ -602,7 +602,7 @@ __runq_elem(struct list_head *elem)
> * There are two possible situations:
> *
> * a) delta <= W
> - * this means that, during the last window of lenght W, the runeuque load
> + * this means that, during the last window of length W, the runeuque load
> * was avgload for (W - detla) time, and load for delta time:
> *
> * |----------- W ---------|
> @@ -621,7 +621,7 @@ __runq_elem(struct list_head *elem)
> * 1 - a = 1 - (delta / W) = (W - delta) / W
> *
> * Which matches the above description of what happened in the last
> - * window of lenght W.
> + * window of length W.
> *
> * Note that this also means that the weight that we assign to both the
> * latest load sample, and to previous history, varies at each update.
> @@ -2540,7 +2540,7 @@ csched2_schedule(
> * The reset condition is "has a scheduler epoch come to an end?".
> * The way this is enforced is checking whether the vcpu at the top
> * of the runqueue has negative credits. This means the epochs have
> - * variable lenght, as in one epoch expores when:
> + * variable length, as in one epoch expores when:
> * 1) the vcpu at the top of the runqueue has executed for
> * around 10 ms (with default parameters);
> * 2) no other vcpu with higher credits wants to run.
> @@ -3043,7 +3043,7 @@ csched2_init(struct scheduler *ops)
> __func__, opt_load_window_shift);
> opt_load_window_shift = LOADAVG_WINDOW_SHIFT;
> }
> - printk(XENLOG_INFO "load tracking window lenght %llu ns\n",
> + printk(XENLOG_INFO "load tracking window length %llu ns\n",
> 1ULL << opt_load_window_shift);
>
> /* Basically no CPU information is available at this point; just
> diff --git a/xen/include/asm-arm/alternative.h b/xen/include/asm-arm/alternative.h
> index 6851217..9dcdcfb 100644
> --- a/xen/include/asm-arm/alternative.h
> +++ b/xen/include/asm-arm/alternative.h
> @@ -160,7 +160,7 @@ static inline void apply_alternatives_all(void)
> {
> }
>
> -static inline int apply_alternatives(void *start, size_t lenght)
> +static inline int apply_alternatives(void *start, size_t length)
> {
> return 0;
> }
> --
> 1.9.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix mispelling of length
2017-02-02 20:42 [PATCH] Fix mispelling of length Julien Grall
2017-02-02 22:58 ` Stefano Stabellini
@ 2017-02-03 11:23 ` Wei Liu
2017-02-03 15:25 ` Dario Faggioli
2017-02-03 15:46 ` Wei Liu
3 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2017-02-03 11:23 UTC (permalink / raw)
To: Julien Grall
Cc: sstabellini, Wei Liu, George Dunlap, Dario Faggioli, Ian Jackson,
xen-devel
On Thu, Feb 02, 2017 at 08:42:44PM +0000, Julien Grall wrote:
> There are quite a few usage of "lenght" instead of "length" in different
> part of the repo. Correct it once for all.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix mispelling of length
2017-02-02 20:42 [PATCH] Fix mispelling of length Julien Grall
2017-02-02 22:58 ` Stefano Stabellini
2017-02-03 11:23 ` Wei Liu
@ 2017-02-03 15:25 ` Dario Faggioli
2017-02-03 15:46 ` Wei Liu
3 siblings, 0 replies; 5+ messages in thread
From: Dario Faggioli @ 2017-02-03 15:25 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: George Dunlap, Wei Liu, sstabellini, Ian Jackson
[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]
On Thu, 2017-02-02 at 20:42 +0000, Julien Grall wrote:
> There are quite a few usage of "lenght" instead of "length" in
> different
> part of the repo.
>
Most of which, in code I wrote! :-/
> Correct it once for all.
>
Thanks. :-)
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix mispelling of length
2017-02-02 20:42 [PATCH] Fix mispelling of length Julien Grall
` (2 preceding siblings ...)
2017-02-03 15:25 ` Dario Faggioli
@ 2017-02-03 15:46 ` Wei Liu
3 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2017-02-03 15:46 UTC (permalink / raw)
To: Julien Grall
Cc: sstabellini, Wei Liu, George Dunlap, Dario Faggioli, Ian Jackson,
xen-devel
On Thu, Feb 02, 2017 at 08:42:44PM +0000, Julien Grall wrote:
> There are quite a few usage of "lenght" instead of "length" in different
> part of the repo. Correct it once for all.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-03 15:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-02 20:42 [PATCH] Fix mispelling of length Julien Grall
2017-02-02 22:58 ` Stefano Stabellini
2017-02-03 11:23 ` Wei Liu
2017-02-03 15:25 ` Dario Faggioli
2017-02-03 15:46 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).