Re: [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1898 bytes --]

On Wed, 2017-02-08 at 14:51 +0000, George Dunlap wrote:
> Callers to libxl_cpupool_create() can either request a specific pool
> id, or request that Xen do it for them.  But at the moment, the
> "automatic" selection is indicated by using a magic value, 0.  This
> is
> undesirable both because it doesn't obviously have meaning, but also
> because '0' is a valid cpupool (albeit one which at the moment can't
> be changed).
> 
> Introduce a constant, LIBXL_CPUPOOL_POOLID_ANY, to indicate this
> instead.  Still accept '0' as meaning "ANY" for backwards
> compatibility.
> 
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

With one remark.

> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -2086,6 +2086,12 @@ int libxl_tmem_shared_auth(libxl_ctx *ctx,
> uint32_t domid, char* uuid,
>  int libxl_tmem_freeable(libxl_ctx *ctx);
>  
>  int libxl_get_freecpus(libxl_ctx *ctx, libxl_bitmap *cpumap);
> +
> +/* 
> + * Set poolid to LIBXL_CPUOOL_POOLID_ANY to have Xen choose a
> + * free poolid for you.
> + */
> +#define LIBXL_CPUPOOL_POOLID_ANY 0xFFFFFFFF
>
Do we want this to be here, or in libxl_types.idl.

Asking because, AFAICT, it's the only one LIBXL_FOO_BAR defined like
this. I appreciate that there's few point in making this an enum, as it
is only one value, and will most likely remain so, but still, I thought
I'd at least bring this up.

FWIW, my Reviewed-by stands both if it is kept as is, and if it is
moved to IDL.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel