From: David Woodhouse <dwmw2@infradead.org>
To: Jan Beulich <JBeulich@suse.com>, Chao Gao <chao.gao@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@arm.com>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t
Date: Thu, 09 Feb 2017 09:01:14 +0000 [thread overview]
Message-ID: <1486630874.5110.185.camel@infradead.org> (raw)
In-Reply-To: <589C3CBE020000780013814A@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 961 bytes --]
On Thu, 2017-02-09 at 01:56 -0700, Jan Beulich wrote:
>
> > diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c
> > index 86c71be..3d9386a 100644
> > --- a/xen/arch/x86/hvm/mtrr.c
> > +++ b/xen/arch/x86/hvm/mtrr.c
> > @@ -784,6 +784,8 @@ int epte_get_entry_emt(struct domain *d, unsigned long gfn,
> >
> > if ( direct_mmio )
> > {
> > + ASSERT(direct_mmio == is_iomem_page(mfn));
> > +
> > if ( (mfn_x(mfn) ^ d->arch.hvm_domain.vmx.apic_access_mfn) >> order )
> > return MTRR_TYPE_UNCACHABLE;
> > if ( order )
> >
> > But when I try to create a hvm domain, it failed. logs are below.
>
> Considering the context of the change above, I'm not surprised:
> You've very likely hit the APIC access MFN.
You'll probably hit it for INVALID_MFN too on an unmap. And *do* make
it print the offending address when it triggers. :)
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-02-09 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 13:55 [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t Andrew Cooper
2017-02-06 14:02 ` Julien Grall
2017-02-06 14:11 ` George Dunlap
2017-02-06 14:26 ` Jan Beulich
2017-02-06 14:48 ` David Woodhouse
2017-02-06 15:38 ` Jan Beulich
2017-02-08 7:31 ` Tian, Kevin
2017-02-08 17:05 ` Jan Beulich
2017-02-09 8:27 ` Chao Gao
2017-02-09 8:56 ` Jan Beulich
2017-02-09 3:54 ` Chao Gao
2017-02-09 11:10 ` David Woodhouse
2017-02-09 9:01 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486630874.5110.185.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).