From: Paul Durrant <paul.durrant@citrix.com>
To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Paul Durrant <paul.durrant@citrix.com>
Subject: [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs
Date: Thu, 9 Feb 2017 14:17:44 +0000 [thread overview]
Message-ID: <1486649866-4869-2-git-send-email-paul.durrant@citrix.com> (raw)
In-Reply-To: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com>
The code goes so far as to set the default return code to -ENOSYS but
then overrides this to -EINVAL in the switch() statement's default
case.
This patch removes this pointless and incorrect override.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
---
drivers/xen/privcmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 6e3306f..b4e5e27 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file,
break;
default:
- ret = -EINVAL;
break;
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-09 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 14:17 [PATCH 0/3] xen/privcmd: support for dm_op and restriction Paul Durrant
2017-02-09 14:17 ` Paul Durrant [this message]
2017-02-09 14:40 ` [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Jan Beulich
[not found] ` <589C8D610200007800138429@prv-mh.provo.novell.com>
2017-02-09 15:26 ` Boris Ostrovsky
2017-02-09 15:28 ` Paul Durrant
2017-02-09 14:17 ` [PATCH 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant
2017-02-09 14:17 ` [PATCH 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT Paul Durrant
2017-02-09 14:43 ` Jan Beulich
[not found] ` <589C8E1D0200007800138448@prv-mh.provo.novell.com>
2017-02-09 14:45 ` Paul Durrant
[not found] ` <1486649866-4869-3-git-send-email-paul.durrant@citrix.com>
2017-02-09 14:27 ` [PATCH 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant
[not found] ` <8ef1299559e24d96ba8bbab49baee5ae@AMSPEX02CL03.citrite.net>
2017-02-09 15:50 ` Boris Ostrovsky
[not found] ` <fa41f70e-d98c-dda7-cc7b-1152c438d4e5@oracle.com>
2017-02-09 15:56 ` Andrew Cooper
2017-02-09 16:03 ` Jan Beulich
2017-02-09 16:08 ` Andrew Cooper
2017-02-09 16:45 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486649866-4869-2-git-send-email-paul.durrant@citrix.com \
--to=paul.durrant@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).