From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: "JBeulich@suse.com" <JBeulich@suse.com>
Cc: Sergey Dyasli <sergey.dyasli@citrix.com>,
Kevin Tian <kevin.tian@intel.com>,
"Kevin.Mayer@gdata.de" <Kevin.Mayer@gdata.de>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Anshul Makkar <anshul.makkar@citrix.com>,
"jun.nakajima@intel.com" <jun.nakajima@intel.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] VMX: fix VMCS race on context-switch paths
Date: Wed, 15 Feb 2017 14:55:12 +0000 [thread overview]
Message-ID: <1487170512.3588.9.camel@citrix.com> (raw)
In-Reply-To: <58A463BA020000780013A37D@prv-mh.provo.novell.com>
On Wed, 2017-02-15 at 06:20 -0700, Jan Beulich wrote:
> > > > On 15.02.17 at 11:27, <sergey.dyasli@citrix.com> wrote:
> >
> > This is what I'm getting during the original test case (32 VMs reboot):
> >
> > (XEN) [ 1407.789329] Watchdog timer detects that CPU12 is stuck!
> > (XEN) [ 1407.795726] ----[ Xen-4.6.1-xs-local x86_64 debug=n Not tainted ]----
>
> Hmm, this was with a non-debug build, so the ASSERT() in
> vmx_vmcs_reload() was a no-op, yet it would have been useful
> to know whether active_cpu was -1 when getting stuck here.
> Btw - there was no nested virt in the picture in your try, was
> there?
No nested virt is involved in the test case.
Is it worth giving your patch another try with removing ctxt_switch_same()
since we figured out that vmx_do_resume() will reload vmcs either way?
And I will also update vmx_vmcs_reload() from your last email.
--
Thanks,
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-15 14:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 10:23 [PATCH 0/2] x86: context switch handling adjustments Jan Beulich
2017-02-14 10:28 ` [PATCH 1/2] VMX: fix VMCS race on context-switch paths Jan Beulich
2017-02-14 15:16 ` Andrew Cooper
2017-02-15 8:37 ` Jan Beulich
2017-02-15 11:29 ` Andrew Cooper
2017-02-15 10:27 ` Sergey Dyasli
2017-02-15 11:00 ` Jan Beulich
2017-02-15 11:13 ` Sergey Dyasli
2017-02-15 11:24 ` Jan Beulich
2017-02-15 11:39 ` Jan Beulich
2017-02-15 11:48 ` Sergey Dyasli
2017-02-15 11:55 ` Jan Beulich
2017-02-15 13:03 ` Jan Beulich
2017-02-15 13:40 ` Sergey Dyasli
2017-02-15 14:29 ` Jan Beulich
2017-02-15 14:44 ` Jan Beulich
2017-02-15 13:20 ` Jan Beulich
2017-02-15 14:55 ` Sergey Dyasli [this message]
2017-02-15 15:15 ` Jan Beulich
2017-02-16 8:29 ` Sergey Dyasli
2017-02-16 9:26 ` Jan Beulich
2017-02-14 10:29 ` [PATCH 2/2] x86: package up context switch hook pointers Jan Beulich
2017-02-14 15:26 ` Andrew Cooper
2017-02-15 8:42 ` Jan Beulich
2017-02-15 11:34 ` Andrew Cooper
2017-02-15 11:40 ` Jan Beulich
2017-02-14 22:18 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487170512.3588.9.camel@citrix.com \
--to=sergey.dyasli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=Kevin.Mayer@gdata.de \
--cc=anshul.makkar@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).