xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 06/11] xen/arm: vpl011: Add a new pl011 uart node in the guest DT in the toolstack
Date: Tue, 21 Feb 2017 16:56:03 +0530	[thread overview]
Message-ID: <1487676368-22356-7-git-send-email-bhupinder.thakur@linaro.org> (raw)
In-Reply-To: <1487676368-22356-1-git-send-email-bhupinder.thakur@linaro.org>

Add a new pl011 uart node
    - Get the pl011 spi virq from Xen using a hvm call
    - Add a new device tree node in the guest DT for SBSA pl011 uart containing the IRQ
      (read above) and the MMIO address range to be used by the guest

The format for the node is specified in Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt.

Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
---
 tools/libxl/libxl_arm.c | 47 +++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 45 insertions(+), 2 deletions(-)

diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c
index d842d88..34c7e39 100644
--- a/tools/libxl/libxl_arm.c
+++ b/tools/libxl/libxl_arm.c
@@ -130,9 +130,10 @@ static struct arch_info {
     const char *guest_type;
     const char *timer_compat;
     const char *cpu_compat;
+    const char *uart_compat;
 } arch_info[] = {
-    {"xen-3.0-armv7l",  "arm,armv7-timer", "arm,cortex-a15" },
-    {"xen-3.0-aarch64", "arm,armv8-timer", "arm,armv8" },
+    {"xen-3.0-armv7l",  "arm,armv7-timer", "arm,cortex-a15", "arm,sbsa-uart" },
+    {"xen-3.0-aarch64", "arm,armv8-timer", "arm,armv8", "arm,sbsa-uart" },
 };
 
 /*
@@ -590,6 +591,38 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+static int make_vpl011_uart_node(libxl__gc *gc, void *fdt,
+                           const struct arch_info *ainfo,
+                           struct xc_dom_image *dom, uint64_t irq)
+{
+    int res;
+    gic_interrupt intr;
+
+    res = fdt_begin_node(fdt, "sbsa-pl011");
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, ainfo->uart_compat);
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, ROOT_ADDRESS_CELLS, ROOT_SIZE_CELLS,
+                            1,
+                            GUEST_PL011_BASE, GUEST_PL011_SIZE);
+    if (res) 
+        return res;
+
+    set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
+
+    res = fdt_property_interrupts(gc, fdt, &intr, 1);
+    if (res) return res;
+
+    fdt_property_u32(fdt, "current-speed", 115200);
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -790,6 +823,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
     int rc, res;
     size_t fdt_size = 0;
     int pfdt_size = 0;
+    uint64_t vpl011_irq=0;
 
     const libxl_version_info *vers;
     const struct arch_info *ainfo;
@@ -889,6 +923,13 @@ next_resize:
         FDT( make_timer_node(gc, fdt, ainfo, xc_config->clock_frequency) );
         FDT( make_hypervisor_node(gc, fdt, vers) );
 
+        /* 
+         * get the vpl011 VIRQ and use it for creating a vpl011 node entry
+         */
+        if ( !xc_hvm_param_get(dom->xch, dom->guest_domid, HVM_PARAM_VPL011_VIRQ, 
+                                                               &vpl011_irq) )
+            FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom, vpl011_irq) );
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
@@ -933,9 +974,11 @@ int libxl__arch_domain_init_hw_description(libxl__gc *gc,
     val |= GUEST_EVTCHN_PPI;
     rc = xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CALLBACK_IRQ,
                           val);
+
     if (rc)
         return rc;
 
+
     rc = libxl__prepare_dtb(gc, info, state, dom);
     if (rc) goto out;
 
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-02-21 11:26 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 11:25 [PATCH 00/11] pl011 emulation support in Xen Bhupinder Thakur
2017-02-21 11:25 ` [PATCH 01/11] xen/arm: vpl011: Add pl011 uart emulation " Bhupinder Thakur
2017-02-26 21:37   ` Julien Grall
2017-03-03 19:19     ` Julien Grall
2017-03-21 13:27     ` Bhupinder Thakur
2017-03-21 19:38       ` Julien Grall
2017-03-23  9:44         ` Bhupinder Thakur
2017-03-23 13:51           ` Julien Grall
2017-03-03 19:59   ` Konrad Rzeszutek Wilk
2017-03-05  1:04     ` Julien Grall
2017-03-06 14:22       ` Konrad Rzeszutek Wilk
2017-03-05  1:15     ` Julien Grall
2017-03-05 11:59     ` Julien Grall
2017-03-22  5:50     ` Bhupinder Thakur
2017-03-05 12:12   ` Julien Grall
2017-03-23  9:14     ` Bhupinder Thakur
2017-03-23 14:16       ` Julien Grall
2017-03-24 10:39         ` Bhupinder Thakur
2017-02-21 11:25 ` [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup Bhupinder Thakur
2017-03-03 20:02   ` Konrad Rzeszutek Wilk
2017-03-24  6:58     ` Bhupinder Thakur
2017-03-05 12:35   ` Julien Grall
2017-03-06  8:06     ` Jan Beulich
2017-03-06 11:42       ` Julien Grall
2017-03-06 12:41         ` Jan Beulich
2017-03-06 13:21           ` Julien Grall
2017-03-06 13:48             ` Jan Beulich
2017-03-08 14:45               ` Julien Grall
2017-03-08 15:21                 ` Jan Beulich
2017-03-08 18:22                   ` Stefano Stabellini
2017-04-11 14:38                     ` Bhupinder Thakur
2017-04-11 22:07                       ` Stefano Stabellini
2017-04-14  7:12                         ` Bhupinder Thakur
2017-04-19 18:43                           ` Stefano Stabellini
2017-03-06 14:48             ` George Dunlap
2017-03-08 13:52               ` Julien Grall
2017-03-24  7:31     ` Bhupinder Thakur
2017-02-21 11:26 ` [PATCH 03/11] xen/arm: vpl011: Refactor evtchn_send in Xen to allow sending events from a xen bound channel Bhupinder Thakur
2017-03-03 21:13   ` Konrad Rzeszutek Wilk
2017-03-06 10:16     ` Bhupinder Thakur
2017-03-06 10:35       ` Jan Beulich
2017-03-05 12:39   ` Julien Grall
2017-03-06  8:15     ` Jan Beulich
2017-03-06 10:44       ` Bhupinder Thakur
2017-03-06 10:54         ` Jan Beulich
2017-03-06 11:12           ` Bhupinder Thakur
2017-03-28  9:43             ` Bhupinder Thakur
2017-02-21 11:26 ` [PATCH 04/11] xen/arm: vpl011: Enable vpl011 emulation for a domain in Xen Bhupinder Thakur
2017-03-03 21:47   ` Konrad Rzeszutek Wilk
2017-03-05 12:46   ` Julien Grall
2017-03-06  8:27     ` Jan Beulich
2017-02-21 11:26 ` [PATCH 05/11] xen/arm: vpl011: Initialize nr_spis in vgic_init in Xen to atleast 1 Bhupinder Thakur
2017-03-03 20:49   ` Konrad Rzeszutek Wilk
2017-03-05 12:51   ` Julien Grall
2017-03-16  6:50     ` Bhupinder Thakur
2017-03-16  8:24       ` Julien Grall
2017-03-16 10:31         ` Bhupinder Thakur
2017-03-16 13:24           ` Julien Grall
2017-03-20 16:29             ` Bhupinder Thakur
2017-02-21 11:26 ` Bhupinder Thakur [this message]
2017-03-03 20:15   ` [PATCH 06/11] xen/arm: vpl011: Add a new pl011 uart node in the guest DT in the toolstack Konrad Rzeszutek Wilk
2017-03-03 21:03   ` Konrad Rzeszutek Wilk
2017-03-05 12:59     ` Julien Grall
2017-03-05 13:04   ` Julien Grall
2017-03-14 13:00     ` Wei Liu
2017-02-21 11:26 ` [PATCH 07/11] xen/arm: vpl011: Add two new vpl011 parameters to xenstore Bhupinder Thakur
2017-03-03 20:58   ` Konrad Rzeszutek Wilk
2017-03-28  7:49     ` Bhupinder Thakur
2017-02-21 11:26 ` [PATCH 08/11] xen/arm: vpl011: Allocate a new PFN in the toolstack and pass to Xen using a hvm call Bhupinder Thakur
2017-03-03 20:51   ` Konrad Rzeszutek Wilk
2017-03-05 13:07     ` Julien Grall
2017-02-21 11:26 ` [PATCH 09/11] xen/arm: vpl011: Modify domain_create_ring in xenconsole to map the ring buffer and event channel Bhupinder Thakur
2017-03-03 21:46   ` Konrad Rzeszutek Wilk
2017-02-21 11:26 ` [PATCH 10/11] xen/arm: vpl011: Modify handle_ring_read and buffer_append to read/append vpl011 data Bhupinder Thakur
2017-03-03 21:06   ` Konrad Rzeszutek Wilk
2017-02-21 11:26 ` [PATCH 11/11] xen/arm: vpl011: Modify handle_tty_read in xenconsole to redirect user data to vpl011 IN ring buffer Bhupinder Thakur
2017-03-03 21:17   ` Konrad Rzeszutek Wilk
2017-03-03 20:23 ` [PATCH 00/11] pl011 emulation support in Xen Konrad Rzeszutek Wilk
2017-03-03 21:15   ` Konrad Rzeszutek Wilk
2017-03-14  7:44   ` Bhupinder Thakur
2017-03-05 11:46 ` Julien Grall
2017-03-14  7:47   ` Bhupinder Thakur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487676368-22356-7-git-send-email-bhupinder.thakur@linaro.org \
    --to=bhupinder.thakur@linaro.org \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).