[PATCH] iommu: Elaborate the usage of RMRR specification on the command line.

[PATCH] iommu: Elaborate the usage of RMRR specification on the command line.

[Venu Busireddy]

As some users have suggested, elaborate the usage of RMRR specification
on the command line, and provide a usage example.

Signed-off-by: Venu Busireddy <venu.busireddy@oracle.com>
---
 docs/misc/xen-command-line.markdown |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
index 3acbb33..77e0a20 100644
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -1406,6 +1406,15 @@ If segment of the first device is not specified, segment zero will be used.
 If other segments are not specified, first device segment will be used.
 If a segment is specified for other than the first device and it does not match
 the one specified for the first one, an error will be reported.
+
+'start' and 'end' values are page numbers (not full physical addresses).
+If the values are not preceded by "0x", they are treated as decimal.
+
+Usage example: If there are two devices 0:0:1d.0 and 0:0:1a.0 that require
+pages 0xd5d45 and 0xd5d46 to be reserved respectively, use:
+
+rmrr=0xd5d45=0:0:1d.0;0xd5d46=0:0:1a.0
+
 Note: grub2 requires to escape or use quotations if special characters are used,
 namely ';', refer to the grub2 documentation if multiple ranges are specified.
 
-- 
1.7.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] iommu: Elaborate the usage of RMRR specification on the command line.

[Jan Beulich]

>>> On 21.02.17 at 21:42, <venu.busireddy@oracle.com> wrote:
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1406,6 +1406,15 @@ If segment of the first device is not specified, segment zero will be used.
>  If other segments are not specified, first device segment will be used.
>  If a segment is specified for other than the first device and it does not match
>  the one specified for the first one, an error will be reported.
> +
> +'start' and 'end' values are page numbers (not full physical addresses).
> +If the values are not preceded by "0x", they are treated as decimal.

Actually I think we should fix the code. I can't see how decimal
numbers can be useful here, and it is actively confusing with ...

> +Usage example: If there are two devices 0:0:1d.0 and 0:0:1a.0 that require
> +pages 0xd5d45 and 0xd5d46 to be reserved respectively, use:
> +
> +rmrr=0xd5d45=0:0:1d.0;0xd5d46=0:0:1a.0

... the PCI device being specified without 0x prefixes.

Also can one of the two parts of the example be a range, please?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] iommu: Elaborate the usage of RMRR specification on the command line.

[Venu Busireddy]

On Wed, Feb 22, 2017 at 01:52:02AM -0700, Jan Beulich wrote:
> >>> On 21.02.17 at 21:42, <venu.busireddy@oracle.com> wrote:
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -1406,6 +1406,15 @@ If segment of the first device is not specified, segment zero will be used.
> >  If other segments are not specified, first device segment will be used.
> >  If a segment is specified for other than the first device and it does not match
> >  the one specified for the first one, an error will be reported.
> > +
> > +'start' and 'end' values are page numbers (not full physical addresses).
> > +If the values are not preceded by "0x", they are treated as decimal.
> 
> Actually I think we should fix the code. I can't see how decimal
> numbers can be useful here, and it is actively confusing with ...

Fixed. I will post v2 for review.

> > +Usage example: If there are two devices 0:0:1d.0 and 0:0:1a.0 that require
> > +pages 0xd5d45 and 0xd5d46 to be reserved respectively, use:
> > +
> > +rmrr=0xd5d45=0:0:1d.0;0xd5d46=0:0:1a.0
> 
> ... the PCI device being specified without 0x prefixes.
> 
> Also can one of the two parts of the example be a range, please?

This too is done. v2 will be posted for review.

Venu


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel