From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 04/10] xen: credit2: make accessor helpers inline functions instead of macros Date: Fri, 24 Feb 2017 19:26:38 +0100 Message-ID: <1487960798.5548.55.camel@citrix.com> References: <148664844741.595.10506268024432565895.stgit@Solace.fritz.box> <148664872587.595.4960352148914014602.stgit@Solace.fritz.box> <589C8C740200007800138423@prv-mh.provo.novell.com> <1486654380.3042.39.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5185582480944717706==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chKa3-0001gj-M9 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2017 18:26:59 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: xen-devel , Anshul Makkar , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============5185582480944717706== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-IwtPFqiKd6Xe0YPT/HBr" --=-IwtPFqiKd6Xe0YPT/HBr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-02-15 at 10:49 +0000, George Dunlap wrote: > On Thu, Feb 9, 2017 at 3:33 PM, Dario Faggioli > wrote: > > On Thu, 2017-02-09 at 07:36 -0700, Jan Beulich wrote: > > Nope. I'll get rid of them from above. > > > Also I'm not sure whether the sched*.c files are an exception, > > > but > > > generally we don't use plain "unsigned" but always "unsigned > > > int". > > >=20 > > Yes, in sched_credit.c and sched_credit2.c there are a few > > unsigned. > > But I'm happy to use "unsigned int" for new code, such as here. >=20 > FWIW I agree with Andy and Jan's comments.=C2=A0=C2=A0Everything else loo= ks > good to me. >=20 Err... So, I removed the pointless parentheses and I turned "unsigned" to "unsigned int". As per consts, I agree with Jan, and hence I added the qualifier to the pointer arguments of csched2_dom() and csched2_vcpu(), as he suggested, without changing the return type. And I'm also using plain 'inline' rather than 'always_inline'. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-IwtPFqiKd6Xe0YPT/HBr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYsHreAAoJEBZCeImluHPuqqMQAMa92S/MGQFBAyf9N5phiBlv etT15NkBn1OAJckwDUt0ewxz5p2qRIpVoN9wAw2EeQa7Y8rBZoMiP540qan8RNiQ G2TlYwM88b9FzPS7m6oWir4UV8pFzAtlrFtT9YWxfHXxx4Fq39pGiKJTrdg482bw 5wufvL6jUtR69uWF6CfszpUWWm1ojLuRhDq+NaW1wcg6Vpqgc/V9GwGfwDBXeLBR fBVXYax9apDO2vKhqV9mdT44GLZq1WoS7NNriR/wVWH7QQGKQXdQFF54LVDfcBE8 vl2rm+uTBBwitszmZZgysq5ALA9LEYKnjPdcSEZ0qtLyQSOSh4juIJ8VFDYjISoH OGysaiTRKZYDYH1Zek/HPzi8Xb6RW8LZUd3kNask6Bw7xKzd+egbcLVrTK9ja8Eg ig106buxM4VDaCbqfMsCqCMTUfOnm6vGjLdJ/n33WlO0XhMSVi/erl8Fpk/IXMiX nCMuKDh0c8aClBmY3QTahPQDJIml/ZZJWQN5IWXuL/7QglDRbn+AfvgUP27fojk3 T5SsMT6X1UeQKzFy71uwnK1IL/H63938wMcKjvUgehErMrfsTJ+DdHTA5BHRMMK5 ESE8YHMp3GUtAQ4Gutj5FICw/b3JhLC744/Wc8zh19ERAkIdGo0AtSqQEy4bQ/DC tUZtaG02xdVJmxWvMto9 =84rz -----END PGP SIGNATURE----- --=-IwtPFqiKd6Xe0YPT/HBr-- --===============5185582480944717706== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5185582480944717706==--