From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 05/10] xen: credit2: tidy up functions names by removing leading '__'. Date: Fri, 24 Feb 2017 19:32:39 +0100 Message-ID: <1487961159.5548.58.camel@citrix.com> References: <148664844741.595.10506268024432565895.stgit@Solace.fritz.box> <148664873298.595.10572842930927793747.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6662986584661928851==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chKfe-0002Jg-EF for xen-devel@lists.xenproject.org; Fri, 24 Feb 2017 18:32:46 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: xen-devel , Anshul Makkar List-Id: xen-devel@lists.xenproject.org --===============6662986584661928851== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-InqXMmlwv65obnmMOMP5" --=-InqXMmlwv65obnmMOMP5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-02-15 at 13:57 +0000, George Dunlap wrote: > On Thu, Feb 9, 2017 at 1:58 PM, Dario Faggioli > wrote: > >=C2=A0 > > Signed-off-by: Dario Faggioli >=20 > Acked-by: George Dunlap >=20 Thanks. > With one comment... >=20 > > diff --git a/xen/common/sched_credit2.c > > b/xen/common/sched_credit2.c > > index 786dcca..4b4f4f8 100644 > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -594,14 +594,12 @@ static s_time_t c2t(struct > > csched2_runqueue_data *rqd, s_time_t credit, struct c > > =C2=A0 * Runqueue related code > > =C2=A0 */ > >=20 > > -static /*inline*/ int > > -__vcpu_on_runq(struct csched2_vcpu *svc) > > +static inline int vcpu_on_runq(struct csched2_vcpu *svc) > > =C2=A0{ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return !list_empty(&svc->runq_elem); > > =C2=A0} > >=20 > > -static /*inline*/ struct csched2_vcpu * > > -__runq_elem(struct list_head *elem) > > +static struct csched2_vcpu * runq_elem(struct list_head *elem) > > =C2=A0{ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return list_entry(elem, struct csched2_vc= pu, runq_elem); > > =C2=A0} >=20 > Would it make sense to make this inline as well? >=20 Absolutely (not sure why it wasn't! :-P) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-InqXMmlwv65obnmMOMP5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYsHxHAAoJEBZCeImluHPuSN4P/2cSzor6xV/5R65y/gtKEBnx En0lTGIrk6ioSpchTELZltJjCZ8pomRLL+vKgmi4ZP/nbeEoIdF1QVZB/ekmZ+lz S+p+Dsic8wFk6XHcZHqwWkJ9/DPhELRqtPZGCn7930b27f8KU+sG6bKS0TPyHfSS HB4BL9KGFOstajwZI58pubocW8fdFhHADX2APi1QRZCPq4bbTGFP80kn3Gd2MtwG JKZtzjXc+49PAgVTNfNe8rk9eZ0ooGYaP9NfNRixtSSug6eL1zQ9QBW8RSipvniJ LOqtYmRhUnXYn8kjfr2M0nX7SYw+zXem2o2vqWYps/iQBaWIzbgvJ4XRiAGjgOmh kMTWAO5CU9slB2D/lzO4r1UsghWbgEOXP2ZexCXeQEWCLboXd7xVpQIWWJWm8Pfw xVnbO3PMy2ceRlcoqJzoruDam1o5gs1XsypRpd6/J482AiezmfLg+mQhC9MVkiBo TTLcfOCZQ31X+yPqQM+LRPMaPK0jd3+k2fGn+JWDf1pah18Qpq03GGB3mYQbIinA ZVZKCMovpmxzrOqJLfxFEB/75mfT0H2+ccRYZ1OjLskbF5Z+wARWWXaBagknZ4JN hCpIGJThv1b1sN+oIgrZL2RNr7FJt+YIUVtLICwhsWdu2HgXexVIT4SNc3MC2wWD p5gU0HC+DBtFHBOHDKLy =AVrH -----END PGP SIGNATURE----- --=-InqXMmlwv65obnmMOMP5-- --===============6662986584661928851== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============6662986584661928851==--