From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: RFC/PATCH: xen: race during domain destruction [Re: [xen-4.7-testing test] 105948: regressions - FAIL] Date: Mon, 27 Feb 2017 16:18:33 +0100 Message-ID: <1488208713.5548.87.camel@citrix.com> References: <4b6337e3-74b3-8ecd-d7a6-aa8a451fb8d3@citrix.com> <58AD5DDA020000780013C9ED@prv-mh.provo.novell.com> <1487952877.5548.26.camel@citrix.com> <1488124383.5548.72.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9205234745644789936==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciN4T-00031A-DU for xen-devel@lists.xenproject.org; Mon, 27 Feb 2017 15:18:41 +0000 In-Reply-To: <1488124383.5548.72.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , xen-devel , Andrew Cooper , osstest service owner , Juergen Gross List-Id: xen-devel@lists.xenproject.org --===============9205234745644789936== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-gy3iLEx7rnPo7y6WZsyH" --=-gy3iLEx7rnPo7y6WZsyH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2017-02-26 at 16:53 +0100, Dario Faggioli wrote: > On Fri, 2017-02-24 at 17:14 +0100, Dario Faggioli wrote: > > On Wed, 2017-02-22 at 01:46 -0700, Jan Beulich wrote: > > >=20 > > > However, comparing with the staging version of the file > > > (which is heavily different), the immediate code involved here > > > isn't > > > all that different, so I wonder whether (a) this is a problem on > > > staging too or (b) we're missing another backport. Dario? > > >=20 > > So, according to my investigation, this is a genuine race. It > > affects > > this branch as well as staging, but it manifests less frequently > > (or, > > I > > should say, very rarely) in the latter. > >=20 > Actually, this is probably wrong. It looks like the following commit: >=20 > =C2=A0f3d47501db2b7bb8dfd6a3c9710b7aff4b1fc55b > =C2=A0xen: fix a (latent) cpupool-related race during domain destroy >=20 > is not in staging-4.7. >=20 And my testing confirms that backporting the changeset above (which just applies cleanly on staging-4.7, AFAICT) make the problem go away. As the changelog of that commit says, I've even seen something similar happening already during my development... Sorry I did not recognise it sooner, and for failing to request backport of that change in the first place. I'm therefore doing that now: I ask for backport of: =C2=A0f3d47501db2b7bb8dfd6a3c9710b7aff4b1fc55b =C2=A0xen: fix a (latent) cpupool-related race during domain destroy to 4.7. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-gy3iLEx7rnPo7y6WZsyH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYtENJAAoJEBZCeImluHPublEP/RHDM0pIleFPmCMzN5j/9i1G 6P2tTRw41ZJOaODHL84N+1kUY8srTF6WHaIyujtRluU4kdHdZvsRYU8SmScCcJKT uJZ4i+RuUCBlbH9eD52JbyGBwdSy6GMgQD/LErsIfpaEsWz1tX2ElFEw2JiUkXYj Z8uRlPI9iV2iQIsFj9rqoCc4H2tm372ULfjraclRIsYr/6jlkXUOy/uE1UzqCz0w +9VLaDK9UStjsVaqsxsKddlm5D1nxN8TUlKdGmbGj86N3S+jNizizDwjn4MUPZUr bmf+JK1qyjTWxsYdqnnWXHaJ7PPqr6Kn818C4uJ4GP5+Jo7px26KKDsrF+Z0mUjQ vXdFTml4I92rm52h66J747zKE+LAORcyfqjvLKGkwQfwi65AerT1kOWigEGJ1GFI iiI3Ea60Bo4LxSVTU3Bu77eWMBHns9E5h+zI9nK3fIBHtX5YQ1JyawcSe03/LFX4 cv1NSUUxLkpyFDQeS/XYUCNi9UWSHsgDaf9BAkMLiB/4FOgZZGA6pVfuwFXZr4F7 15BFr6H++/yzBVZFNYgRSE6AqQ1gewi3haQel0pLBfTc+Eh3bB4v9o+fsAfixV/g wQFb2EGfNI+oJDJCqJ6OeQAI9WNHhShLprbdArTB+/jxiBJ13m8wYl4P/uHGM1OS 01S12DehRyIDPDBimd6a =zwOl -----END PGP SIGNATURE----- --=-gy3iLEx7rnPo7y6WZsyH-- --===============9205234745644789936== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============9205234745644789936==--