From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 06/10] xen: credit2: group the runq manipulating functions. Date: Mon, 27 Feb 2017 19:25:14 +0100 Message-ID: <1488219914.5548.101.camel@citrix.com> References: <148664844741.595.10506268024432565895.stgit@Solace.fritz.box> <148664874043.595.13837823575489312498.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0367723726693883505==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciPz7-0006eI-9T for xen-devel@lists.xenproject.org; Mon, 27 Feb 2017 18:25:21 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: xen-devel , Anshul Makkar List-Id: xen-devel@lists.xenproject.org --===============0367723726693883505== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-IR9BPUxf4eu5Yyfn3/TH" --=-IR9BPUxf4eu5Yyfn3/TH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-02-15 at 14:42 +0000, George Dunlap wrote: > Most of the motion makes sense, but moving the option parser along > too > seems a bit strange.=C2=A0=C2=A0Wouldn't it make more sense to leave it w= ith > the > other option parsers?=C2=A0=C2=A0 > Well, it's a runqueue related parameter, so it's runqueue related code, and this is why I moved it. _BUT_ after all, I think I agree with you. More specifically, I think that either all the option parser are in "sections" where they belong, depending on the option they take care of, or they all live together. So, yes, let's keep them together. I'll see about moving each one in a more specific place in the file and, if I decide to go for it, send a patch. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-IR9BPUxf4eu5Yyfn3/TH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYtG8KAAoJEBZCeImluHPuhLkP/jdIDGSkQs/3PZp3E0tWrdAk avbiIa7atu8c7ZJqFUWGWDUwrQqtsSxwO3v44r4Xf2W5H08hV2EOKFVOgeNCKpJn 0kh3qugJ00s6M4a0aYgPiyBdb7iyg9JWISfvLuzK7N1wQx+9IkRxDj7GtY56We5F l4hZ6ZoLqaGrmt8sZujQ1qf3+ND4pzsPuqJaHFdDnlsc4lD8MS/D6WW0lwDS89pz fqjsdm55iDG0iSKYvATZiOs87fXwJnRjx3gVGEnbZEvcSkHJAv/tAjFFQTVdTXd/ GGA4B1v5K6Ig9ocqqIOiJW7XfPWZ5oebCEjxwqX761tjvkJkCttRdslJ7Fyw6Edb x4XOApioIrhwHdGunrhZHGHiTA4vmTctrxycMnryiZKwuDyBiSz9/DSPHvk//Xqp +mbpBd0k2i7QeX3UinCu5+Lh8gkgt57Nw1RVjB4fm+Sp9poyESCg3Kf0N2Qo4WuI p8jpu6evJQ608Dsq/v1R16xmQIUVDKiLGIXGEWTlmOno6Ho7U533OSMLt0kR6c0r 1VuPjY9gtHsL9dw4i1n43vWOdVf/jjBFRjPx9m3e6Vjjf0Wn25VjdbljDofbmWYs +juNJ1rjHGm9CUvDGDXIPqw+5bBrWhTL7YcPgvc2G0C8cBcey+2e4aoNrnXH2pop wojzauYrmshTy44kyN5h =NnF7 -----END PGP SIGNATURE----- --=-IR9BPUxf4eu5Yyfn3/TH-- --===============0367723726693883505== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0367723726693883505==--