From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 3/7] xen: credit2: group the runq manipulating functions. Date: Tue, 28 Feb 2017 15:34:52 +0100 Message-ID: <1488292492.5548.110.camel@citrix.com> References: <148828109243.26730.2771577013485070217.stgit@Solace.fritz.box> <148828273740.26730.11398473846692932330.stgit@Solace.fritz.box> <7e680c0d-6ebe-9dc4-e20c-4a99d0356214@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4431451801136800202==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciisW-0003Ws-0B for xen-devel@lists.xenproject.org; Tue, 28 Feb 2017 14:35:48 +0000 In-Reply-To: <7e680c0d-6ebe-9dc4-e20c-4a99d0356214@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: George Dunlap , Anshul Makkar List-Id: xen-devel@lists.xenproject.org --===============4431451801136800202== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-MqiItkOJqOGAfbY6LiBK" --=-MqiItkOJqOGAfbY6LiBK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-02-28 at 13:55 +0000, Andrew Cooper wrote: > On 28/02/17 11:52, Dario Faggioli wrote: > >=20 > > +static inline bool_t same_node(unsigned int cpua, unsigned int > > cpub) >=20 > s/bool_t/bool/g >=20 Oh.. Yes, you're right. Sorry! > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0if ( unlikely(tb_init_done) ) > > +=C2=A0=C2=A0=C2=A0=C2=A0{ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0unsigned rqi:16, max_weight:16; >=20 > More commonly known as uint16_t :) >=20 Yeah, I know. :-) But tracing code in Credit2 is done like above everywhere, and while I see and agree on your point, I feel more comfortable in following suit. And anyway, I'm considering a follow-up cleanup where I'll get rid of all these 'if (tracing){...}' blocks, and substitute them with inline functions, and I can certainly do the type change there as well. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-MqiItkOJqOGAfbY6LiBK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYtYqNAAoJEBZCeImluHPuPBYQAKiGaXTT6f1tGH7CwvtG3ViD +fWkX9+XuegzqqkcGhtF9yEu/3f5rWQsrL7tNqsw6r65NkKHLUc31h78U+7EhSNZ AGeBmbwG8mdH0svFsbgbCUSzRI7rekxvZ+L2HVktNyP9qmRzp5ilDR9qf6/kS07+ uwxgBdxoJiLnDuBsvLkKjEveipZHGn5ec6HbfgBSC7NL9dBp9clRsxvKE6jTVTGe D/tM2L7+DGp2xd8rTfMhMJxLUDe/iHnRZr/4ZIiZ6tE9VdYydfpLF3RO1FxBAG9h Fw3t6jN49vGk4cb8pL99TNsd+bRBWNDI13ap/Uw9W0WnqGNS9bjYyJn3OQRAEBoz 25SwHUv14IE3fcoJ5EJg0V7kGkf6N0oLDa2p0jqetKwYjL4esK+sE+JKyTtr/N/O X0upvXy2GQ2dtaoQYJU1O14i30NqZcZcBjTFEV3/ZTbhJ75EFMWWtN+n5nZs3fI4 Qg74mh4X6FAGZUb9FOs4sXfws5Qaq3tgUOyoX7Z4uazdg3ewges+zWdH/V6EYRJJ Vj0gQug7iy3k8Uz6dkOJOc+lZ/QEoycSt2LskTDIwPKAPsvghPgpQ+ezvnqZ1R7h QcrC2o28RtM1t+k3pZpY7JpPk7qEOCbkluRy64I6az5pZ+T0RyRoYbyLqqP8yNIZ b6Wyb0mnrSCAFX1/QN4t =MfjS -----END PGP SIGNATURE----- --=-MqiItkOJqOGAfbY6LiBK-- --===============4431451801136800202== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4431451801136800202==--