From: Dario Faggioli <dario.faggioli@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Anshul Makkar <anshul.makkar@citrix.com>
Subject: Re: [PATCH v3 3/7] xen: credit2: group the runq manipulating functions.
Date: Wed, 1 Mar 2017 14:03:51 +0100 [thread overview]
Message-ID: <1488373431.5548.134.camel@citrix.com> (raw)
In-Reply-To: <1488292492.5548.110.camel@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 830 bytes --]
On Tue, 2017-02-28 at 15:34 +0100, Dario Faggioli wrote:
> On Tue, 2017-02-28 at 13:55 +0000, Andrew Cooper wrote:
> > On 28/02/17 11:52, Dario Faggioli wrote:
> > > +static inline bool_t same_node(unsigned int cpua, unsigned int
> > > cpub)
> >
> > s/bool_t/bool/g
> >
> Oh.. Yes, you're right. Sorry!
>
Actually, I don't feel comfortable doing this either, not in this
patch, at least. This patch purely about code motion, and I want it to
stay that way.
What I can and will do, is to prepare a separate patch sanitizing
bool_t-s.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-01 13:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 11:51 [PATCH v3 0/7] xen: credit2: improve style, and tracing; fix two bugs Dario Faggioli
2017-02-28 11:52 ` [PATCH v3 1/7] xen: credit2: make accessor helpers inline functions instead of macros Dario Faggioli
2017-02-28 11:52 ` [PATCH v3 2/7] xen: credit2: tidy up functions names by removing leading '__' Dario Faggioli
2017-02-28 11:52 ` [PATCH v3 3/7] xen: credit2: group the runq manipulating functions Dario Faggioli
2017-02-28 13:55 ` Andrew Cooper
2017-02-28 14:34 ` Dario Faggioli
2017-03-01 13:03 ` Dario Faggioli [this message]
2017-02-28 11:52 ` [PATCH v3 4/7] xen: credit2: always mark a tickled pCPU as... tickled! Dario Faggioli
2017-03-01 9:35 ` Jan Beulich
2017-03-01 13:07 ` Dario Faggioli
2017-02-28 11:52 ` [PATCH v3 5/7] xen: credit2: don't miss accounting while doing a credit reset Dario Faggioli
2017-02-28 11:52 ` [PATCH v3 6/7] xen/tools: tracing: trace (Credit2) runq traversal Dario Faggioli
2017-02-28 11:52 ` [PATCH v3 7/7] xen/tools: tracing: Report next slice time when continuing as well as switching Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488373431.5548.134.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anshul.makkar@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).