From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v4 0/7] xen: credit2: improve style, and tracing; fix two bugs Date: Wed, 1 Mar 2017 16:34:59 +0100 Message-ID: <1488382499.5548.144.camel@citrix.com> References: <148837861276.11900.8292677471375175885.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6202923010649291561==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cj6HX-00030h-9c for xen-devel@lists.xenproject.org; Wed, 01 Mar 2017 15:35:11 +0000 In-Reply-To: <148837861276.11900.8292677471375175885.stgit@Solace.fritz.box> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============6202923010649291561== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-3mGIUHF2tGQVBruDBPFr" --=-3mGIUHF2tGQVBruDBPFr Content-Type: multipart/mixed; boundary="=-LABAbnYuUczIEhG+bcKs" --=-LABAbnYuUczIEhG+bcKs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-03-01 at 15:52 +0100, Dario Faggioli wrote: > Dario Faggioli (7): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0xen: credit2: always mark a tickled p= CPU as... tickled! > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0xen: credit2: don't miss accounting w= hile doing a credit reset. > And these two being bugfixes, I request them to be backported to Xen 4.7 (but not any further, as that would be difficult and pretty pointless). Since that isn't exactly trivial, especially for the first patch, I attach to this email what I actually propose to backport. I've successfully tested them on top of current tip of staging-4.7. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-LABAbnYuUczIEhG+bcKs Content-Disposition: attachment; filename="xen-credit2-always-mark.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="xen-credit2-always-mark.patch"; charset="UTF-8" Y29tbWl0IGViMGMxYjc3Y2M2NWFkNDBlZmQ2MTIzNGY4ZWIwZGM3M2NkODA2MzIKQXV0aG9yOiBE YXJpbyBGYWdnaW9saSA8ZGFyaW8uZmFnZ2lvbGlAY2l0cml4LmNvbT4KRGF0ZTogICBXZWQgTWFy IDEgMTY6MDA6NTMgMjAxNyArMDEwMAoKICAgIHhlbjogY3JlZGl0MjogYWx3YXlzIG1hcmsgYSB0 aWNrbGVkIHBDUFUgYXMuLi4gdGlja2xlZCEKICAgIAogICAgSW4gZmFjdCwgd2hldGhlciBvciBu b3QgYSBwQ1BVIGhhcyBiZWVuIHRpY2tsZWQsIGFuZCBpcwogICAgdGhlcmVmb3JlIGFib3V0IHRv IHJlLXNjaGVkdWxlLCBpcyBzb21ldGhpbmcgd2UgbG9vayBhdAogICAgYW5kIGJhc2UgZGVjaXNp b25zIG9uIGluIHZhcmlvdXMgcGxhY2VzLgogICAgCiAgICBTbywgbGV0J3MgbWFrZSBzdXJlIHRo YXQgd2UgZG8gdGhhdCBiYXNpbmcgb24gYWNjdXJhdGUKICAgIGluZm9ybWF0aW9uLgogICAgCiAg ICBTaWduZWQtb2ZmLWJ5OiBEYXJpbyBGYWdnaW9saSA8ZGFyaW8uZmFnZ2lvbGlAY2l0cml4LmNv bT4KCmRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYyBiL3hlbi9jb21tb24v c2NoZWRfY3JlZGl0Mi5jCmluZGV4IDM1ZGFkMTUuLmYxNGRjOWMgMTAwNjQ0Ci0tLSBhL3hlbi9j b21tb24vc2NoZWRfY3JlZGl0Mi5jCisrKyBiL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0Mi5jCkBA IC01NTksNiArNTU5LDEzIEBAIF9fcnVucV9yZW1vdmUoc3RydWN0IGNzY2hlZDJfdmNwdSAqc3Zj KQogCiB2b2lkIGJ1cm5fY3JlZGl0cyhzdHJ1Y3QgY3NjaGVkMl9ydW5xdWV1ZV9kYXRhICpycWQs IHN0cnVjdCBjc2NoZWQyX3ZjcHUgKiwgc190aW1lX3QpOwogCitzdGF0aWMgaW5saW5lIHZvaWQK K3RpY2tsZV9jcHUodW5zaWduZWQgaW50IGNwdSwgc3RydWN0IGNzY2hlZDJfcnVucXVldWVfZGF0 YSAqcnFkKQoreworICAgIGNwdW1hc2tfc2V0X2NwdShjcHUsICZycWQtPnRpY2tsZWQpOworICAg IGNwdV9yYWlzZV9zb2Z0aXJxKGNwdSwgU0NIRURVTEVfU09GVElSUSk7Cit9CisKIC8qIENoZWNr IHRvIHNlZSBpZiB0aGUgaXRlbSBvbiB0aGUgcnVucXVldWUgaXMgaGlnaGVyIHByaW9yaXR5IHRo YW4gd2hhdCdzCiAgKiBjdXJyZW50bHkgcnVubmluZzsgaWYgc28sIHdha2UgdXAgdGhlIHByb2Nl c3NvciAqLwogc3RhdGljIC8qaW5saW5lKi8gdm9pZApAQCAtNjYwLDkgKzY2Nyw4IEBAIHRpY2ts ZToKICAgICAgICAgICAgICAgICAgIHNpemVvZihkKSwKICAgICAgICAgICAgICAgICAgICh1bnNp Z25lZCBjaGFyICopJmQpOwogICAgIH0KLSAgICBjcHVtYXNrX3NldF9jcHUoaXBpZCwgJnJxZC0+ dGlja2xlZCk7CiAgICAgU0NIRURfU1RBVF9DUkFOSyh0aWNrbGVfaWRsZXJzX3NvbWUpOwotICAg IGNwdV9yYWlzZV9zb2Z0aXJxKGlwaWQsIFNDSEVEVUxFX1NPRlRJUlEpOworICAgIHRpY2tsZV9j cHUoaXBpZCwgcnFkKTsKIAogbm9fdGlja2xlOgogICAgIHJldHVybjsKQEAgLTEwMjcsNyArMTAz Myw3IEBAIGNzY2hlZDJfdmNwdV9zbGVlcChjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsIHN0 cnVjdCB2Y3B1ICp2YykKICAgICBTQ0hFRF9TVEFUX0NSQU5LKHZjcHVfc2xlZXApOwogCiAgICAg aWYgKCBjdXJyX29uX2NwdSh2Yy0+cHJvY2Vzc29yKSA9PSB2YyApCi0gICAgICAgIGNwdV9yYWlz ZV9zb2Z0aXJxKHZjLT5wcm9jZXNzb3IsIFNDSEVEVUxFX1NPRlRJUlEpOworICAgICAgICB0aWNr bGVfY3B1KHZjLT5wcm9jZXNzb3IsIHN2Yy0+cnFkKTsKICAgICBlbHNlIGlmICggX192Y3B1X29u X3J1bnEoc3ZjKSApCiAgICAgewogICAgICAgICBCVUdfT04oc3ZjLT5ycWQgIT0gUlFEKG9wcywg dmMtPnByb2Nlc3NvcikpOwpAQCAtMTMwOCw4ICsxMzE0LDggQEAgc3RhdGljIHZvaWQgbWlncmF0 ZShjb25zdCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsCiAgICAgICAgIHN2Yy0+bWlncmF0ZV9ycWQg PSB0cnFkOwogICAgICAgICBzZXRfYml0KF9WUEZfbWlncmF0aW5nLCAmc3ZjLT52Y3B1LT5wYXVz ZV9mbGFncyk7CiAgICAgICAgIHNldF9iaXQoX19DU0ZMQUdfcnVucV9taWdyYXRlX3JlcXVlc3Qs ICZzdmMtPmZsYWdzKTsKLSAgICAgICAgY3B1X3JhaXNlX3NvZnRpcnEoY3B1LCBTQ0hFRFVMRV9T T0ZUSVJRKTsKICAgICAgICAgU0NIRURfU1RBVF9DUkFOSyhtaWdyYXRlX3JlcXVlc3RlZCk7Cisg ICAgICAgIHRpY2tsZV9jcHUoY3B1LCBzdmMtPnJxZCk7CiAgICAgfQogICAgIGVsc2UKICAgICB7 Cg== --=-LABAbnYuUczIEhG+bcKs Content-Disposition: attachment; filename="xen-credit2-don-t-miss.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="xen-credit2-don-t-miss.patch"; charset="UTF-8" Y29tbWl0IGYzNmNlMDNmZmZhYjc1MjZkOWM5NGI0NjAyOGEyN2E3NTJlM2Y2MGUKQXV0aG9yOiBE YXJpbyBGYWdnaW9saSA8ZGFyaW8uZmFnZ2lvbGlAY2l0cml4LmNvbT4KRGF0ZTogICBXZWQgTWFy IDEgMTY6MjI6NDMgMjAxNyArMDEwMAoKICAgIHhlbjogY3JlZGl0MjogZG9uJ3QgbWlzcyBhY2Nv dW50aW5nIHdoaWxlIGRvaW5nIGEgY3JlZGl0IHJlc2V0LgogICAgCiAgICBBIGNyZWRpdCByZXNl dCBiYXNpY2FsbHkgbWVhbnMgZ29pbmcgdGhyb3VnaCBhbGwgdGhlCiAgICB2Q1BVcyBvZiBhIHJ1 bnF1ZXVlIGFuZCBhbHRlcmluZyB0aGVpciBjcmVkaXRzLCBhcyBhCiAgICBjb25zZXF1ZW5jZSBv ZiBhICdzY2hlZHVsaW5nIGVwb2NoJyBoYXZpbmcgY29tZSB0byBhbgogICAgZW5kLgogICAgCiAg ICBCbG9ja2VkIG9yIHJ1bm5hYmxlIHZDUFVzIGFyZSBmaW5lLCBhbGwgdGhlIGNyZWRpdHMKICAg IHRoZXkndmUgc3BlbnQgcnVubmluZyBzbyBmYXIgaGF2ZSBiZWVuIGFjY291bnRlZCB0bwogICAg dGhlbSB3aGVuIHRoZXkgd2VyZSBzY2hlZHVsZWQgb3V0LgogICAgCiAgICBCdXQgaWYgYSB2Q1BV IGlzIHJ1bm5pbmcgb24gYSBwQ1BVLCB3aGVuIGEgcmVzZXQgZXZlbnQKICAgIG9jY3VycyAob24g YW5vdGhlciBwQ1BVKSwgdGhhdCBkb2VzIG5vdCBnZXQgcHJvcGVybHkKICAgIGFjY291bnRlZC4g TGV0J3MgdGhlcmVmb3JlIGJlZ2luIHRvIGRvIHNvLCBmb3IgYmV0dGVyCiAgICBhY2N1cmFjeSBh bmQgZmFpcm5lc3MuCiAgICAKICAgIEluIGZhY3QsIGFmdGVyIHRoaXMgcGF0Y2gsIHdlIHNlZSB0 aGlzIGluIGEgdHJhY2U6CiAgICAKICAgICBjc2NoZWQyOnNjaGVkdWxlIGNwdSAxMCwgcnEjIDEs IGJ1c3ksIG5vdCB0aWNrbGVkCiAgICAgY3NjaGVkMjpidXJuX2NyZWRpdHMgZDF2NSwgY3JlZGl0 ID0gOTk5ODM1MywgZGVsdGEgPSAyMDI5OTYKICAgICBydW5zdGF0ZV9jb250aW51ZSBkMXY1IHJ1 bm5pbmctPnJ1bm5pbmcKICAgICAuLi4KICAgICBjc2NoZWQyOnNjaGVkdWxlIGNwdSAxMiwgcnEj IDEsIGJ1c3ksIG5vdCB0aWNrbGVkCiAgICAgY3NjaGVkMjpidXJuX2NyZWRpdHMgZDF2NiwgY3Jl ZGl0ID0gLTEzMjcsIGRlbHRhID0gOTk5OTU0NAogICAgIGNzY2hlZDI6cmVzZXRfY3JlZGl0cyBk MHYxMywgY3JlZGl0X3N0YXJ0ID0gMTA1MDAwMDAsIGNyZWRpdF9lbmQgPSAxMDUwMDAwMCwgbXVs dCA9IDEKICAgICBjc2NoZWQyOnJlc2V0X2NyZWRpdHMgZDB2MTQsIGNyZWRpdF9zdGFydCA9IDEw NTAwMDAwLCBjcmVkaXRfZW5kID0gMTA1MDAwMDAsIG11bHQgPSAxCiAgICAgY3NjaGVkMjpyZXNl dF9jcmVkaXRzIGQwdjcsIGNyZWRpdF9zdGFydCA9IDEwNTAwMDAwLCBjcmVkaXRfZW5kID0gMTA1 MDAwMDAsIG11bHQgPSAxCiAgICAgY3NjaGVkMjpidXJuX2NyZWRpdHMgZDF2NSwgY3JlZGl0ID0g MjAxODA1LCBkZWx0YSA9IDk3OTY1NDgKICAgICBjc2NoZWQyOnJlc2V0X2NyZWRpdHMgZDF2NSwg Y3JlZGl0X3N0YXJ0ID0gMjAxODA1LCBjcmVkaXRfZW5kID0gMTAyMDE4MDUsIG11bHQgPSAxCiAg ICAgY3NjaGVkMjpidXJuX2NyZWRpdHMgZDF2NiwgY3JlZGl0ID0gLTEzMjcsIGRlbHRhID0gMAog ICAgIGNzY2hlZDI6cmVzZXRfY3JlZGl0cyBkMXY2LCBjcmVkaXRfc3RhcnQgPSAtMTMyNywgY3Jl ZGl0X2VuZCA9IDk5OTg2NzMsIG11bHQgPSAxCiAgICAKICAgIFdoaWNoIHNob3dzIGhvdyBkMXY1 IGFjdHVhbGx5IGV4ZWN1dGVkIGZvciB+OS43OTYgbXMsCiAgICBvbiBwQ1BVIDEwLCB3aGVuIHJl c2V0X2NyZWRpdCgpIGlzIGV4ZWN1dGVkLCBvbiBwQ1BVCiAgICAxMiwgYmVjYXVzZSBvZiBkMXY2 J3MgY3JlZGl0cyBnb2luZyBiZWxvdyAwLgogICAgCiAgICBXaXRob3V0IHRoaXMgcGF0Y2gsIHRo aXMgOS43OTZtcyBhcmUgbm90IGFjY291bnRlZAogICAgdG8gYW55b25lLiBXaXRoIHRoaXMgcGF0 Y2gsIGQxdjUgaXMgY2hhcmdlZCBmb3IgdGhhdCwKICAgIGFuZCBpdHMgY3JlZGl0cyBkcm9wIGRv d24gZnJvbSA5Nzk2NTQ4IHRvIDIwMTgwNS4KICAgIAogICAgQW5kIHRoaXMgaXMgaW1wb3J0YW50 LCBhcyBpdCBtZWFucyB0aGF0IGl0IHdpbGwKICAgIGJlZ2luIHRoZSBuZXcgZXBvY2ggd2l0aCAx MDIwMTgwNSBjcmVkaXRzLCBpbnN0ZWFkCiAgICBvZiAxMDUwMDAwMCAod2hpY2ggaGUgd291bGQg aGF2ZSwgYmVmb3JlIHRoaXMgcGF0Y2gpLgogICAgCiAgICBCYXNpY2FsbHksIHdlIHdlcmUgZm9y Z2V0dGluZyBvbmUgcm91bmQgb2YgYWNjb3VudGluZwogICAgaW4gZXBvY2ggeCwgZm9yIHRoZSB2 Q1BVcyB0aGF0IGFyZSBydW5uaW5nIGF0IHRoZSB0aW1lCiAgICB0aGUgZXBvY2ggZW5kcy4gQW5k IHRoaXMgbWVhbnQgZmF2b3VyaW5nIGEgbGl0dGxlIGJpdAogICAgdGhlc2Ugc2FtZSB2Q1BVcywg aW4gZXBvY2ggeCsxLCBwcm92aWRpbmcgdGhlbSB3aXRoCiAgICB0aGUgY2hhbmNlIG9mIGV4ZWN1 dGUgbG9uZ2VyIHRoYW4gdGhlaXIgZmFpciBzaGFyZS4KICAgIAogICAgU2lnbmVkLW9mZi1ieTog RGFyaW8gRmFnZ2lvbGkgPGRhcmlvLmZhZ2dpb2xpQGNpdHJpeC5jb20+CgpkaWZmIC0tZ2l0IGEv eGVuL2NvbW1vbi9zY2hlZF9jcmVkaXQyLmMgYi94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYwpp bmRleCA5MDVmYjEyLi5jODZmNTQ4IDEwMDY0NAotLS0gYS94ZW4vY29tbW9uL3NjaGVkX2NyZWRp dDIuYworKysgYi94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYwpAQCAtNzA3LDE0ICs3MDcsMjMg QEAgc3RhdGljIHZvaWQgcmVzZXRfY3JlZGl0KGNvbnN0IHN0cnVjdCBzY2hlZHVsZXIgKm9wcywg aW50IGNwdSwgc190aW1lX3Qgbm93LAogCiAgICAgbGlzdF9mb3JfZWFjaCggaXRlciwgJnJxZC0+ c3ZjICkKICAgICB7CisgICAgICAgIHVuc2lnbmVkIGludCBzdmNfY3B1OwogICAgICAgICBzdHJ1 Y3QgY3NjaGVkMl92Y3B1ICogc3ZjOwogICAgICAgICBpbnQgc3RhcnRfY3JlZGl0OwogCiAgICAg ICAgIHN2YyA9IGxpc3RfZW50cnkoaXRlciwgc3RydWN0IGNzY2hlZDJfdmNwdSwgcnFkX2VsZW0p OworICAgICAgICBzdmNfY3B1ID0gc3ZjLT52Y3B1LT5wcm9jZXNzb3I7CiAKICAgICAgICAgQlVH X09OKCBpc19pZGxlX3ZjcHUoc3ZjLT52Y3B1KSApOwogICAgICAgICBCVUdfT04oIHN2Yy0+cnFk ICE9IHJxZCApOwogCisgICAgICAgIC8qCisgICAgICAgICAqIElmIHN2YyBpcyBydW5uaW5nLCBp dCBpcyBvdXIgcmVzcG9uc2liaWxpdHkgdG8gbWFrZSBzdXJlLCBoZXJlLAorICAgICAgICAgKiB0 aGF0IHRoZSBjcmVkaXQgaXQgaGFzIHNwZW50IHNvIGZhciBnZXQgYWNjb3VudGVkLgorICAgICAg ICAgKi8KKyAgICAgICAgaWYgKCBzdmMtPnZjcHUgPT0gY3Vycl9vbl9jcHUoc3ZjX2NwdSkgKQor ICAgICAgICAgICAgYnVybl9jcmVkaXRzKHJxZCwgc3ZjLCBub3cpOworCiAgICAgICAgIHN0YXJ0 X2NyZWRpdCA9IHN2Yy0+Y3JlZGl0OwogCiAgICAgICAgIC8qIEFuZCBhZGQgSU5JVCAqIG0sIGF2 b2lkaW5nIGludGVnZXIgbXVsdGlwbGljYXRpb24gaW4gdGhlCg== --=-LABAbnYuUczIEhG+bcKs-- --=-3mGIUHF2tGQVBruDBPFr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYtuojAAoJEBZCeImluHPuxJkQAIqL+NB7md19tjGESOY71wic beivhcniLaEK4RFLR/hXQaYd+U7tRTn1N77fJ4JWrEIlStjbJ/PbuN6i/80u+USR QPWi3agGnUrlEx5xQNO26BzsFrXiwYC3svfDAJDvVFSZjPtqZwfdcp4fjPtcoDrR gU0ft3I82EzzImawtaLmDtYyrRN+KnHp2J5GfFPSWNnUWSk0jYmxKuc/T6J84Sv9 7juzDESqFyD8HArNpiJdDiCHg72dVt8mZgZPwOvt6Iwu2ScmyIhOGmPZiCMYWCIx 8HkD4JJz89aftslU9qAuZQYy+w/XJeA4iNlmWsTXeTFwTX2VSFkdyz90KiYUmAxb frEO1HZVM/eOq4QCmZ+6ueOFcDF+UpWf6TWWfMOcSU1eKCcnUC7VlbVKnUjIN2Pw l+BVk2TRVVgGLYRPguYbEjlCfeSmbjdbekIeqWenHD7kJ/0ol8Wnb1nd2mcXyQ8I h6EbpWjCGJhfm+1qF/OO8x0aT/9P6v1ZZNIMabyBtODl6E/eqfM+M444WozMuwdi xVO+92bXEz1WkzmL2x8p3LNLInkKYNs4Cjz4jM9jdnmDG1rQB+MS+i9NBw/M/3u0 VQQs8CqbQsvgR9M/W1tWWwGBTS11J+zsbMFIxkOOyuYzC8244H/l/RgeXcggXmpx d98/kWq6AUywG5ZsKS84 =jBOo -----END PGP SIGNATURE----- --=-3mGIUHF2tGQVBruDBPFr-- --===============6202923010649291561== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============6202923010649291561==--