From: Dario Faggioli <dario.faggioli@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Anshul Makkar <anshul.makkar@citrix.com>
Subject: Re: [PATCH v4 5/7] xen: credit2: group the runq manipulating functions.
Date: Wed, 1 Mar 2017 18:12:08 +0100 [thread overview]
Message-ID: <1488388328.5548.150.camel@citrix.com> (raw)
In-Reply-To: <e7f7403c-735b-f748-f897-1e4b4be8a877@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1138 bytes --]
On Wed, 2017-03-01 at 16:41 +0000, George Dunlap wrote:
> On 01/03/17 14:53, Dario Faggioli wrote:
> > @@ -590,7 +590,7 @@ static s_time_t c2t(struct
> > csched2_runqueue_data *rqd, s_time_t credit, struct c
> > }
> >
> > /*
> > - * Runqueue related code
> > + * Runqueue related code.
>
> You realize we changed CODING_STYLE to not require a full stop if
> there
> was only one line? This isn't a complete sentence so I would leave
> the
> full stop out.
>
Now that you mention it, yes, I remember the thread. But my
understanding of the results of such thread was actually a bit
different from what you say and explain above.
So...
> But that's just for future reference -- I don't care enough about
> this
> in general, I just wanted to raise it to your attention. :-)
>
...that's been useful and much appreciated. Thanks!
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-01 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 14:52 [PATCH v4 0/7] xen: credit2: improve style, and tracing; fix two bugs Dario Faggioli
2017-03-01 14:52 ` [PATCH v4 1/7] xen: credit2: always mark a tickled pCPU as... tickled! Dario Faggioli
2017-03-01 14:52 ` [PATCH v4 2/7] xen: credit2: don't miss accounting while doing a credit reset Dario Faggioli
2017-03-01 14:53 ` [PATCH v4 3/7] xen: credit2: make accessor helpers inline functions instead of macros Dario Faggioli
2017-03-01 16:36 ` George Dunlap
2017-03-01 14:53 ` [PATCH v4 4/7] xen: credit2: tidy up functions names by removing leading '__' Dario Faggioli
2017-03-01 14:53 ` [PATCH v4 5/7] xen: credit2: group the runq manipulating functions Dario Faggioli
2017-03-01 16:41 ` George Dunlap
2017-03-01 17:12 ` Dario Faggioli [this message]
2017-03-01 14:53 ` [PATCH v4 6/7] xen/tools: tracing: trace (Credit2) runq traversal Dario Faggioli
2017-03-01 14:53 ` [PATCH v4 7/7] xen/tools: tracing: Report next slice time when continuing as well as switching Dario Faggioli
2017-03-01 16:53 ` George Dunlap
2017-03-01 15:34 ` [PATCH v4 0/7] xen: credit2: improve style, and tracing; fix two bugs Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488388328.5548.150.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=anshul.makkar@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).