* [PATCH 1/2] break
@ 2017-03-07 23:32 Andrew Cooper
2017-03-07 23:32 ` [PATCH 2/2] x86/emul: Avoid #UD when emulating v{, u}comis{s, d} Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2017-03-07 23:32 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper
---
xen/arch/x86/x86_emulate/x86_emulate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c
index 1b507f7..e09975c 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -7920,7 +7920,7 @@ int x86_emulate_wrapper(
* called hvm_inject_hw_exception() rather than using
* x86_emul_hw_exception().)
*/
- ASSERT(ctxt->event_pending == (rc == X86EMUL_EXCEPTION));
+ /* ASSERT(ctxt->event_pending == (rc == X86EMUL_EXCEPTION)); */
return rc;
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] x86/emul: Avoid #UD when emulating v{, u}comis{s, d}
2017-03-07 23:32 [PATCH 1/2] break Andrew Cooper
@ 2017-03-07 23:32 ` Andrew Cooper
2017-03-08 8:30 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2017-03-07 23:32 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Jan Beulich
v{,u}comis{s,d} have two operands, so require vex.reg set to ~0.
Spotted by AFL
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
xen/arch/x86/x86_emulate/x86_emulate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c
index e09975c..08bd818 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -5673,6 +5673,7 @@ x86_emulate(
}
else
{
+ generate_exception_if(vex.reg != 0xf, EXC_UD);
host_and_vcpu_must_have(avx);
get_fpu(X86EMUL_FPU_ymm, &fic);
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] x86/emul: Avoid #UD when emulating v{, u}comis{s, d}
2017-03-07 23:32 ` [PATCH 2/2] x86/emul: Avoid #UD when emulating v{, u}comis{s, d} Andrew Cooper
@ 2017-03-08 8:30 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2017-03-08 8:30 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel
>>> On 08.03.17 at 00:32, <andrew.cooper3@citrix.com> wrote:
> v{,u}comis{s,d} have two operands, so require vex.reg set to ~0.
>
> Spotted by AFL
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
I'm sorry for the oversight.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-08 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-07 23:32 [PATCH 1/2] break Andrew Cooper
2017-03-07 23:32 ` [PATCH 2/2] x86/emul: Avoid #UD when emulating v{, u}comis{s, d} Andrew Cooper
2017-03-08 8:30 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).