From: Wei Chen <Wei.Chen@arm.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.chen@arm.com, steve.capper@arm.com,
Kaly.Xin@arm.com, julien.grall@arm.com, nd@arm.com
Subject: [PATCH 18/18] xen/arm: Handle guest external abort as guest SError
Date: Mon, 13 Mar 2017 18:56:03 +0800 [thread overview]
Message-ID: <1489402563-4978-19-git-send-email-Wei.Chen@arm.com> (raw)
In-Reply-To: <1489402563-4978-1-git-send-email-Wei.Chen@arm.com>
The guest generated external data/instruction aborts can be treated
as guest SErrors. We already have a handler to handle the SErrors,
so we can reuse this handler to handle guest external aborts.
Signed-off-by: Wei Chen <Wei.Chen@arm.com>
---
xen/arch/arm/traps.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 3b84e80..24511e5 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -2558,12 +2558,12 @@ static void do_trap_instr_abort_guest(struct cpu_user_regs *regs,
/*
* If this bit has been set, it means that this instruction abort is caused
- * by a guest external abort. Currently we crash the guest to protect the
- * hypervisor. In future one can better handle this by injecting a virtual
- * abort to the guest.
+ * by a guest external abort. We can handle this instruction abort as guest
+ * SError.
*/
if ( hsr.iabt.eat )
- domain_crash_synchronous();
+ return __do_trap_serror(regs, true);
+
if ( hpfar_is_valid(hsr.iabt.s1ptw, fsc) )
gpa = get_faulting_ipa(gva);
@@ -2661,12 +2661,10 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs,
/*
* If this bit has been set, it means that this data abort is caused
- * by a guest external abort. Currently we crash the guest to protect the
- * hypervisor. In future one can better handle this by injecting a virtual
- * abort to the guest.
+ * by a guest external abort. We treat this data abort as guest SError.
*/
if ( dabt.eat )
- domain_crash_synchronous();
+ return __do_trap_serror(regs, true);
info.dabt = dabt;
#ifdef CONFIG_ARM_32
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-13 10:56 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 10:55 [PATCH 00/18] Provide a command line option to choose how to handle SErrors Wei Chen
2017-03-13 10:55 ` [PATCH 01/18] xen/arm: Introduce a helper to get default HCR_EL2 flags Wei Chen
2017-03-15 0:24 ` Stefano Stabellini
2017-03-15 7:19 ` Wei Chen
2017-03-15 11:01 ` Julien Grall
2017-03-15 22:31 ` Stefano Stabellini
2017-03-16 7:44 ` Wei Chen
2017-03-13 10:55 ` [PATCH 02/18] xen/arm: Restore HCR_EL2 register Wei Chen
2017-03-15 0:25 ` Stefano Stabellini
2017-03-15 8:34 ` Wei Chen
2017-03-15 11:12 ` Julien Grall
2017-03-16 7:51 ` Wei Chen
2017-03-16 22:33 ` Stefano Stabellini
2017-03-16 22:46 ` Julien Grall
2017-03-21 0:31 ` Stefano Stabellini
2017-03-22 12:16 ` Julien Grall
2017-03-22 12:45 ` Mark Rutland
2017-03-22 13:41 ` Marc Zyngier
2017-03-22 17:54 ` Stefano Stabellini
2017-03-22 18:04 ` Julien Grall
2017-03-22 18:30 ` Mark Rutland
2017-03-22 22:06 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 03/18] xen/arm: Avoid setting/clearing HCR_RW at every context switch Wei Chen
2017-03-15 0:25 ` Stefano Stabellini
2017-03-15 9:08 ` Wei Chen
2017-03-16 22:40 ` Stefano Stabellini
2017-03-16 22:52 ` Julien Grall
2017-03-16 23:17 ` Stefano Stabellini
2017-03-17 6:51 ` Wei Chen
2017-03-17 7:05 ` Julien Grall
2017-03-17 17:46 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 04/18] xen/arm: Save HCR_EL2 when a guest took the SError Wei Chen
2017-03-15 0:27 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 05/18] xen/arm: Save ESR_EL2 to avoid using mismatched value in syndrome check Wei Chen
2017-03-16 13:50 ` Julien Grall
2017-03-16 22:27 ` Stefano Stabellini
2017-03-17 6:37 ` Wei Chen
2017-03-17 6:37 ` Wei Chen
2017-03-13 10:55 ` [PATCH 06/18] xen/arm: Introduce a virtual abort injection helper Wei Chen
2017-03-15 0:31 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 07/18] xen/arm: Introduce a command line parameter for SErrors/Aborts Wei Chen
2017-03-15 0:45 ` Stefano Stabellini
2017-03-15 9:13 ` Wei Chen
2017-03-13 10:55 ` [PATCH 08/18] xen/arm: Introduce a initcall to update cpu_hwcaps by serror_op Wei Chen
2017-03-16 23:30 ` Stefano Stabellini
2017-03-17 6:56 ` Wei Chen
2017-03-17 17:21 ` Stefano Stabellini
2017-03-20 6:48 ` Wei Chen
2017-03-13 10:55 ` [PATCH 09/18] xen/arm64: Use alternative to skip the check of pending serrors Wei Chen
2017-03-16 23:40 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 10/18] xen/arm32: Use cpu_hwcaps " Wei Chen
2017-03-16 23:44 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 11/18] xen/arm: Move macro VABORT_GEN_BY_GUEST to common header Wei Chen
2017-03-16 23:53 ` Stefano Stabellini
2017-03-17 6:57 ` Wei Chen
2017-03-13 10:55 ` [PATCH 12/18] xen/arm: Introduce new helpers to handle guest/hyp SErrors Wei Chen
2017-03-17 0:17 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 13/18] xen/arm: Replace do_trap_guest_serror with new helpers Wei Chen
2017-03-17 0:15 ` Stefano Stabellini
2017-03-13 10:55 ` [PATCH 14/18] xen/arm: Unmask the Abort/SError bit in the exception entries Wei Chen
2017-03-20 21:38 ` Stefano Stabellini
2017-03-22 8:49 ` Wei Chen
2017-03-22 12:26 ` Julien Grall
2017-03-22 22:21 ` Stefano Stabellini
2017-03-23 3:13 ` Wei Chen
2017-03-23 19:12 ` Julien Grall
2017-03-24 0:10 ` Stefano Stabellini
2017-03-24 8:11 ` Wei Chen
2017-03-24 16:56 ` Stefano Stabellini
2017-03-13 10:56 ` [PATCH 15/18] xen/arm: Introduce a helper to synchronize SError Wei Chen
2017-03-20 21:40 ` Stefano Stabellini
2017-03-20 21:44 ` Stefano Stabellini
2017-03-22 8:28 ` Wei Chen
2017-03-13 10:56 ` [PATCH 16/18] xen/arm: Isolate the SError between the context switch of 2 vCPUs Wei Chen
2017-03-20 21:46 ` Stefano Stabellini
2017-03-22 8:53 ` Wei Chen
2017-03-22 12:29 ` Julien Grall
2017-03-23 6:32 ` Wei Chen
2017-03-23 18:49 ` Stefano Stabellini
2017-03-13 10:56 ` [PATCH 17/18] xen/arm: Prevent slipping hypervisor SError to guest Wei Chen
2017-03-20 21:49 ` Stefano Stabellini
2017-03-13 10:56 ` Wei Chen [this message]
2017-03-20 21:53 ` [PATCH 18/18] xen/arm: Handle guest external abort as guest SError Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489402563-4978-19-git-send-email-Wei.Chen@arm.com \
--to=wei.chen@arm.com \
--cc=Kaly.Xin@arm.com \
--cc=julien.grall@arm.com \
--cc=nd@arm.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).