From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC 1/2] xen: credit2: flexible configuration of runqueues Date: Wed, 22 Mar 2017 15:17:36 +0100 Message-ID: <1490192256.14782.3.camel@citrix.com> References: <1489170396-22611-1-git-send-email-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4671137568111456045==" Return-path: In-Reply-To: <1489170396-22611-1-git-send-email-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: george.dunlap@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============4671137568111456045== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-C+G0l52ATMtO0egfhA3O" --=-C+G0l52ATMtO0egfhA3O Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Praveen, Thanks for working on this and sending the patches! A couple of things on the submission itself. When we send more than 1 patch, we say that we send a "patch series". That basically is a set of related patches. They may be related in various ways. For instance, each patch may be a piece, or a step, for implementing something (a feature, a bugfi, etc); or maybe they all do something similar to either the same or different subsystems. In any case, for making it better clear this fact that they are related, these patch series always assume the following format: - there is an email which acts as the introduction of the series,=C2=A0 which=C2=A0is often called cover letter, and is numbered as patch 0 of=C2= =A0 the series; - the emails containing actual patches, numbered starting from 1, are all sent as they were replies to the cover letter. In the cover letter, one usually introduces an explains the work being done, focusing on making it as easy as possible for the reviewers to understand anything that it is important they know when looking at the series. There are several examples of patch series in the xen-devel mailing list archives: https://lists.xen.org/archives/html/xen-devel/2017-02/threads.html https://lists.xen.org/archives/html/xen-devel/2017-02/msg03455.html https://lists.xen.org/archives/html/xen-devel/2017-02/msg01027.html https://lists.xen.org/archives/html/xen-devel/2017-01/msg02837.html And the topic of sending patch series is covered here: https://wiki.xen.org/wiki/Submitting_Xen_Project_Patches#Sending_the_patche= s_to_the_list As per how to actually send the various emails in such a way that they get to the list in the proper format, there are tools. I use stgit for development, and it supports doing that by means of `stg mail'. A lot of people which use "just" git, do use git-send-email. On Fri, 2017-03-10 at 23:56 +0530, Praveen Kumar wrote: > The idea is to give user more flexibility to configure runqueue > further. > For most workloads and in most systems, using per-core means have too > many > small runqueues. Using per-socket is almost always better, but it may > result > in too few big runqueues. >=20 > OPTION 1 : > -------- > The user can create runqueue per-cpu using Xen boot parameter like > below: >=20 > =C2=A0credit2_runqueue=3Dcpu >=20 > which would mean the following: > =C2=A0- pCPU 0 belong to runqueue 0 > =C2=A0- pCPU 1 belong to runqueue 1 > =C2=A0- pCPU 2 belong to runqueue 2 > =C2=A0and so on. >=20 > OPTION 2 : > -------- > Further user can be allowed to say something shown below : >=20 > =C2=A0credit2_runqueue=3D0,1,4,5;2,3,6,7;8,9,12,13;10,11,14,15 >=20 > or (with exactly the same meaning, but a perhaps more clear syntax): >=20 > =C2=A0credit2_runqueue=3D[[0,1,4,5][2,3,6,7][8,9,12,13][10,11,14,15]] >=20 > which would mean the following: > =C2=A0- pCPUs 0, 1, 4 and 5 belong to runqueue 0 > =C2=A0- pCPUs 2, 3, 6 and 7 belong to runqueue 1 > =C2=A0- pCPUs 8, 9, 12 and 13 belong to runqueue 2 > =C2=A0- pCPUs 10, 11, 14 and 15 belong to runqueue 3 >=20 > --- > PATCH 1/2 enables to create runqueue per-cpu [OPTION 1]. > --- >=20 So, this kind of high level summary about both patches 1 and 2 is probably similar to what a cover letter for this series should contain. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-C+G0l52ATMtO0egfhA3O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJY0oeAAAoJEBZCeImluHPuUQYP/2kgTtp6VBOGneTQ1S00jCA3 cjtryowRLrZC+ndiN+HW4KVEPA+d4mQcyWf+5KnrJ8dTfIQLJuv+Cwi2Ik013IKx z8YeceTJlKDX+rzeOt5HhxqHoxn6KbJlYLxhL0qYawqAfommaCVzJoyVHMYGM9k+ egshObTgMnVjAcpBfC2TAFEu7fU6I15yCC9nTCr2o1KIeaGXBsBF11n0CG2ZNc8d m5aUe9KUVZfwSwh6p/1Afh1V0WsHg1/TvWAZ2GyTAjiG9FAGEkX/cR6YMs8enthV 6wVqP25cQuPbxN64aQDHwQPIFDkbVeKIFUmaZM1eQt4wHaGApM9OlTcjMBNJacjX vaPxPyV1b6JT9q61ulwgbVcEKuIN+sM9CSG9BsxHsCyIPe4iliHTNyKjAGcGzpEJ 3UyNOjd8aR1vkZ14dFwwHnNKEDEMSfDETJmbmOjuApO0oaHW2oY9UQkomVSH8Ctd EdfdKT7boKri+2JB5bY7dD14cyMQrPizMFIeawV06X0xm//eCbR646Ixao0dHZSA SWgUHTCsBvqfmWWLWE4hUuNnBBd5J9ttNkP5ADWq1bmsaU9SJxGmoyjgR+KxX8UN WaslsennXfmbZ4wmTt4OwIusWXkW+HL9Io5ZE7j56/x9a46sReulJ7tlRH5W5fZ8 AkTukN4uj7Z4AOxSiSL2 =5XQO -----END PGP SIGNATURE----- --=-C+G0l52ATMtO0egfhA3O-- --===============4671137568111456045== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4671137568111456045==--