From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC 1/2] xen: credit2: flexible configuration of runqueues Date: Wed, 22 Mar 2017 15:24:13 +0100 Message-ID: <1490192653.14782.6.camel@citrix.com> References: <1489170396-22611-1-git-send-email-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1472732258917133703==" Return-path: In-Reply-To: <1489170396-22611-1-git-send-email-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: george.dunlap@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============1472732258917133703== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-T0wTiF9l6H8VPDSAI5vz" --=-T0wTiF9l6H8VPDSAI5vz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, now about the code. On Fri, 2017-03-10 at 23:56 +0530, Praveen Kumar wrote: > The user can create runqueue per-cpu using Xen boot parameter like > below: >=20 > =C2=A0credit2_runqueue=3Dcpu >=20 > which would mean the following: > =C2=A0- pCPU 0 belong to runqueue 0 > =C2=A0- pCPU 1 belong to runqueue 1 > =C2=A0- pCPU 2 belong to runqueue 2 > =C2=A0and so on. >=20 > Signed-off-by: Praveen Kumar >=20 > --- > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index af457c1..2bc0013 100644 > --- a/xen/common/sched_credit2.c > +++ b/xen/common/sched_credit2.c > @@ -301,6 +301,9 @@ integer_param("credit2_balance_over", > opt_overload_balance_tolerance); > =C2=A0 * want that to happen basing on topology. At the moment, it is > possible > =C2=A0 * to choose to arrange runqueues to be: > =C2=A0 * > + * - per-cpu: meaning that there will be one runqueue per logical > cpu. This > + *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0will happen when if the opt_runqueue parameter is set > to 'cpu'. > + * > =C2=A0 * - per-core: meaning that there will be one runqueue per each > physical > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0core of the host. This will happen if the > opt_runqueue > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0parameter is set to 'core'; >=20 This is ok, but you also need to=C2=A0modify the "credit2\_runqueue" sectio= n in docs/misc/xen-command-line.markdown . In fact, in order to not end up with outdated and incorrect documentation, we require that the docs are updated in the same patch that introduces something new (or changes something existing). Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-T0wTiF9l6H8VPDSAI5vz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJY0okNAAoJEBZCeImluHPubEIQAMSz5I2iJLyJD9eJg6mLsoyo N1ZKT52A41H2wMoOP3+vVOPAYFDLkuybESGpM2g+B0Ph3GEUpevKnXccKKfo85GI ChWRSRcxp697FttD8FSpcUnYKbWS2EcNRzBvsxO/YXWyfml04mhQJb17HkHej/CL 6pwcZQh7CIJdjF7r+oKdeqOr5LBcZeMA+i0DNxlz/XqZ56tHHbw/pqwxpfximWZ1 UG16WrOyb45TYqyVmYlNwb3cOXHB8NqLpZHYRH4Acs7ouUCrqHKYMBWWZH9bn8OJ isEw45pWXt45SuIQSQnHen72NTgu81BgRFBW2vUwIWSm7PzHjGY20Fj9gQ+S0BPP boTFcGSQ6Bsw1cLg/1A6XXJDFS1P3fCrHxDn8acFTrF7bWkw/ZR9LGXGu/sGQTEW K+TGLuoRCfPWtTgcMsx8ebcjOw1SJQ8Ce7ggGKpGg6UoEulZG52CEXx+fTdjQ22m 0oJon0gDiyUM6yCaZkja4vco11RKre/QpVnXy0Tl3L9die2azyxmUj8g71wjPQcx 2uV30Vu8kI/Jr3iOmUXoe1nIcva94BeHqd3n0jzabiy9/FQWRl9/3N0nHzCSiMWA uOecK/L3psa5NAXOw2+B82M12Kj4reJKnpE9xgGB70ffOEeMtroeemIKRL/+r9Os u1tf2y2aKLZsM+BhhRKP =y4zK -----END PGP SIGNATURE----- --=-T0wTiF9l6H8VPDSAI5vz-- --===============1472732258917133703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1472732258917133703==--