* [PATCH] x86/viridian: Annotate intentional fallthrough
@ 2017-03-22 18:32 Andrew Cooper
2017-03-23 9:18 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2017-03-22 18:32 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Paul Durrant, Jan Beulich
This stops Coverity complaining.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Paul Durrant <paul.durrant@citrix.com>
---
xen/arch/x86/hvm/viridian.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c
index b740224..75f165f 100644
--- a/xen/arch/x86/hvm/viridian.c
+++ b/xen/arch/x86/hvm/viridian.c
@@ -872,7 +872,7 @@ int viridian_hypercall(struct cpu_user_regs *regs)
default:
gprintk(XENLOG_WARNING, "unimplemented hypercall %04x\n",
input.call_code);
-
+ /* Fallthrough. */
case HvGetPartitionId:
case HvExtCallQueryCapabilities:
/*
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/viridian: Annotate intentional fallthrough
2017-03-22 18:32 [PATCH] x86/viridian: Annotate intentional fallthrough Andrew Cooper
@ 2017-03-23 9:18 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2017-03-23 9:18 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Paul Durrant, Xen-devel
>>> On 22.03.17 at 19:32, <andrew.cooper3@citrix.com> wrote:
> This stops Coverity complaining.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Oops, I should have remembered while reviewing ...
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-23 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 18:32 [PATCH] x86/viridian: Annotate intentional fallthrough Andrew Cooper
2017-03-23 9:18 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).