From: Oleksandr Grytsov <al1img@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Subject: [PATCH 0/2] libxl: add PV display device driver interface
Date: Thu, 23 Mar 2017 12:10:30 +0200 [thread overview]
Message-ID: <1490263832-9068-1-git-send-email-al1img@gmail.com> (raw)
From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Hi all,
We are working on series of PV drivers (display, sound, input etc.) and
would like to add their support to libxl and xl. These patches add PV display
device. PV display is based on [1] protocol.
During implementation I see a lot of code duplication. This problem was
mentioned in [2]. One of the solutions was to implement common parts in IDL
and make them autogenerated. On my side, to minimize the copy/pasting
I've moved common parts into macro functions: LIBXL_DEFINE_DEVICE_COMMIT,
LIBXL_DEFINE_DEVICE_LIST_GET, LIBXL_DEFINE_DEVICE_GETINFO etc.
Existing PV devices implementations can be reworked to use these macros as
well. Any other proposals to avoid the duplications are welcome.
Thanks.
[1] http://marc.info/?l=xen-devel&m=149000029128972&w=2
[2] http://marc.info/?l=xen-devel&m=145372933919792&w=2
Oleksandr Grytsov (2):
libxl: add PV display device driver interface
xl: add PV display device commands
tools/libxl/Makefile | 2 +-
tools/libxl/libxl.h | 21 ++++
tools/libxl/libxl_create.c | 1 +
tools/libxl/libxl_internal.h | 228 +++++++++++++++++++++++++++++++++++
tools/libxl/libxl_types.idl | 22 +++-
tools/libxl/libxl_types_internal.idl | 1 +
tools/libxl/libxl_utils.h | 4 +
tools/libxl/libxl_vdispl.c | 137 +++++++++++++++++++++
tools/xl/Makefile | 1 +
tools/xl/xl.h | 3 +
tools/xl/xl_cmdtable.c | 16 +++
tools/xl/xl_parse.c | 44 ++++++-
tools/xl/xl_parse.h | 2 +-
tools/xl/xl_vdispl.c | 162 +++++++++++++++++++++++++
14 files changed, 639 insertions(+), 5 deletions(-)
create mode 100644 tools/libxl/libxl_vdispl.c
create mode 100644 tools/xl/xl_vdispl.c
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-03-23 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 10:10 Oleksandr Grytsov [this message]
2017-03-23 10:10 ` [PATCH 1/2] libxl: add PV display device driver interface Oleksandr Grytsov
2017-03-23 10:10 ` [PATCH 2/2] xl: add PV display device commands Oleksandr Grytsov
2017-03-23 10:21 ` [PATCH 0/2] libxl: add PV display device driver interface Juergen Gross
2017-03-23 11:32 ` al1img .
2017-03-23 12:08 ` Juergen Gross
2017-03-23 14:23 ` al1img .
2017-03-23 14:58 ` Juergen Gross
2017-03-23 15:55 ` al1img .
2017-03-24 10:35 ` Oleksandr Grytsov
2017-03-27 15:10 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490263832-9068-1-git-send-email-al1img@gmail.com \
--to=al1img@gmail.com \
--cc=oleksandr_grytsov@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).