Re: [PATCH v2 2/2] xen: sched: improve robustness (and rename) DOM2OP()

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1570 bytes --]

On Mon, 2017-03-27 at 14:23 +0100, George Dunlap wrote:
> On 17/03/17 18:19, Dario Faggioli wrote:
> > --- a/xen/common/schedule.c
> > +++ b/xen/common/schedule.c
> > @@ -77,8 +77,25 @@ static struct scheduler __read_mostly ops;
> >           (( (opsptr)->fn != NULL ) ? (opsptr)->fn(opsptr,
> > ##__VA_ARGS__ )  \
> >            : (typeof((opsptr)->fn(opsptr, ##__VA_ARGS__)))0 )
> >  
> > -#define DOM2OP(_d)    (((_d)->cpupool == NULL) ? &ops : ((_d)-
> > >cpupool->sched))
> > -static inline struct scheduler *VCPU2OP(const struct vcpu *v)
> > +static inline struct scheduler *dom_get_scheduler(const struct
> > domain *d)
> 
> Hmm -- I agree that VCPU2OP is probably not the right name, but I'm
> not
> a fan of the new name either; and I don't have an option I like
> better yet.
> 
> With your permission I'll check in the first patch and come back to
> this.
> 
Ok. The renaming was the least important part of what is done in this
patch.

But indeed I do think that, while here, we should take the chance the
names as well (especially considering they won't be macro, so the "all
capital letters" should go).

But, sure, go ahead with the first patch... I'll try to think and
propose a better name when/if I'll fine one. :-)

Thanks,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel