From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 2/2] xen: sched: improve robustness (and rename) DOM2OP() Date: Mon, 27 Mar 2017 17:13:45 +0200 Message-ID: <1490627625.25397.5.camel@citrix.com> References: <148977465656.22479.5382577625088079334.stgit@Palanthas.fritz.box> <148977478448.22479.13625390869019347980.stgit@Palanthas.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5436484616112356792==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csWLN-0004Jt-RC for xen-devel@lists.xenproject.org; Mon, 27 Mar 2017 15:14:05 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: Juergen Gross , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============5436484616112356792== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-hc3C5DJzYFUE03HbSxhZ" --=-hc3C5DJzYFUE03HbSxhZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-03-27 at 14:23 +0100, George Dunlap wrote: > On 17/03/17 18:19, Dario Faggioli wrote: > > --- a/xen/common/schedule.c > > +++ b/xen/common/schedule.c > > @@ -77,8 +77,25 @@ static struct scheduler __read_mostly ops; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(( (opsptr)= ->fn !=3D NULL ) ? (opsptr)->fn(opsptr, > > ##__VA_ARGS__ )=C2=A0=C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: (ty= peof((opsptr)->fn(opsptr, ##__VA_ARGS__)))0 ) > > =C2=A0 > > -#define DOM2OP(_d)=C2=A0=C2=A0=C2=A0=C2=A0(((_d)->cpupool =3D=3D NULL)= ? &ops : ((_d)- > > >cpupool->sched)) > > -static inline struct scheduler *VCPU2OP(const struct vcpu *v) > > +static inline struct scheduler *dom_get_scheduler(const struct > > domain *d) >=20 > Hmm -- I agree that VCPU2OP is probably not the right name, but I'm > not > a fan of the new name either; and I don't have an option I like > better yet. >=20 > With your permission I'll check in the first patch and come back to > this. >=20 Ok. The renaming was the least important part of what is done in this patch. But indeed I do think that, while here, we should take the chance the names as well (especially considering they won't be macro, so the "all capital letters" should go). But, sure, go ahead with the first patch... I'll try to think and propose a better name when/if I'll fine one. :-) Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-hc3C5DJzYFUE03HbSxhZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJY2SwpAAoJEBZCeImluHPunjoP/j+8+974FPFumSnAf9bol7yM D5+t8fxOfDenkXOu56asdiOoxgcTdAhbwbCZnwNBG1kMY5MUB2iVwfGx0032l1CV xE3o6/XFljNXbFVVeV1DtEVLh2azRpPW7zmzZRpNyE6A+X96D7dpfCKGan4bGxhT QwggiQs905oCfZ9LAeDJogdAvO9rk6QjdSr0soygC0p4xBYIFipMRpCssgwcVnjD vwuUi52yOwCCEstdVQoIj2BSvTZaIvtxZt+9o4pCsOfZ9gHFQyjqqPGHGjMzax3p hKvIwdnk/vh33JE3ZVjrh2ASmB80d2ZrtJabNq+ZZ1gVLRZsEvXROFABPoUgWwS+ 4Roz0KN3+HatYgesWZ9CCQZqwxVsrbXbNfx2n4B0BJ49+WzcLe0kpadtDLYzR0g5 EWHbE2g0GcAEC2+M5LWXPC6FlVS48GLgxXvabQpsQddWSE/+/4rjVeYzyzC6Y4QE t2udW9o1fA81MS/R6izxknOoMMv7uLnlK/AMkdh3jFUO8kMaTQYlh7BH9w3JHNzn ri5FX9iAUb4/oA3orBn7/GkbjoG+r7ZZFGjZ9y325Hpa513TOKUZ0QM43FVA8N7e BHeBc/ZbGnr31EXqNemKFMklFirDwsfwysM1eV9UacKgtsaN6p3a0yUFfcvYiuSg Jj6U6JgB5q07eUSBY75J =2ZCq -----END PGP SIGNATURE----- --=-hc3C5DJzYFUE03HbSxhZ-- --===============5436484616112356792== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5436484616112356792==--