From: Dario Faggioli <dario.faggioli@citrix.com>
To: Praveen Kumar <kpraveen.lkml@gmail.com>, george.dunlap@eu.citrix.com
Cc: xen-devel@lists.xen.org
Subject: Re: [RFC PATCH v3 1/2] xen: credit2: enable per cpu runqueue creation
Date: Fri, 31 Mar 2017 09:18:31 +0200 [thread overview]
Message-ID: <1490944711.25397.17.camel@citrix.com> (raw)
In-Reply-To: <20170330192810.6755-2-kpraveen.lkml@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 857 bytes --]
Hello Praveen,
On Fri, 2017-03-31 at 00:58 +0530, Praveen Kumar wrote:
> The patch introduces a new command line option 'cpu' that when used
> will
> create runqueue per logical pCPU.
>
I'd add a quick note about why we think it's a good idea to have this.
Something like:
"This may be useful for small systems, and also for development,
performance evaluation and comparison."
> Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
>
With that addition, at least this patch can have my:
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-31 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 19:28 [RFC PATCH v3 0/2] xen: credit2: flexible configuration for runqueues Praveen Kumar
2017-03-30 19:28 ` [RFC PATCH v3 1/2] xen: credit2: enable per cpu runqueue creation Praveen Kumar
2017-03-31 7:18 ` Dario Faggioli [this message]
2017-03-30 19:28 ` [RFC PATCH v3 2/2] xen: credit2: provide custom option to create Praveen Kumar
2017-03-31 8:32 ` Dario Faggioli
2017-04-14 18:14 ` Praveen Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490944711.25397.17.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=kpraveen.lkml@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).