From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 04/10] xen/arm: vpl011: Provide a knob in libxl to enable/disable pl011 emulation
Date: Mon, 3 Apr 2017 15:14:27 +0530 [thread overview]
Message-ID: <1491212673-13476-5-git-send-email-bhupinder.thakur@linaro.org> (raw)
In-Reply-To: <1491212673-13476-1-git-send-email-bhupinder.thakur@linaro.org>
An option is provided in libxl to enable/disable pl011 emulation while
creating a guest domain.
Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
---
tools/libxl/libxl_create.c | 12 ++++++++++++
tools/libxl/libxl_internal.h | 5 +++++
tools/libxl/libxl_types.idl | 2 ++
tools/libxl/xl_cmdimpl.c | 4 ++++
4 files changed, 23 insertions(+)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index e3bc257..9a59354 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -208,6 +208,8 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
libxl_defbool_setdefault(&b_info->disable_migrate, false);
+ libxl_defbool_setdefault(&b_info->enable_pl011, false);
+
for (i = 0 ; i < b_info->num_iomem; i++)
if (b_info->iomem[i].gfn == LIBXL_INVALID_GFN)
b_info->iomem[i].gfn = b_info->iomem[i].start;
@@ -546,6 +548,9 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
flags |= XEN_DOMCTL_CDF_hap;
}
+ if (libxl_defbool_val(d_config->b_info.enable_pl011))
+ flags |= XEN_DOMCTL_VCONSOLE_enable;
+
/* Ultimately, handle is an array of 16 uint8_t, same as uuid */
libxl_uuid_copy(ctx, (libxl_uuid *)handle, &info->uuid);
@@ -910,6 +915,11 @@ static void initiate_domain_create(libxl__egc *egc,
goto error_out;
}
+ if (libxl_defbool_val(d_config->b_info.enable_pl011))
+ state->vconsole_enabled = true;
+ else
+ state->vconsole_enabled = false;
+
if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM &&
(libxl_defbool_val(d_config->b_info.u.hvm.nested_hvm) &&
libxl_defbool_val(d_config->b_info.u.hvm.altp2m))) {
@@ -926,6 +936,8 @@ static void initiate_domain_create(libxl__egc *egc,
goto error_out;
}
+ state->config.console_domid = state->console_domid;
+
ret = libxl__domain_make(gc, d_config, &domid, &state->config);
if (ret) {
LOGD(ERROR, domid, "cannot make domain: %d", ret);
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 5f46578..2406eaa 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1128,6 +1128,11 @@ typedef struct {
uint32_t num_vmemranges;
xc_domain_configuration_t config;
+
+ /* Virtual console mfn and port. */
+ unsigned long vconsole_mfn;
+ uint32_t vconsole_port;
+ bool vconsole_enabled;
} libxl__domain_build_state;
_hidden int libxl__build_pre(libxl__gc *gc, uint32_t domid,
diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
index a612d1f..fe7f795 100644
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -105,6 +105,7 @@ libxl_console_type = Enumeration("console_type", [
(0, "UNKNOWN"),
(1, "SERIAL"),
(2, "PV"),
+ (3, "VCON"),
])
libxl_disk_format = Enumeration("disk_format", [
@@ -460,6 +461,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
("disable_migrate", libxl_defbool),
("cpuid", libxl_cpuid_policy_list),
("blkdev_start", string),
+ ("enable_pl011", libxl_defbool),
("vnuma_nodes", Array(libxl_vnode_info, "num_vnuma_nodes")),
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 358757f..4f4d4e6 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -1433,6 +1433,8 @@ static void parse_config_data(const char *config_source,
if (!xlu_cfg_get_long (config, "maxvcpus", &l, 0))
b_info->max_vcpus = l;
+ xlu_cfg_get_defbool(config, "pl011", &b_info->enable_pl011, 0);
+
parse_vnuma_config(config, b_info);
/* Set max_memkb to target_memkb and max_vcpus to avail_vcpus if
@@ -3788,6 +3790,8 @@ int main_console(int argc, char **argv)
type = LIBXL_CONSOLE_TYPE_PV;
else if (!strcmp(optarg, "serial"))
type = LIBXL_CONSOLE_TYPE_SERIAL;
+ else if (!strcmp(optarg, "vcon"))
+ type = LIBXL_CONSOLE_TYPE_VCON;
else {
fprintf(stderr, "console type supported are: pv, serial\n");
return EXIT_FAILURE;
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-03 9:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 9:44 [PATCH 00/10] pl011 emulation support in Xen Bhupinder Thakur
2017-04-03 9:44 ` [PATCH 01/10] xen/arm: vpl011: Add pl011 uart emulation " Bhupinder Thakur
2017-04-12 16:32 ` Wei Liu
2017-04-19 0:15 ` Stefano Stabellini
2017-04-19 7:28 ` Bhupinder Thakur
2017-04-19 8:36 ` Julien Grall
2017-04-19 18:40 ` Stefano Stabellini
2017-04-25 7:31 ` Bhupinder Thakur
2017-04-25 17:56 ` Stefano Stabellini
2017-04-26 7:49 ` Bhupinder Thakur
2017-04-26 8:13 ` Julien Grall
2017-04-26 17:03 ` Stefano Stabellini
2017-04-03 9:44 ` [PATCH 02/10] xen/arm: vpl011: Add new virtual console hvm params " Bhupinder Thakur
2017-04-19 0:22 ` Stefano Stabellini
2017-04-19 8:48 ` Bhupinder Thakur
2017-04-03 9:44 ` [PATCH 03/10] xen/arm: vpl011: Enable pl011 emulation for a guest domain " Bhupinder Thakur
2017-04-19 0:27 ` Stefano Stabellini
2017-04-03 9:44 ` Bhupinder Thakur [this message]
2017-04-12 16:32 ` [PATCH 04/10] xen/arm: vpl011: Provide a knob in libxl to enable/disable pl011 emulation Wei Liu
2017-04-13 8:19 ` Bhupinder Thakur
2017-04-13 8:37 ` Wei Liu
2017-04-19 0:29 ` Stefano Stabellini
2017-04-19 9:17 ` Bhupinder Thakur
2017-04-19 10:25 ` Wei Liu
2017-04-19 11:06 ` Julien Grall
2017-04-03 9:44 ` [PATCH 05/10] xen/arm: vpl011: Allocate a new PFN in the toolstack for the virtual console Bhupinder Thakur
2017-04-12 16:33 ` Wei Liu
2017-04-13 8:37 ` Bhupinder Thakur
2017-04-13 8:53 ` Wei Liu
2017-04-19 0:36 ` Stefano Stabellini
2017-04-19 10:28 ` Wei Liu
2017-04-19 11:01 ` Julien Grall
2017-04-19 13:05 ` Bhupinder Thakur
2017-04-19 13:35 ` Julien Grall
2017-04-03 9:44 ` [PATCH 06/10] xen/arm: vpl011: Add new parameters to xenstore " Bhupinder Thakur
2017-04-12 16:32 ` Wei Liu
2017-04-25 10:18 ` Bhupinder Thakur
2017-04-25 11:55 ` Wei Liu
2017-04-19 18:58 ` Stefano Stabellini
2017-04-03 9:44 ` [PATCH 07/10] xen/arm: vpl011: Add a new console type to domain structure in xenconsole Bhupinder Thakur
2017-04-12 16:33 ` Wei Liu
2017-04-13 9:49 ` Bhupinder Thakur
2017-04-19 19:09 ` Stefano Stabellini
2017-04-03 9:44 ` [PATCH 08/10] xen/arm: vpl011: Modify the APIs in xenconsole to acces both PV and VCON consoles Bhupinder Thakur
2017-04-12 16:33 ` Wei Liu
2017-04-24 14:52 ` Bhupinder Thakur
2017-04-03 9:44 ` [PATCH 09/10] xen/arm: vpl011: Add new virtual console to xenconsole client Bhupinder Thakur
2017-04-19 18:55 ` Stefano Stabellini
2017-04-03 9:44 ` [PATCH 10/10] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-04-19 18:53 ` Stefano Stabellini
2017-04-20 12:47 ` [PATCH 00/10] pl011 emulation support in Xen Julien Grall
2017-04-26 15:21 ` Bhupinder Thakur
2017-04-26 17:09 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491212673-13476-5-git-send-email-bhupinder.thakur@linaro.org \
--to=bhupinder.thakur@linaro.org \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).